3259 Commits

Author SHA1 Message Date
aleos
76923ac506 Corrected some refiner checks
* Follow up to e24d30a.
* Fixes #2505 and fixes #2507.
* Added a missing material check for Suhnbi.
* Added a missing safe limit check for normal refiners. Safe limit was always 0.
Thanks to @mazvi, @Mickosis, and @cydh!
2017-10-14 09:11:30 -04:00
Aleos
6a2c1229d0 Updated Rebellion class (#1692)
* Updated Rebellion class
* Information based on Rebellion Awakening patch from kRO.
- http://ro.gnjoy.com/news/update/View.asp?seq=183&curpage=1
* Fixes #859 and fixes #1449.
Thanks to @RagnarokNova and Fyrus for their information!
2017-10-12 11:04:03 -04:00
Jeybla
2676d05394 Jobmaster update (#2369)
* Major changes due to readability and some corrections
* Adds the option to disable Rebirth Classes
* Adds the possibility to give players job related 
  Equipment (mostly weapons) on job change
* Adds more level requirement settings
* Adds BabyExpanded and BabySummoner Jobs
* Thanks to @Braniff, @mazvi, @Mikegyver, @Lemongrass3110, @Akkarinage, @Stolao and @secretdataz!
2017-10-06 17:40:39 +02:00
Vincent Stumpf
cd43f32ffb Shadow Refiner and getequiprefinecost (#2447)
* Fixes #2445 and fixes #2446.
* Fixed shadow refiner.
— The script uses the values of the array instead of the indexes to loop through it.
* Fixed segfault in getequiprefinecost.
— No checks in getequiprefinecost meant there were possibilities using negative indexes in arrays.
* Added to the script documentation what happens on failure when calling getequiprefinecost (it returns -1).
Thanks to @vstmpf, @crazystorm2017, and @hendra814!
2017-09-24 09:53:40 -04:00
anity99
052b9bc819 Fix duplicate location (#2442)
* Corrected Shadow Blacksmith overlapping with Mighty Hammer.
Thanks to @anity99!
2017-09-22 14:19:50 -04:00
anity99
c71f105083 Fix typo in achievements.txt (#2433)
* Resolves some typos in the AG_ADVENTURE script resulting in some not being able to be completed.
Thanks to @anity99!
2017-09-20 14:39:23 -04:00
Jittapan Pluemsumran
e24d30a711 Refine overhaul (#2295)
* Converted refine_db.txt to refine_db.yml
* Refine success rates can now be set in refine_db.yml. rAthena's default NPCs will respect this database by default.
* Added shadow equipment refiner
Thanks to @Akkarinage @aleos89 @Atemo and @Mikegyver for their inputs.
2017-09-18 21:52:52 +07:00
Atemo
3cc29d04cc Fixed another issue follow up b275412bcc 2017-09-08 19:22:34 +02:00
Jey
b275412bcc Fixes a warning in HorrorToyFactory.
* Replaces an unattached sleep2 to sleep
* Thanks to @admkakaroto and @technoken!
2017-09-08 11:22:23 +02:00
aleos
470364cbe1 Corrected a second changequest attempt
* Related to #2070.
Thanks to @LiamKarlMitchell!
2017-08-31 20:24:04 -04:00
Aleos
4539d557e2 Added script command sc_end_class (#2368)
* Added a new script command sc_end_class to remove status changes from any learned skills.
* Adjusted the custom Reset NPC to make use of this behavior.
Thanks to @sader1992!

* Follow up to f93680b
* Adjusted documentation.

* Follow up to f93680b
* Removed the check from script command resetskill.
* Added a new script command sc_end_class.

* Fixed a compile error
* Corrected the define of the script command.
* Adjusted some documentation.
* Reverted some formatting from the original commit.
Thanks to @sader1992 and @Lemongrass3110!
2017-08-25 13:26:22 -04:00
Atemo
11d33007d9 Initial release of Ghost Palace Memorial (#2331)
* Initial release of Ghost Palace Memorial (Walkthrough conversion)

Thanks @Lemongrass3110, @aleos89 and @Jeybla for their help!
Thanks to Divine Pride for the monsters datas !
2017-08-15 20:11:50 +02:00
keitenai
f4de91b407 Fixed incorrect use of 'close' command 2017-08-14 23:25:29 +08:00
keitenai
fcc4936b23 Fixed script dialogue's NPC name to its proper order. (#2320)
Fixed script dialogue's NPC name to its proper order.

Credit @keitenai
2017-08-13 14:35:51 +02:00
Atemo
087a72731d Fixed storage condition in lasagna town
From cb580e1f0d
Credits @exneval
2017-08-12 14:13:51 +02:00
Atemo
115c1b9f5f Fixed a typo in quests_eclage.txt issue #2311 2017-08-05 13:42:39 +02:00
Atemo
9d6b3d06a9 Fixed readparam when 2nd parameter is a variable
Related issue #2276
2017-08-04 15:45:57 +02:00
Daegaladh
627a178ca9 Fixed a lot of "next" on Old Pharmacist (#2308)
* Corrected the usage of script command next which was causing the NPC dialogue to be combined in certain cases.
Thanks to @Daegaladh!
2017-08-03 14:17:21 -04:00
Aleos
7f5411da07 Initial release of the Achievement System (#2044)
* Information based on kRO patch notes.
- http://ro.gnjoy.com/news/update/View.asp?seq=163&curpage=1
* Includes Title System which is integrated into the Achievement System.
* Includes RODEX integration for rewards.
* Added new atcommand reloadachievementdb.
* Added new script commands achievementinfo, achievementadd, achievementremove, achievementcomplete, and achievementexists.
Thanks to @Lux-uri, @RagnarokNova, @Lemongrass3110, and @Tokeiburu for their help!
2017-07-27 09:33:03 -04:00
Lemongrass3110
f0ab8d2a52 Overhauled and dropped packet db (#2263)
Adds support for a lot of missing clients and features almost all clients from 2016 and 2017
clientinfo.xml's version value will be ignored from now on
By setting PACKETVER the server will configure everything else on it's own from now on
Dropped is_clientver script command
And a lot more
2017-07-15 22:45:12 +02:00
Lemongrass3110
45e91e2a3a Added clan emblems to the NPCs (#2221)
* Added clan emblems to the NPCs
* Partial merge of/based on idathena/trunk@1f84c5d
Thanks to @exneval
2017-06-30 12:31:06 -04:00
Atemo
a5afb06979 Initial release of lasagna npcs (#2105)
* First release of lasagna npcs (playing conversion).

* Added a new parameter for npctalk script command
Target for <flag>:
- bc_all  : Broadcast message is sent server-wide (only in the chat window).
- bc_map  : Message is sent to everyone in the same map as the source of the npc.
- bc_area : Message is sent to players in the vicinity of the source (default value).
- bc_self : Message is sent only to player attached.

* Implemented doram food buffs

* Updated npctalk:
*npctalk "<message>"{,"<NPC name>",<flag>};
- Empty string for "<NPC name>" now means attached NPC

* Added flag parameter for unittalk script command
*unittalk <GID>,"<text>"{,<flag>};
flag: Specify target
   bc_area - Message is sent to players in the vicinity of the source (default).
   bc_self - Message is sent only to player attached.
 
* Updated classchange script command:
classchange(<view id>{,"<NPC name>",<flag>});
flag: Specify target
   bc_area - Data is sent to players in the vicinity of the source (default).
   bc_self - Data is sent only to player attached.

* Updated Time Limit for quests to allow HH:MM format

Thanks @secretdataz, @Lemongrass3110, @aleos89, @Jeybla, @anacondaqq, @jenkijo, @sikiro, @admkakaroto for contributing !
2017-06-26 00:54:25 +02:00
Lemongrass3110
58776da1ac Basic RODEX support (#2186)
Adds basic support for the new mail UI RODEX.

Fixes #1567

Thanks to @RagnarokNova, @Atemo, @aleos89 and everyone else that helped me with this.
Additionally I would like to thank @jezznar and @hazimjauhari90 for their good testing in the pull request.
2017-06-21 00:00:29 +02:00
Lemongrass3110
d0ca637ddd Fixed vip_status command (#2184)
Fixed different return types for the same function call
Also introduced constants for better function usage.

Fixes #2183
Thanks to @anacondaqq
2017-06-20 19:22:46 +02:00
Atemo
809754379b Added 'warp2' NPC
Unlike 'warp', 'warp2' NPC will also be triggered by hidden player.
Thanks @secretdataz and @Lemongrass3110 !

* Replace script using OnTouch:([\r\n\t]+)warp by warp2

* Removed sprite id from warp duplicates in Bangungot instance

* Fixed a bug where warp/warp2 parsing is too greedy
2017-05-09 23:45:34 +02:00
Atemo
1e1d7e54f0 Merged Faceworm Instance from idathena https://github.com/idathena/tr… (#1889)
* Merged Faceworm Instance from idathena 20f71d8c62

Credits to @exneval !
2017-05-09 13:34:19 +02:00
Aleos
10b512b859 Updated Giant Fly Wing behavior (#2098)
* Party members should be recalled to their own positions in a 3x3 area around the party leader.
* Added two missing client messages.
* Adjusted script command warpparty to support range values.
* Adjusted script command warpparty to not warp the party leader if "Leader" is passed as the map.
2017-05-02 20:51:26 -04:00
Jeybla
9e6b02ae59 Fixes a getcharid error message. (#2106)
* In quests/quests_morroc.txt Continental Guard.
2017-04-29 19:20:25 +02:00
Lemongrass3110
cdc0527b71 Converted some scripts to warps (#1947)
Credits to @Atemo!
2017-04-24 23:54:43 +02:00
Atemo
c098d0c518 Fixed wrong condition in monk.txt issue #2057
Thanks @TheNoobCompany !
2017-04-12 20:42:25 +02:00
Liam Mitchell
398619556a Update dts_warper.txt moc_ruins wrong id. (#2038)
* Update dts_warper.txt moc_ruins wrong id.

Wrong display ID and directions.
#2037

* Tweaked dts_warper.

According to what @Atemo said in issue #2037
2017-04-10 19:04:58 +02:00
Atemo
73b798bf12 Removed extra semi-colon 2017-04-06 14:40:36 +02:00
Atemo
a6b252c01e Added rid check in SaraMemory.txt (issue #2032) 2017-04-04 19:20:26 +02:00
Atemo
0b5687db13 Fixed a typo in GeffenMagicTournament.txt issue #2002
Thanks to @srhmike
2017-03-27 18:35:42 +02:00
Atemo
08338e0a64 Summoner Eden Group Equip Quest Implementation
Edit from PR https://github.com/rathena/rathena/pull/1152
Credit @MysticFurur0RE
2017-03-22 21:43:08 +01:00
Atemo
f581d26c21 Partial fix of issue #2002 (cannot access instance variable "'ins_nyd2") 2017-03-22 21:30:33 +01:00
Atemo
17a273864a Added missing quest ID in quest_db.txt (issue #2012)
Partial fix of issue #2002, Incorrect use of 'close' command in quests_eclage.txt
2017-03-20 15:30:46 +01:00
Atemo
f6488a2a9e Corrected a warp destination typo in The Sign quest (credit c215c9c21a) 2017-03-06 23:26:10 +01:00
Atemo
c6e09fdf35 Added parenthesis in tu_ma_th01.txt 2017-03-06 23:21:05 +01:00
Jittapan Pluemsumran
1a233da1ab Removed an extra semicolon in kafras.txt 2017-03-06 18:26:14 +07:00
Lemongrass3110
800f22b77b Removed an unused character variable
Fixes #1976
2017-03-02 23:20:45 +01:00
Atemo
4270ef876d Fixed #1981 Clearchus Mercenary Npc
- Delete / give the quest when the time limit has been reached
2017-02-24 12:42:09 +01:00
aleos
0c20c596e0 Expanded script command setbattleflag
* Fixes #1945.
* Adds an optional flag to reload the monster database for specific map flags that are EXP/drop related.
* This resolves having to add atcommand reloadmobdb after setting the battle configs.
* Adjusted atcommand setbattleflag to also have the optional parameter.
* The reload should only have to be called on the final setbattleflag use.
2017-02-11 20:55:35 -05:00
Atemo
dfaee699fb Fixed bugs in Bangungot Hospital instance (issue #1504) (effects, warps, announce..) 2017-01-25 20:19:47 +01:00
Atemo
7e2dedc828 Corrected areamonster from aegis conversion 2017-01-25 20:04:41 +01:00
Jittapan Pluemsumran
14b381dcc7 Initial Release of Guild Daily Mission (#1582)
* Implemented Guild Daily Mission
Thanks to @cydh, @Atemo, and @Lemongrass3110 for their help!
2017-01-24 10:47:20 -05:00
Atemo
09cbf2dfa6 Follow up a63604d92a1c8090257277e353fd28464e859c08
The display name of the NPC won't get appended in front of the message for globalmes script command.

Corrected area monsters spawn in Nydhoggr's Nest Instance
2017-01-22 19:14:19 +01:00
Atemo
c6470ff4ff Clean-up permanent monster spawn: (#1831)
* Clean-up permanent monster spawn:
- <delay1>,<delay2>,<event> are actually optionnal field
- <event> value 0 and 1 are meaningless (actually event name with length < 4 are skipped)

* Exported monster AI constants

* Updated docs for monster size constants (already exported)
Notes:
- the default size for monster script cmd was small not medium
- monster script cmd now display a warning for size above SZ_BIG (previously SZ_ALL)

* - Fixed an issue to make <xs> and <ys> optionnals
- Updated npcs scripts

* Leftover in the docs for permanent monster spawn

* Corrected english docs. Credit to @aleos89
Added additionnal warning for xs / ys negative input. Credit @Lemongrass3110 

Thanks to @cydh for the idea
2017-01-22 19:03:08 +01:00
Atemo
c6ab72207e Horror toy factory (#1813)
* Initial release of Horror Toy Factory instance.
Thanks to @aleos89, @secretdataz, @Lemongrass3110
Took some part from 52f6420abc
Credit @exneval

Todo : implement NPC_HELLBURNING skill
2017-01-18 03:25:12 +01:00
Lemongrass3110
2043c95e66 Refactored hardcoded npc event names (#1767)
While refactoring those events the following other changes were made:

Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.

The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.

All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).

All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).

Renamed a few events in the script configuration to match the other names

Added constants for months and weekdays

Additionally added constants for gettime types to make it easier to read.

Replaced all existing usages I found with their proper new syntax or better fitting functions.
2017-01-10 22:58:04 +01:00