8844 Commits

Author SHA1 Message Date
ai4rei
5ed2bd8367 * Merged enumeration update from renewal [14699/branches/renewal] for a future commit.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-17 20:16:42 +00:00
ai4rei
ba8bd70b0c * Updated configure/make scripts to resolve various issues.
- Added detection whether or not -fPIC switch is required when compiling shared objects (plug-ins) to resolve compile issues on 64-bit platforms (topic:208746).
- Native 'strnlen' implementations are now detected and disable the one in strlib (bugreport:1261).
- Define 'DB_MANUAL_CAST_TO_UNION' is now set when necessary (bugreport:1261).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14708 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-16 19:36:51 +00:00
ai4rei
86091a86f7 * Added support for client GM command /check (related r12076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14707 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-15 11:47:31 +00:00
ai4rei
2fb2b1444f * Fixed drop list of map flag 'pvp_nightmaredrop' not getting cleared upon @reloadscript (bugreport:4282, follow up to r14668).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14706 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 23:34:40 +00:00
ai4rei
0cd89ec86f * Fixed GMs with GM level equal to 'lowest_gm_level' being treated as normal players in 'gm_can_party' check (bugreport:4162, since r13143).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14705 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 21:13:19 +00:00
ai4rei
531584b648 * Fixed a crash when script 'npctalk' is given too long string (bugreport:4759, related r2145).
- Fixed related buffer overflows in message related clif functions (since r1182, r14270).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14704 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-14 12:49:08 +00:00
brianluau
90a0575afa - Fixed the cutin example in script_commands.txt
- Updated TortoiseSVN and eAthena SVN links in readme.html

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14703 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-12 23:30:20 +00:00
ai4rei
9f2620f2fa * Fixed script command 'bpet' (Pet Incubator) displaying an empty egg list when attempting to hatch a pet while already having one out (bugreport:3313).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14702 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-09 11:27:27 +00:00
ai4rei
63321f205e * Moved script constant manipulation code into separate functions script_get_constant / script_set_constant. [Ai4rei]
- Added protection against overwriting existing names in script constant creation code.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 10:43:51 +00:00
ai4rei
da989bb356 * Added support for new delayed character deletion.
- Asks for birth date associated with the account and has a waiting time of 24 hours by default (setting).
- For SQL apply upgrade_svn14700.sql to upgrade table `char`; for TXT no action is necessary, as it upgrades itself.
- This completes support for clients 2010-08-03aRagexeRE and later.
* Updated login sql engine version, missed during `birthdate` addition (follow up to r14672).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14700 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 02:36:43 +00:00
ai4rei
4592b9832d * Updates to various client packets.
- Renamed clif_set0199 and clif_send0199 to clif_map_property and clif_map_property_mapall respectively and added an enumeration for currently known map properties.
- Renamed clif_set01D6 to clif_map_type and added an enumeration for currently known map types.
- Resolved undocumented field of packet 0x22e (ZC_PROPERTY_HOMUN) to attack range.
- Fixed aspd field of packet 0xbd (ZC_STATUS) getting filled with karma value.
- Removed commented clif_skillinfo (duplicate of clif_item_skill).
- Other minor comment updates and 'FIXME' assignments.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14698 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-08 00:37:33 +00:00
L0ne_W0lf
25e986bc8a - Changed some duplicates so they use a floating NPC as their original. (bugreport:1395)
- Fixed the NPC looking for missing label in the Cursed Spirit quest. (bugreport:4654)
- Applied Uno's fix for the cooldown condition in Endless Tower. (bugreport:4677)
- Removed level requirement for the Viens Stone gathering quest. (bugreport:4678)
- Added the missing restricted skills to zone 6 for Endless Tower. (bugreport:4707)
  It's worth noting how much I hate the system for restricting skills per zone.
- Fixed Cat Hand warp service warping players to all warp options. (bugreport:4709)
- Fixed floor 75 warp in endless tower disabling the wrong warp. (bugreport:4711)
- Added a condition for Chungwolmang to only delete items if a certain ID is specified. (bugreport:4719)
- Corrected a mobcount specifying the wrong NPC in the Moscovia Ship quest. (bugreport:4736)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14697 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 22:10:54 +00:00
ai4rei
bc2ec92a4a * Replaced 'nameid < 500' checks in script commands 'countitem', 'countitem2' and 'autoequip' with stricter ones.
- This should stop meaningless itemdb_search warnings from said commands when an invalid item id is used.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14696 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 12:18:46 +00:00
ai4rei
1bb6a3d506 * Fixed NPCs with closing parenthesis in their name could not be duplicated (bugreport:3235).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:45:10 +00:00
ai4rei
0045508031 * Fixed closing 'switch' curly not causing script EOL processing to trigger, leading to the script line after the switch being handled as belonging to the curly-less statement block (bugreport:3273, since r3422).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14694 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 01:02:57 +00:00
ai4rei
6cbc16833f * Removed unnecessary getlogincount.pl, mapcheck.sh and mapchecker.sh tools (topic:262934).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14693 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-06 00:08:50 +00:00
ai4rei
8dc5d7029c * Fixed non-windows 'findfile' utils function missing a 'closedir' call (bugreport:4739, since r1629).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14692 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-02-02 20:00:12 +00:00
ai4rei
2bc3dafd59 * Inventory and Cart item arrays are no longer getting compacted on each log-in/teleport/warp.
- This also resolves yet another issue caused by r14685 (bugreport:2604).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14691 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 20:40:16 +00:00
ai4rei
7557d37013 * Various accumulated cleanups and fixes.
- Improved the compile speed for files which include common/socket.h on windows builds (related r10471).
- Moved FIFOSIZE_SERVERLINK define from common/mmo.h to common/socket.h (since it is a server connection FIFO size setting).
- Fixed script command 'areamobuseskill' canceling monster's skill cast before it determined it's new target, which could be 'none' (bugreport:3272, since r13897).
- Added a protection against attempts to read an empty backup / write to a full backup in skill_dance_switch as per TODO from r11347.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14690 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 12:39:54 +00:00
ai4rei
8fb6c1f646 * Fixed faulty WFIFO reallocation causing memory exhaustion (bugreport:4737, since r1816, related r11503, r11571, r11886 and r12232).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14689 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-31 11:30:57 +00:00
ai4rei
9492535e65 * Fixed equipped items' bonus no longer working after log-in until next status recalc, due to missing pc_setequipindex which was previously called by pc_checkitem (bugreport:2604, since r14685).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-30 21:36:11 +00:00
ai4rei
884cb80892 * Removed @aw/@away which duplicates and collides with client's /am (away message) (bugreport:1235, topic:163083, since r4351).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14686 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-29 11:30:24 +00:00
ai4rei
342f5db18c * Fixed a map-server crash when invalid items are deleted (option 'item_check') from a logging-in character (bugreport:2604).
- This removes the pc_checkitem call from pc_authok, as the check is done in clif_parse_LoadEndAck as well, after first status calc has taken place.
- Inventory list is now sent before pc_checkitem in clif_parse_LoadEndAck, so that deleted items do not show up as 'unknown item'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14685 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-29 10:46:01 +00:00
ai4rei
b3efe1d8b4 * Fixed @accept not checking, whether or not a duel is already full (bugreport:2740, since r4111).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14684 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-28 02:20:13 +00:00
ai4rei
7a85df4fe0 * Resolving allow/deny IP rules not working (bugreport:2632).
- Fixed 'mask' being filled with 'ip' when standard mask was specified (since r9647).
- Fixed 'ip' and 'mask' (bit mask) being stored in wrong byte order (network order instead of host order) (since r10162).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14683 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-28 01:38:33 +00:00
ai4rei
0f1c66191c * Fixed buyers, that are currently in a vending shop could be fooled into buying an item at different price than they see by reopening the vending shop (bugreport:4728).
- This implements the official vending shop unique id handling (previously mistaken for char id), made compatible with packets before it's introduction (follow up to r14234).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14682 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-26 11:52:44 +00:00
ai4rei
10d1f8f8eb * Added documentation for undocumented bonuses (bugreport:4727, follow up to r302, r354, r485, r699, r928, r1116, r6221, r7982, r10031, r13596 and r14018).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14681 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-24 21:30:43 +00:00
ai4rei
dd4a090c69 * Some cleaning here and there.
- Fixed a typo in basejob_baseclass_upper sample script (since r3893).
- Fixed (for sake of consistency) usage of 'sd' before corresponding nullpo check in party_invite (bugreport:2752).
- Fixed atcommand config reading would not cap level for charcommands, when using atcommand level as fallback (bugreport:2961, since r13409).
- Removed orphaned clif_mob_hp declaration from clif.h (bugreport:2788, since r2092).
- Removed unnecessary look-up in itemdb_available macro, as dummy_item is considered unavailable.
- Removed leftover shortlist linked-list struct (followup to r10507).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14680 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-23 18:07:00 +00:00
ai4rei
2d495bd0f2 * Updated Aegis NPC ID constants from current npcidentity.lub (bugreport:4706).
- Fixes some incorrect NPC ID constants (since r12780).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14679 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-23 13:14:56 +00:00
ai4rei
639bafa88e * Fixed solo dance/star gladiator warm AoE no longer following the owner and cloaking wall rules no longer working (bugreport:4720, since r14671).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14677 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-19 21:13:59 +00:00
ai4rei
9799eb3699 * Various fixes for scripts that are disabled by default.
- Fixed name collision in Baphomet Jr. taming item quest (custom) with 'Little Boy' in cities/lutie.txt
- Fixed name collision in THQS_Quests (custom) with 'Little Girl' in cities/lutie.txt
- Fixed outdated reference to npc_dynamic_shop sample (follow up to r14277).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14676 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-16 14:05:21 +00:00
ai4rei
178cc183ab * Fixed a map-server crash, when a script attempts to call a local function, which has only a forward declaration. Such functions now count as script parse error (bugreport:4009, since r3422).
* Fixed definitions of local functions would set a label reference, even when their name was already taken (follow up to r14600, since r3422).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14675 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-16 12:51:27 +00:00
ai4rei
a4b7cce2c5 * Various accumulated insignificant fixes to documentation, examples and comments.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14674 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-15 20:12:51 +00:00
ai4rei
7919c7d9fc * Added 'birthdate' field to account data. For SQL apply upgrade_svn14672.sql to upgrade table login; for TXT no action is necessary, as it upgrades itself.
- Control panel developers are encouraged to enable players to modify this value, as it is required for new character deletion (2010-08-03aRagexeRE and later, not yet implemented).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14672 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 23:38:31 +00:00
ai4rei
a7810e9646 * Removed unconditional redundant status change checks before status_change_end calls (follow up to r12890).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14671 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 22:04:20 +00:00
ai4rei
ad4e9bbee1 * Replaced remaining occurences of '-1' with 'INVALID_TIMER', where appropriate (follow up to r12998).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14670 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 21:00:38 +00:00
ai4rei
47ca51f9e2 * Removed 'gui' plug-in (support plug-in for 3rd party eAthena GUI front-ends) (topic:262934).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14669 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-14 12:22:12 +00:00
ai4rei
0204e9c914 * Fixed mapflags 'restricted', 'nocommand', 'bexp' and 'jexp' still not getting completely initialized upon @reloadscript (bugreport:4710, follow up to r14548).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14668 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 20:09:22 +00:00
ai4rei
3e4934d780 * Removed ladmin (remote administration tool), all related support code and the checkversion.pl tool with it's support code, which was shared with ladmin (topic:262934, related bugreport:1147, bugreport:1889, r9408 and r9610).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14667 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 11:42:12 +00:00
ai4rei
43ce11026b * Fixed chrif-packet processing considering free/unused packet IDs incorrectly as variable length packets (-1 = variable length, 0 = disabled packet).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14666 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 11:10:23 +00:00
ai4rei
ba5d1ec3ac * Added support for creating account through the console-plugin on login-server (replaces ladmin functionality unavailable through atcommands).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14665 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 10:27:17 +00:00
ai4rei
4f517e1ebb * Reformatting and minor cleanups to console-plugin related code.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14664 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-13 09:34:49 +00:00
ai4rei
825df9dda1 * Fixed script command 'cleararray' setting 1 element more, than it is told to (bugreport:2047, since r12253).
- Fixed 'inaccessible element 127' issue in 'cleararray', 'setarray' (since r10813) and 'copyarray' (since r14608) script commands (bugreport:864, related r12253, follow up to r14608).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14663 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 20:45:18 +00:00
ai4rei
5a2da0f184 * Fixed monster level not getting updated in monster name (option 'show_mob_info'), when a monster levels up (option 'mobs_level_up') (follow up to r8644, related r187).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14662 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 10:17:52 +00:00
ai4rei
4cd68d40e1 * Made script command 'charisalpha' always return 1 when 'isaplha' is true, rather than to return the return value of 'isalpha' which is only defined as zero/non-zero and can be different from 1 (bugreport:2024, related r2003).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14661 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-10 09:56:19 +00:00
ai4rei
ab332bd663 * Fixed packet_len entry for packet 0x289 (ZC_PC_CASH_POINT_UPDATE) not matching the actual size used in clif_cashshop_ack (bugreport:4701, since r14639, follow up to r12264).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14660 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-09 16:37:43 +00:00
ai4rei
5f93676dea * Fixed script command 'progressbar' resuming fails on second invocation, when there was no script pause between the first and second call (bugreport:4698, since r14024).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14659 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:28:41 +00:00
ai4rei
c8f5056a4a * Fixed kill steal protection result in skill casting (unit_skilluse_id2) not getting evaluated (bugreport:1808, since r12203).
- Moved kill steal protection in skill casting to be only executed, after the actual target has been determined and validated (since r12203).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14658 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:25:59 +00:00
ai4rei
bc191110f2 * Applied fix provided by Valaris to make /pvpinfo actually work. (bugreport:1785, since r1602).
- Filled-in missing packet fields and documented the packet. Note, that this command does not show anything outside of PvP maps (client-side limitation).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14657 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:19:07 +00:00
ai4rei
f543097124 * Fixed @homlevel usage message stating, that deleveling is possible, although it is not (bugreport:1485, since r10272).
- The command now fails, if it is given a zero or negative value.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14656 54d463be-8e91-2dee-dedb-b68131a5f0ec
2011-01-08 12:05:13 +00:00