14209 Commits

Author SHA1 Message Date
aleos89
dc8d466b03 Minor define cleanups
* Removed some variable defines that were redefines.
2016-10-31 21:58:28 -04:00
aleos89
c1d9520019 Added an extra ammo requirement for specific skills (fixes #1683)
* Severe Rainstorm, Round Trip, and Fire Rain now require +1 to their ammo requirement in order to successfully cast the skill.
* These skills will still consume their normal ammo amount.
Thanks to Fyrus for data mining!
2016-10-31 17:08:44 -04:00
Playtester
9a130fa0e8 SG counter and other status variables (bugreport:7449)
- Fixed extra status variables not being cleared correctly when the killed unit did not have any status change
(e.g. SG counter will now be set back to 0 when a monster dies)

Reference: https://rathena.org/board/tracker/issue-7449-storm-gust-counter-does-not-get-reset-on-mob-dead/
2016-10-30 13:27:30 +01:00
Akkarinage
644d809ddb Added missing items for IG_Mysterious_Travel_Sack4
Used Divine-Pride as a source of data. Their information seems to be the most up-to-date source at the moment.

Signed-off-by: Akkarinage <akkarin@rathena.org>
2016-10-30 10:24:23 +07:00
Playtester
5d24d73abf Lex Divina on allies (fixes #1668)
- Lex Divina can now be cast on a silenced ally
- When casting Lex Divina on an ally that is not silenced, it will no longer display the skill animation
2016-10-29 19:43:53 +02:00
aleos89
f310f335a1 Merge branch 'master' of https://github.com/rathena/rathena 2016-10-29 12:44:41 -04:00
aleos89
561a874833 Fixed Falcon Assault element (fixes #1659)
* Partial revert of 1d8bec3.
* Element should always be neutral.
* Renewal mode ignores the target's defense cards.
2016-10-29 12:44:11 -04:00
Lemongrass3110
6f67a65855 Added documentation for item links in mes (#1616)
Fixes #1614
2016-10-29 16:28:51 +01:00
aleos89
a0caaa1036 Fixed cart data for older cart types
* Follow up to c0bd422.
* Resolves older carts that don't use the SC_PUSH_CART status to update their weight and item data properly.
* Moved to pc_scdata_received so that it will hit both versions just fine.
Thanks to @Lemongrass3110!
2016-10-28 17:51:58 -04:00
aleos89
481a730ebc Adjusted some script syntax
* Follow up to d017e24.
Thanks to @Tokeiburu!
2016-10-28 17:33:30 -04:00
Jey
c14e67426b Fixes Phantom Thrust in PvE. 2016-10-28 12:27:52 +07:00
aleos89
c0bd422af2 Resolved some more inventory issues
* Moved storage type loading further up the chain to ensure data is loaded sooner.
* Resolved cart weight and cart count to update properly.
* Resolved item display index not displaying in the correct order when opening a Vending Shop.
Thanks to @Tokeiburu!
2016-10-27 20:28:31 -04:00
aleos89
e9c5dc6e16 Fixed instance maps not being freed
* Follow up to 2cfb844.
* Resolves instance maps not getting freed when the instance is destroyed.
Thanks to @Akkarinage!
2016-10-26 19:18:57 -04:00
Smokexyz
428e516187 Typo in ipban.c (#1654) 2016-10-24 23:40:52 +02:00
Jittapan Pluemsumran
1c74af7b1f Merge pull request #1637 from rathena/hotfix/issue1636
Fixed unknown state handling in mob skills
2016-10-23 18:29:33 +07:00
Playtester
6dfaa0b17b Siroma and Imp Cards (fixes #1646)
- Pre-re: Skill-specific cast time reductions no longer stack additively with global cast time reductions
2016-10-22 12:48:07 +02:00
Playtester
04cf397ea5 Occult Impaction damage (fixes #1641)
- Fixed Occult Impaction damage being double as high as it should be
- In renewal, the skill ratio is now applied to the piercing effect
(If a skill deals 400% damage, the piercing effect will now also be 4 times more effective.)
2016-10-22 12:32:26 +02:00
Akkarinage
d20cbcae48 Removed use of petheal command from pet_db.txt in both PRE and RE modes. (#1648)
Removed use of petheal command from pet_db.txt in both PRE and RE modes.
* Changed documentation to show deprecation more prominently.
* Closes #1576.
* Removed script command petheal.

Signed-off-by: Akkarinage <akkarin@rathena.org>
2016-10-21 15:25:32 -04:00
Lemongrass3110
40430d6cb5 Fixing buildbots(for real)
Sorry guys this should not have landed in master...
2016-10-20 00:27:53 +02:00
Lemongrass3110
7d0931a45d Follow up 3108bb1
Fixed a typo with configure call
2016-10-20 00:14:02 +02:00
Lemongrass3110
ed53167bc8 Follow up abd9809
appveyor lost the quotes
2016-10-20 00:11:52 +02:00
Lemongrass3110
abd98090d1 Follow up to dd55592 2016-10-20 00:01:03 +02:00
Lemongrass3110
dd555926a0 Reenabled buildbot defines
Now builds will fail if any warnings or errors occur.

Removed duplicated "matrix" keyword I added accidentally in 3108bb1.
Removed a default warning in run once mode in the character server. Follow up to a0b3e51
2016-10-19 23:58:29 +02:00
Lemongrass3110
3108bb1265 Added a configure option for vip features
Added the new option to the CI matrix
2016-10-19 23:15:13 +02:00
Lemongrass3110
15b40509d6 Added a -D equivalent for msbuild
Fixes appveyor not building in pre-renewal mode
2016-10-19 23:14:44 +02:00
Lemongrass3110
4db687c7a4 Fixed unknown state handling in mob skills 2016-10-19 14:46:11 +02:00
Lemongrass3110
b2f0ffb947 Fixed a potential server crash in mob_chat_db
Fixes #1635
Thanks to @Temtaime
2016-10-19 12:24:46 +02:00
Lemongrass3110
3ad16f04fb Merge pull request #1634 from Temtaime/patch-1
Fix type in warning message

Thanks to @Temtaime
2016-10-19 12:18:32 +02:00
Temtaime
655d6f56e7 Fix type in warning message 2016-10-19 12:35:12 +03:00
Aleos
e93c8880b3 Updated Manhole skill behavior (#1617)
* Updated Manhole skill behavior
* Fixes #1601
* GvG and Battleground monster objects are not able to be targeted by Manhole.
* Removed the usage of Strip Accessory on targets who are affected by Manhole.
Thanks to @ignizh!
2016-10-18 17:59:32 -04:00
Lemongrass3110
73eb96f358 Introducing charpointer macros for fifo/buffers (#1624)
* Introducing charpointer macros for fifo/buffers
2016-10-18 23:35:21 +02:00
Lemongrass3110
56c9765fe0 Fixed a wrong close in the eye of hellion quest
Merges HerculesWS/Hercules@d8441a3
Thanks to @Ridley8819
2016-10-18 22:49:18 +02:00
aleos89
031adff925 Updated Ranger Traps behavior
* Fixes #1611.
* Magenta, Cobalt, Maize, and Verdure Traps should permanently change the element of the target.
2016-10-18 21:54:46 +02:00
Lemongrass3110
55c5627eef Fixed compilation warning in pre-re
Fixes #1627
Thanks to @keitenai
2016-10-17 13:53:04 +02:00
rAthenaAPI
a0c7d6e2fe SQL synchronization 2016-10-16 23:07:52 +02:00
Lemongrass3110
568262faf4 Added latest npc constants
Also added some mob placeholders
2016-10-16 23:07:28 +02:00
Lemongrass3110
57131f286c Fixed some compile warnings
Fixes #1623
Thanks to @lelouch22
2016-10-16 14:20:17 +02:00
Lemongrass3110
48c43cf92f Refactored clif_charnameack
Added support for ZC_ACK_REQNAMEALL2 which is used from 2015-05-13 and higher
Added packet documentation for ZC_ACCEPT_ENTER3
Fixed some visual effects not being resent when using `@refresh`. Thanks to @Grantea
2016-10-16 12:58:03 +02:00
aleos89
7e2efec61b Moved some inventory checks
* Resolved item bonuses not properly being given that get applied before the player's inventory is received.
* Resolved rental items that have Status Changes attached to them not getting removed if the timer expired when the player logs in.
* Removed an extra call for player's with item sets.
Thanks to @Tokeiburu!
2016-10-14 12:50:06 -04:00
Jittapan Pluemsumran
09cb81d98e
Added a sample for utilizing the random option system. 2016-10-14 19:38:15 +07:00
Lemongrass3110
2bde36fb9d Merge pull request #1563 from rathena/cleanup/npc_name_length
Expand NPC Name Length to 50

Thanks to @cydh!
2016-10-14 09:37:36 +02:00
Lemongrass3110
6a8985531b Fixed NPC markets
Fixed signedness warnings for the sanity zero-terminations
2016-10-14 09:14:22 +02:00
Lemongrass3110
e443f846c6 Increased EVENT_NAME_LENGTH and some more cleanups
Fixed an invalid reference in clif.c(follow up to 008be23)
Moved the OnWhisperGlobal name definition to the other special event name declarations
Increased EVENT_NAME_LENGTH from 51 to 77 characters because it uses NPCs exname which can be up to 50 characters now
Added a warning when an NPCs exname is too long for an OnWhisperEvent
2016-10-14 09:13:53 +02:00
Lemongrass3110
b60f74c3df Sanity zero-termination for NAME_LENGTH usages 2016-10-14 09:13:21 +02:00
Lemongrass3110
4d71a12d00 Fixed a few EVENT_NAME_LENGTH usages 2016-10-14 09:11:28 +02:00
Cydh Ramdh
d3077435e8 Expand NPC Name Length to 50
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-14 09:11:28 +02:00
Cydh Ramdh
748035141b Merge branch 'master' into cleanup/storages_optimization 2016-10-14 06:12:52 +07:00
Cydh Ramdh
b2c4178209 Corrected 'VIP' personal info notification (#1613)
* Only displayed when map-server is changed or when changing map that has different base rate with previous map's rate, should not when map changed/warped.
* Updated some packet that related with VIP and its doc.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-10-14 06:04:09 +07:00
Lemongrass3110
768d801f3d Merged storage loading into a single function
Follow up to 800714a forgot to eliminate TABLE_CART_ completely.
2016-10-14 00:41:15 +02:00
aleos89
a8c8cbd498 Small cleanups
* Corrected the spacing to tabs in a few locations.
* Corrected a variable typo.
2016-10-13 18:06:58 -04:00