9795 Commits

Author SHA1 Message Date
Aleos
54a119c56a Resolves Skill Unit Database parsing issue (#2484)
* Fixes #2483.
* Properly trims the target field so it can be processed accurately.
2017-10-07 17:29:50 +02:00
Jeybla
b8562932cf Removes SCRIPT_CALLFUNC_CHECK ifdef-directives. (#2482)
* Closes #2205
* The SCRIPT_CALLFUNC_CHECK define was to enforce function
  calling with callfunc in scripts. Because I don't think calling
  functions without callfunc will give us performancy issues,
  this check is simply removed by this commit.
2017-10-07 16:59:45 +02:00
Jeybla
2676d05394 Jobmaster update (#2369)
* Major changes due to readability and some corrections
* Adds the option to disable Rebirth Classes
* Adds the possibility to give players job related 
  Equipment (mostly weapons) on job change
* Adds more level requirement settings
* Adds BabyExpanded and BabySummoner Jobs
* Thanks to @Braniff, @mazvi, @Mikegyver, @Lemongrass3110, @Akkarinage, @Stolao and @secretdataz!
2017-10-06 17:40:39 +02:00
rpdigos
fb882c4aa0 Fix a couple of warnings. (#2462)
* Fix a couple of warnings.
Thanks to @rpdigos!
2017-10-06 10:58:17 -04:00
Jey
ae0da362f8 Follow up to fe75aea
* Fixes a compile warning
* Thanks to @Haikenz
2017-10-06 02:23:56 +02:00
Aleos
fe75aeab50 Corrected character slot movement (#2452)
* Corrected character slot movement
* Resolves characters changing slots (on the char-selection screen) to the first empty slot rather than to the actual slot index.
Thanks to @Tokeiburu, @Lemongrass3110, and @Jeybla!
2017-10-05 18:31:30 -04:00
Jittapan Pluemsumran
872cb42a48 Fixed a bug where refine bonuses was being incorrectly parsed. Fixes #2456
Thanks to @hc3490
2017-10-05 22:43:38 +07:00
Aleos
53ba373c43 Corrected Overed Boost behavior (#2474)
* Fixes #2473.
* Skill was draining double homunculus hunger and double master SP.
Thanks to @Everade!
2017-10-04 21:14:55 -04:00
Jey
6b6717748e Fixes homunculus being able to attack from Manhole
* Fixes #2068
2017-10-03 08:07:57 +02:00
Jey
215aa158ed Follow up to aa6e8987db08ecd7dfb06ab55f4e44009e174175.
* Fixes compile warnings.
2017-10-02 22:16:12 +02:00
Jey
a5719e7228 Prefer static_casts instead of C casts. 2017-10-01 18:32:52 +02:00
Jey
593ac62757 Convert mob.c to mob.cpp. 2017-10-01 18:25:16 +02:00
Lemongrass3110
6899c89e5d Added new mob db placeholders
With this gravity used up the old monster id range and their client will probably support the new range on kRO sakray soon!
2017-09-30 18:18:35 +02:00
Aleos
ab014246cc Corrected Elemental Cure healing behavior (#2443)
* Fixes #2440.
* The HP/SP heal should be based on the caster's current HP/SP, not the Elemental's max HP/SP.
Thanks to @Barigas!
2017-09-29 09:41:34 -04:00
Lemongrass3110
7de7472782 Added support for some missing clients (#2458) 2017-09-28 23:52:56 +02:00
Jey
e6ec0f528f Follow up to 0e4ffdacdbe4b39e356ea5e632321fee707a0bfa. 2017-09-28 23:29:29 +02:00
Jeybla
0e4ffdacdb Adds pk_mode_mes displayed on joining a pk zone. (#2400)
* When pk_mode and pk_mode_mes is enabled, the player gets notified joining a pk-zone map.
* It's now possible to specify the target in showscript.
  Default is still AREA.
* pk_mode_mes is now using showscript to SELF.
* Thanks to @Atemo, @RadianFord, @Lemongrass3110, @aleos89
2017-09-28 22:53:16 +02:00
Aleos
ee552d67d4 Updated Kaite renewal behavior (#2457)
* Fixes #2409.
* Kaite no longer reflects AoE magic.
Thanks to @esu1214!
2017-09-28 09:45:51 -04:00
aleos
d9a2bdbe05 Changed atcommand follow behavior
* Fixes #2424.
* Atcommand follow will now continue to follow the target even if the target dies.
Thanks to @MrAntares!
2017-09-26 17:02:39 -04:00
aleos
82ed67a01c Corrected script command instance ID lookups
* Fixes #2448.
* Resolves script_instancegetid causing scripts to end prematurely during player lookups.
Thanks to @Yuchinin and @Atemo!
2017-09-26 16:46:13 -04:00
Vincent Stumpf
cd43f32ffb Shadow Refiner and getequiprefinecost (#2447)
* Fixes #2445 and fixes #2446.
* Fixed shadow refiner.
— The script uses the values of the array instead of the indexes to loop through it.
* Fixed segfault in getequiprefinecost.
— No checks in getequiprefinecost meant there were possibilities using negative indexes in arrays.
* Added to the script documentation what happens on failure when calling getequiprefinecost (it returns -1).
Thanks to @vstmpf, @crazystorm2017, and @hendra814!
2017-09-24 09:53:40 -04:00
Aleos
80a251ef02 Migrated clif.c to C++ (#2435)
* Migrated clif.c to C++
* Needed in preparation for future projects.
Thanks to @Daegaladh and @Mikegyver for testing!
2017-09-21 11:41:57 -04:00
aleos89
1bfe8475c8 Corrected Elemental flee calculation
* Fixes #2436.
* Added missing caster's flee into the formula.
Thanks to @Barigas!
2017-09-21 11:03:10 -04:00
Vincent Stumpf
0e74b5f55b Fixed potential crash in pc_bonus (#2423)
* Fixes #2420.
* If a bonus script command is used in an NPC with a non-existent bonus type, the server crashes.
Thanks to @vstumpf and @anacondaqq!
2017-09-20 14:33:25 -04:00
Vincent Stumpf
70f1d86404 Fixed msvc warning casting int to bool in getequiprefinecost (#2429)
* Fixes #2428.
Thanks to @vstumpf and @Haikenz!
2017-09-19 10:15:42 -04:00
Phong Truong
303bfb54aa Update atcommand.c 2017-09-19 12:35:32 +07:00
Jittapan Pluemsumran
e24d30a711 Refine overhaul (#2295)
* Converted refine_db.txt to refine_db.yml
* Refine success rates can now be set in refine_db.yml. rAthena's default NPCs will respect this database by default.
* Added shadow equipment refiner
Thanks to @Akkarinage @aleos89 @Atemo and @Mikegyver for their inputs.
2017-09-18 21:52:52 +07:00
Aleos
5c7c089320 Corrected OPT1 behavior (#2378)
* Fixes #869.
* Damage skills should fully cast when OPT1 statuses are active.
Thanks to @panko11 and @Playtester!
2017-09-15 13:08:32 -04:00
Jeybla
557cccac9c Adds allow_bound_sell configuration. (#2401)
- It is possible to sell bound items, when allow_bound_sell is enabled.
- Fixes #2398.
- Changes made by @aleos89
- Thanks to @Everade
2017-09-12 15:53:55 -04:00
Jey
5fda4f0f65 Fixed potential map server crash.
* Added a null pointer check
* Thanks to @admkakaroto!
2017-09-11 03:04:28 +02:00
Jey
b4952aae09 Fixes a potential map-server crash.
* Follow up to 816d8ab2
* "buf" length in clif_party_info adjusted. (Buffer overflow)
* Thanks to @plsfixrito!
2017-09-07 23:21:52 +02:00
Jey
6434a83088 Follow up to 38d225c444c88a3bfc702bbe7c2de60529c1e88f
- Fixes a compile warning
- Thanks to @Mikegyver and @Daegaladh
2017-09-07 15:34:33 +02:00
Jey
38d225c444 Follow up to 60d59124a357510a15d0039f42fce187a3104caa.
* Fixes a map server crash due to wrong casting
* Fixes #2406
* Thanks to @keitenai!
2017-09-07 13:18:28 +02:00
Jey
528539f621 Follow up to 60d59124a357510a15d0039f42fce187a3104caa
* Fixes some compile warnings
* "Forcing value to bool"
* Thanks @M4karov
2017-09-07 12:51:00 +02:00
Daegaladh
60d59124a3 Migrated script.c to C++ (#2404)
* Thanks to @Daegaladh!
* Originial pull request: #2395
2017-09-07 04:13:42 +02:00
Jittapan Pluemsumran
0379774cd2 Revert "Migrated script.c to C++ (#2395)" (#2403)
This reverts commit 965edbf47d5044e29c011c621f5129008c85b7aa.
2017-09-05 22:40:24 +07:00
Daegaladh
965edbf47d Migrated script.c to C++ (#2395)
* Migrated script.c to C++
2017-09-05 19:51:04 +07:00
Aleos
6ef8a97cf0 Updated Guillotine Poison item behavior (#2396)
* Fixes #1044.
* Poisons are now consumable by all classes.
* Using the item directly gives no benefit.
* Adjusted the item type to 2 (usable) from 0 (healing).
* A Dagger or Katar weapon is required to use Poisoning Weapon.
* Casting Poisoning Weapon again will cancel the previous bonus.
Thanks to @cydh and @Playtester!
2017-09-02 10:49:18 -04:00
Aleos
e92fc9672f Resolved bonus WeaponMATKRate (#2383)
* Fixes #2275.
* Moved the bonus check after equipment is parsed.
Thanks to @Felleonel!
2017-08-31 14:26:17 -04:00
Aleos
d353b6682b Updated Rune Stone item behavior (#2384)
* Fixes #1045.
* Rune Stones are now consumable by all classes.
* Adjusted the item type to 2 (usable item) from 11 (delayed item).
* Removed the IG_RUNE item group.
Thanks to @cydh and @Paoly28!
2017-08-31 14:05:06 -04:00
Aleos
dfe714e9a1 Corrected broadcast item flag with autoloot (#2392)
* Fixes #1796.
* Moved the broadcast flag check before party share loot check.
Thanks to @whupdo!
2017-08-31 13:51:07 -04:00
Jeybla
f197f82f1f Removed reset of monster drops on mobdb reload. (#2394)
Does not clear item_drop_ers on mobdbreload anymore.
- Fixes #2355
- Thanks to @Zellukas.
2017-08-31 19:02:22 +02:00
Aleos
fc115b85a1 Adjusted HP, Max HP, SP, and Max SP SQL defines (#2389)
* Fixes #2387.
* Adjusted column define from mediumint to unsigned int.
* Synchronized default values to 0.
* Adjusted the parser format specifier
* Adjusted the specifiers to support unsigned.
Thanks to @M45T3Ryu and @Lemongrass3110!
2017-08-31 10:49:48 -04:00
Aleos
b19325b842 Corrected mob chat display checks (#2390)
* Fixes #2388.
* Added a validation check when monsters try to talk and attempt to lookup and invalid chat message on skill usage.
* Clones of players will now have no mob chat ID associated to their skills.
Thanks to @M4karov!
2017-08-31 10:15:00 -04:00
aleos
3e51f68570 Adjusted the Achievement Chat Counter
* Fixes #2334.
* Moved the achievement objective update function before the NPC waiting room event trigger.
Thanks to @ClayJensen and @Atemo!
2017-08-29 19:09:41 -04:00
Aleos
e4072e1361 Updated Silvervine Root Twist behavior (#2377)
* Fixes #1139.
* Should be removable by Earth Shaker.
* Removed maxcount limit as it's not a ground skill anymore.
2017-08-29 09:39:52 -04:00
Aleos
515fa6a163 Corrected the Chorus skills damage bonus (#2379)
* Added the missing range value when searching the map.
* Resolves an incorrect calculation in the bonus when less than 8 of the members are a Minstrel or Wanderer.
* Moved the Chorus check to the respective skills to avoid unnecessary calls to the function.
* Added documentation.
* Removed redundancy.
Thanks to @Tokeiburu and @Lemongrass3110!
2017-08-28 19:43:57 -04:00
Aleos
7a1b2e0f0a Cleaned up Item Shop checks (#2373)
* Fixes #2352.
* Removed an extra bound check when selling items.
* Added a check to return failure when unable to delete an item.
* Added checks when counting sellable items in an Item Shop.
- Items that can't be sold, favorite items, rental items, and bound items will now be ignored unless the GM has required permissions.
Thanks to @chadn4u, @Jeybla, @Lemongrass3110!
2017-08-28 10:08:29 -04:00
Aleos
39a5d38b9d Corrected Fatal Menace behavior (#2371)
* Resolves an issue with targets in the Fatal Menace area not getting teleported with the player.
Thanks to @Tokeiburu!
2017-08-28 09:40:23 -04:00
Stolao
9db3c386ea Fix bAddEffOnSkill (#2370)
* Fixes #2357.
* Fixed a copy paste error.
2017-08-25 14:41:15 -04:00