9795 Commits

Author SHA1 Message Date
Cydh Ramdh
633a642e5a * Corrected combos of Elemental Clothes (19048)
* Updated Status Change documentation for `SC_SIEGFRIED` and `SC_SCRESIST`
* Fixed `bResEff` cannot be used to increase the rate (for reducing resistance)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-20 11:35:02 +07:00
aleos89
0dd3c74c2e Fixed some arrays not zeroing out on status recalculation (fixes #1722)
* Follow up to 0f1b1af, f296409, and a79d065.
* Fixes several bonuses that are not zeroed out properly since the block order didn't match.
Thanks to @whupdo!
2016-11-19 09:26:33 -05:00
aleos89
ef63cffa30 Small OPTION_INVISIBLE refactor
* Cleaned up the usage of OPTION_INVISIBLE to utilize the macro that was defined for it.
2016-11-18 14:44:49 -05:00
Playtester
db3ef52fd2 Frost Nova AoE (fixes #1619)
- Increased Frost Nova AoE from 5x5 to 7x7
- Frost Nova no longer hits enemies that are on the same cell as the caster
2016-11-17 18:25:56 +01:00
Lemongrass3110
0fa8919749 Added sura jobs to the switch 2016-11-17 17:35:35 +07:00
aleos89
9910478ce2 Resolved some compile warnings
* Resolved two unreachable code warnings.
* Resolved two potentially uninitialized local variable warnings.
2016-11-16 13:07:19 -05:00
Lemongrass3110
ecc8cf9f0b Initial release of the clan system
Thanks to @cydh, @RagnarokNova and @aleos89 for their help.
2016-11-16 15:36:08 +01:00
aleos89
dfccb88785 Removed double saving attempts
* Follow up to 3dfdb38.
* Removed an extra save attempt if a player changes jobs and has fame.
2016-11-16 08:50:36 -05:00
aleos89
3dfdb38d32 Fixed atcommand changecharsex sync issue (fixes #1684)
* Resolves the map-server holding a different job value than what the char-server could be holding.
Thanks to @Grantea!
2016-11-16 08:41:16 -05:00
Lemongrass3110
9bf5d4a291 Fixed a shadowed variable
Fixes #1718
2016-11-16 08:18:18 +01:00
aleos89
cb279a7243 Resolved an uninitialized variable (fixes #1717)
* Follow up to ade1b17.
* Corrects the countitem script command having an uninitialized variable warning during compile.
Thanks to @hnomkeng!
2016-11-15 21:54:44 -05:00
aleos89
5332d7f0e7 Resolved a map crash with pet items (fixes #1716)
* Follow up to ade1b17.
* Added a pet data check that was removed.
Thanks to @Keniski!
2016-11-15 21:52:05 -05:00
aleos89
d1cc320769 Corrected Storage dirty flag check
* Follow up to ade1b17.
2016-11-15 16:17:11 -05:00
aleos89
00fd5e7078 Removed rAthena Stat Reporter
* Follow up to 0ffeec0.
* No longer being used so it will now be completely removed.
2016-11-15 10:19:58 -05:00
Lemongrass3110
28cee2caa9 Cleaned storage saving output 2016-11-14 20:05:19 +01:00
Aleos
ade1b171eb Optimized Inventory, Cart Inventory, and Storage usage (#1115)
* These storage types now mimic Guild Storage and can be loaded/saved whenever needed.
* Relieves mmo_charstatus from having to send storage types and lets the char-server handle it.
* All storage types now have an increased max amount.
* Implemented Premium Storage System. Thanks to @cydh!
* Fixes #441 - Players will no longer be required to log out to resync cart item data before opening a Vending Store.
* Refactored player weight and cart weight calculations into their own functions.
* Added script commands openstorage2, guildstoragecountitem[2] and guildstoragedelitem[2].
* Refactored several function return types as well as documentation.
Thanks to @lighta and @cydh for their help with it!
2016-11-14 13:11:43 -05:00
aleos89
8028789dee Removed unused functions
* Removed inter_storage_delete and inter_guild_storage_delete functions as they are not used.
2016-11-14 09:38:59 -05:00
Lemongrass3110
b5de7df013 Implemented correct windows socket cleanup
Resolves HerculesWS/Hercules#1513
Thanks to @mkbu95 for bringing this up
2016-11-14 10:44:43 +01:00
Lemongrass3110
4ed035b036 Cleaned up fame lists (#1660)
Added 0x97e into the packet length table
2016-11-14 09:04:42 +01:00
aleos89
eae1161d53 Corrected Sling Item behavior
* Partial revert of 89a33a7.
* Moved bonuses back to the item_db so items can easily be customized.
* Sling Item is no longer usable on self.
2016-11-13 15:07:14 -05:00
aleos89
c00c7346d2 Resolved some compile errors
* Follow up to 9c552ca and 5aa53e4.
2016-11-11 15:35:38 -05:00
aleos89
5aa53e4738 Merge branch 'master' into cleanup/storages_optimization 2016-11-11 14:54:43 -05:00
aleos89
56512ce116 Corrected vending order of similar item IDs
* Resolves an issue where if a similar item ID is vended more than once (non-stackable) the order of the vended items becomes incorrect when one is purchased.
Thanks to @Tokeiburu!
2016-11-11 14:26:32 -05:00
Lemongrass3110
a03105b49d Fixed a potential map-server crash
Fixes #1398
2016-11-10 00:18:16 +01:00
Lemongrass3110
4687247769 Fixed a possible null pointer
Follow up to e93c888
See https://rathena.org/board/topic/108045-map-server-crash-after-using-skill-manhole/
2016-11-10 00:12:26 +01:00
aleos89
74a703d649 Corrected Anodyne usage on no teleport maps (fixes #1704)
* Added a missing break.
2016-11-09 09:36:10 -05:00
aleos89
550cfcad54 Merge branch 'master' of https://github.com/rathena/rathena 2016-11-08 11:10:33 -05:00
aleos89
623d845717 Fixed IgnoreDefClassRate check (fixes #1702)
* The item bonus will now properly check for a valid Class rather than a valid Race.
* Added IgnoreDefRaceRate and IgnoreDefClassRate to the item_bonus documentation.
Thanks to @Tokeiburu!
2016-11-08 11:07:08 -05:00
aleos89
9a009bf316 Corrected Spiritual Sphere Absorption and Cursed Circle interaction (fixes #1514)
* Spiritual Sphere Absorption will fail to go through if the caster is captured in Cursed Circle.
2016-11-07 16:46:21 -05:00
CairoLee
e21b39230a Clear unused battle configure "disp_serverbank_msg" 2016-11-07 22:00:37 +01:00
aleos89
c8d37c4448 Removed Frigg's Song from Group A Songs (fixes #1583)
* Song can now overlap with Group A and B Songs.
* Song was removed from group in Hero's Trail III patch.
2016-11-07 15:08:49 -05:00
aleos89
45d9674d2b Resolved rental timer display (fixes #1542)
* Resolves the timer display overflowing when an item is rented for a long duration.
Thanks to @mrjnumber1!
2016-11-07 14:39:43 -05:00
aleos89
cbc365d0f2 Corrected autospell bonuses (fixes #1593)
* Resolves the range check when the config is enabled not checking the proper distance between the two targets.
* Updated the item bonus documentation.
Thanks to @chriser-!
2016-11-06 14:15:12 -05:00
Playtester
78d9e2a245 Slave aggro (fixes #1676)
- Slaves will now become aggressive when their master starts chasing a target to attack it
2016-11-06 11:17:14 +01:00
Aleos
0b68035248 Cleaned up instance parsing checks (#1610)
* Cleaned up instance parsing checks (fixes #1606)
* Changed atoi to strtol.
* Added data validation checks.
* References to #1609.
2016-11-05 09:56:28 -04:00
Cydh Ramdh
20e228a7f5 Fixed npc_cashshop_buy for 2010-11-16 client or older
* Failed to buy item from `itemshop` and `pointshop` NPC
* Thanks to Anime s2 that notices this

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-05 09:59:42 +07:00
aleos89
805f11d9f0 Added unit flag UF_CRAZYWEED_IMMUNE
* Follow up to 6e97762.
* Used to make unit skills immune to Crazy Vine's removal effect.
2016-11-03 21:54:04 -04:00
aleos89
6e9776203a Corrected Crazy Vines behavior (fixes #1522 and fixes #1689)
* Crazy Vines will now properly remove all ground type skills.
* Removed UF_REM_CRAZYWEED enum.
2016-11-03 21:17:34 -04:00
Cydh Ramdh
aa0b7cd7ba Removed duplicate check for storage size
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-04 07:27:26 +07:00
aleos89
cc733a9516 Corrected Voice of Siren's behavior (fixes #1680)
* Resolves traps not being avoided when the Maestro/Wanderer has enticed the trapper.
2016-11-03 18:10:34 -04:00
aleos89
06aec011c8 Fixed a potential map crash
* Follow up to dc8d466.
2016-11-03 10:17:19 -04:00
Lemongrass3110
418d8203e6 Refactored clif functions for unit names (#1664)
Refactored clif functions for unit names

Renamed clif_charnameack to clif_name and added additional parameters to follow other clif functions.

Removed clif_charnameupdate completely since it was just a copy of the BL_PC code in clif_charnameack and replaced all calls with clif_name_area.

Fixed guild position display
Fixes #1662
Thanks to @ghul3 for reporting it.

Removed useless params for some guild functions
2016-11-02 11:13:52 +01:00
Lemongrass3110
485ae6f8cf Fixed a bug in party creation
Fixes #1674
Thanks to @admkakaroto and @Grantea
2016-11-02 10:37:27 +01:00
Cydh Ramdh
4753407d63 Fixed memleak when player's string variable is cleared
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-01 20:33:08 +07:00
Cydh Ramdh
46b1de7d50 Initial release 'premium' storage
* Adapting official multiple storages.
* Added config to defines storages. See conf/import-tmpl/inter_server.conf.
* Added packet IZ `0x388c` for sending storage definitions.
* Added script command `openstorage2` to open premium storages.
* Removed `sd->storage_size`, replaced by `sd->storage.max_amount`. The value is defined in inter_server.conf in storage entries.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-11-01 09:08:55 +07:00
aleos89
dc8d466b03 Minor define cleanups
* Removed some variable defines that were redefines.
2016-10-31 21:58:28 -04:00
aleos89
c1d9520019 Added an extra ammo requirement for specific skills (fixes #1683)
* Severe Rainstorm, Round Trip, and Fire Rain now require +1 to their ammo requirement in order to successfully cast the skill.
* These skills will still consume their normal ammo amount.
Thanks to Fyrus for data mining!
2016-10-31 17:08:44 -04:00
Playtester
9a130fa0e8 SG counter and other status variables (bugreport:7449)
- Fixed extra status variables not being cleared correctly when the killed unit did not have any status change
(e.g. SG counter will now be set back to 0 when a monster dies)

Reference: https://rathena.org/board/tracker/issue-7449-storm-gust-counter-does-not-get-reset-on-mob-dead/
2016-10-30 13:27:30 +01:00
Playtester
5d24d73abf Lex Divina on allies (fixes #1668)
- Lex Divina can now be cast on a silenced ally
- When casting Lex Divina on an ally that is not silenced, it will no longer display the skill animation
2016-10-29 19:43:53 +02:00
aleos89
561a874833 Fixed Falcon Assault element (fixes #1659)
* Partial revert of 1d8bec3.
* Element should always be neutral.
* Renewal mode ignores the target's defense cards.
2016-10-29 12:44:11 -04:00