10015 Commits

Author SHA1 Message Date
Aleos
496f362ec9
Fixes skill database reloading (#4669)
* Fixes #4660.
* Resolves an issue with skill database reloading not clearing the previous data first.
* While clearing the YAML cache it will also resize the cache to the previous capacity.
Thanks to @teededung!
2020-03-04 13:03:06 -05:00
Aleos
5c35ec7d69
Corrects skill_damage_db parsing (#4667)
* Fixes #4574.
* Removes the usage of atoi as any failure returns 0.
* Adds checks for cases of invalid data.
* General cleanups and fixes.
* Fixes the import database documentation.
Thanks to @Skormie!
2020-03-04 12:33:37 -05:00
rAthenaAPI
35b2f69530 Effect State Update 2020-03-04 05:05:27 +01:00
Amir Azman
b143241222
Fix Typo in Cleans up Summoner dual-cast attacks commit (Map Crash Issue) (#4677)
* Fixes #4676.
*  Fixes a typo in Professor’s Dual Casting check.
Thanks to @reunite-ro!
2020-03-01 15:45:23 -05:00
Joam
18ab64f2a1
Fix missing check element for non-damage skill (#4664)
* Fixes #4661.
* Resolves an issue with an element resistance check.
Thanks to @reunite-ro and @attackjom!
2020-02-26 08:04:26 -05:00
Aleos
836eda4879
Cleans up Summoner dual-cast attacks (#4658)
* Cleans up Summoner dual-cast attacks Bite, Silvervine Stem Spear, Scar of Tarou, and Picky Peck so that they behave like Professor's Double Casting.
* Adjusts success formula.
Thanks to @Rytech2!
2020-02-25 19:58:12 -05:00
Aleos
97372ff423
Adds reload attendance database atcommand (#4657)
* Fixes #4656.
* Adds an atcommand option for reloading the attendance database.
* Adds missing headers for attendance database.
* Adds missing reload options in the atcommand configuration.
Thanks to @lelouch22's suggestion!
2020-02-23 17:10:17 -05:00
Aleos
1fc4b8de20
Battleground Queue fixes (#4648)
* Fixes #4644.
* Initialize all battleground queues at startup to reduce overhead of creation/deletion during live server.
* Removes lots of duplicate code between team checks.
* Adds missing checks for script commands bg_leave and bg_desert to only warp players out using the Battleground Queue System.
* Adds documentation for script commands bg_leave and bg_desert to state players will be warped out after when using the Battleground Queue System.
* Optimizes join logic to add new players to the end of the queue rather than the front.
* Cleans up the client messages so certain responses are cleared when they need to be.
Thanks to @Balferian and @Lemongrass3110!
2020-02-20 22:25:14 -05:00
Aleos
04a83ec774
Resolves compile warnings (#4652)
* Fixes #4649.
* Resolves some compile warnings for the mapcache and csv2yaml tools.
Thanks to @reigneil!
2020-02-18 08:40:55 -05:00
Aleos
b13bc7402c
Resolves an issue with mob avail options (#4651)
* Fixes #4647.
* Resolves an issue with mob avail options not properly checking the state of the option label.
Thanks to @Litro!
2020-02-17 20:30:05 -05:00
Lemongrass3110
d165c19b73 Fixed jump_zero for conditions over INT32_MAX
Thanks to @Atemo
2020-02-17 22:50:19 +01:00
rAthenaAPI
390eb9772a Effect State Update 2020-02-16 11:05:27 +01:00
rAthenaAPI
1e091cd58a Effect State Update 2020-02-14 02:20:45 +01:00
Lemongrass3110
b681339529 Revert "Effect State Update"
This reverts commit cee7242623c2e5572bfe5b74a57543939587df49.

Fixes #4635
2020-02-13 00:35:43 +01:00
rAthenaAPI
cee7242623 Effect State Update 2020-02-12 15:05:53 +01:00
Aleos
2931c00bd4
Implemented the Battleground Queue System (#3995)
* Fixes #1310.
* Added a battle config which allows toggling of the Battleground Queue client feature and also toggles between the modes of scripts.
* Added script commands bg_reserve, bg_unbook, and bg_desert.
* Removed old custom Battleground scripts.
Thanks to @Lemongrass3110, @Locien, @secretdataz, @InusualZ, @Normynator, @Atemo, @iubantot, @admkakaroto, and @noobzter003!
2020-02-12 08:26:59 -05:00
rAthenaAPI
c292794154 Effect State Update 2020-02-12 14:05:44 +01:00
rAthenaAPI
653631dfe1 Effect State Update 2020-02-12 14:05:30 +01:00
Lemongrass3110
d12b4fdca0
Added support for RSW 2.2 (#4627)
Merged mapserver and mapcache RSW reading code
2020-02-11 23:49:47 +01:00
aleos
9b6976ea7b Removes some warnings from script command mail
* Follow up to e5c22b3.
* Remove the warnings for refine and bound options as these aren't mandatory fields.
Thanks to @Lemongrass3110!
2020-02-11 17:25:38 -05:00
vakhet
1ec101b9a4
Changed dummy item id (#4625)
Fixes #4616
2020-02-11 22:37:22 +01:00
Aleos
35102c3059
Quest data should be cleared on char deletion (#4633)
* Fixes #4628.
* Player quest data should be deleted when the character is deleted.
Thanks to @Tokeiburu!
2020-02-11 14:33:20 -05:00
Jason L
e5c22b360f
Added refine and bound options for mail command (#4272)
* Added refine and bound option for mail script command.
* Made some slight corrections to the script_commands document.
* Note: Any custom scripts that use this command and give some sort of card or random option bonus need to be adjusted as refine and bound come before these options now.
Thanks to @Skormie!
Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
2020-02-11 10:18:59 -05:00
Aleos
986f8b0595 Fixes Land Protector not removing some units
* Fixes Land Protector not removing units with the RangedSingleUnit flag.
Thanks to @teededung!
2020-02-11 08:30:57 -05:00
Lemongrass3110
39f7d28872
Fixed some compiler warnings on prere (#4626)
Fixes #4621

Thanks to @Litro
2020-02-10 23:37:26 +01:00
Aleos
a74978b258 Fixes SpiritSphereCost negative values
* SphiritSphereCost has potential -1 value to remove all available spirit spheres.
Thanks to @teededung!
2020-02-10 10:57:16 -05:00
aleos
e4046f9d18 Fixes Duration1 and Duration2 negative values
* Duration1 and Duration2 have potential -1 value to send infinite tick for statuses.
Thanks to @teededung!
2020-02-09 11:54:19 -05:00
Aleos
47131b4585 Fixes import directory skill conversions
* Fixes an issue where skill databases read from the import directory were not being read properly.
Thanks to @Daegaladh!
2020-02-08 16:04:01 -05:00
vakhet
cdce4cd794
Correcting import due to compiler warning (#4613) 2020-02-08 16:35:38 +01:00
Lemongrass3110
ee96438607 Fixed a map-server crash
Fixes #4614

Thanks to @reunite-ro
2020-02-08 16:35:02 +01:00
Daegaladh
77dd729d77
Fixed SA_FREECAST aspd calculation (#4570)
* Thanks to @Lemongrass3110
2020-02-07 22:05:33 +01:00
Aleos
e6a6c0533c
Updated 3rd class from RO 16th Anniversary Patch (#3659)
* Fixes #3602 and fixes #3653.
* Updated the 3rd class skills according to the RO 16th Anniversary Patch.
* Complete changelog here: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3890090&curpage=1
Thanks to @Badarosk0, @OptimusM, @Victor214, @Rytech2 and @laziem!
2020-02-07 10:39:35 -05:00
Lemongrass3110
b0ac1717f2
Added an option to block discount in shop (#4606)
This is required for the correct implementation of #4387
2020-02-07 00:29:33 +01:00
Lemongrass3110
83da86c301 Fixed ITEM_ENCHANTARMS and LG_SHIELDSPELL
Fixes #4604
Also fixes csv2yaml for highly customized skill databases.

Thanks to @mazvi
2020-02-05 23:40:59 +01:00
Lemongrass3110
57e50a1906 Fixed remove trap skills
Fixes #4605

Thanks to @Angelic234 and @mazvi
2020-02-05 23:29:01 +01:00
Sader Fawall
5386a5bcf4
Fixed some skill crit bonuses (#4454)
* Fixes #4128, fixes #4453, and fixes #4460.
* Resolves critical item bonus not applying to skills.
Thanks to @sader1992!
Co-Authored-By: Cydh Ramdh <cydh@pservero.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-02-05 14:38:56 -05:00
Daegaladh
4a1e904149
Fixed Hocus and Improvised Song ignoring mapflags (#4488)
* Fixed skills casted by SA_ABRACADABRA and WM_RANDOMIZESPELL ignoring critical mapflags
2020-02-05 15:15:14 +01:00
userid0
f76bc09fbe
Fixed a compiler warning in pc.cpp (#4601)
fix warning C4804: '>': unsafe use of type 'bool' in operation
2020-02-04 22:04:43 +01:00
Atemo
ac0d17f4aa
Corrected getfreecell command for flag 2 (#4491)
* Little simplification of the code
* Extends the target type for flag 2 to match the docs (target applicable for player, monster, pet, homunculus)
Thanks to @Lemongrass3110
2020-02-04 19:58:04 +01:00
Atemo
78eb1bcd7b
Additional check in map_mapid2mapname (#4373)
* The mapid2name script command didn't check if the map existed (potential crash)
2020-02-04 15:01:00 +01:00
rAthenaAPI
6c8840ca54 Effect State Update 2020-02-04 05:05:35 +01:00
Lemongrass3110
0b3430c777
Fixed some database redundencies (#4565)
Cleaned redundancies in guild members and friends table

Fixes #4564

Thanks to @Everade
2020-02-03 20:27:11 +01:00
Lemongrass3110
b86926a7a2
Fixed a compiler warning in script.cpp (#4586)
Fixes #4582

Thanks to @idk-whoami and @aleos89
2020-02-03 14:44:58 +01:00
Lemongrass3110
a323474433 Fixed a few hard coded element checks 2020-02-02 20:01:55 +01:00
aleos
abc027b47f Skill YAML fixes
* Fixes an issue with knockback converting the wrong column.
* Fixes an issue with skills containing multiple elements converting the wrong column.
Thanks to @mazvi and @Lemongrass3110!
2020-02-02 13:42:53 -05:00
Lemongrass3110
0105116338 Fixed variable cast times
Thanks to @mazvi again.
2020-02-02 17:58:44 +01:00
Lemongrass3110
5cf7aceb2a Fixed some bugs with the new skill db
Fixes #4590

Thanks to @mazvi
2020-02-02 16:04:11 +01:00
Lemongrass3110
990c81f024 Fixed a few bugs in the mob avail converter
Thanks to @Everade
2020-02-02 15:06:45 +01:00
aleos
7bdfe81867 Skill Ammo requirement fixes
* Fixes #4589.
* Resolves an issue with the skill converter outputting the incorrect ammo type requirement.
* Also fixes an issue with physically attacking targets while having a status option active.
Thanks to @mazvi!
2020-02-01 16:06:13 -05:00
Aleos
1b8c2e517d
Cleaned up CSV2YAML skill database label (#4585)
* Strips the "_Skill" from TargetType.
* Cleaned up documentation header to match.
2020-02-01 09:53:27 -05:00