9920 Commits

Author SHA1 Message Date
Lemongrass3110
481fb022bd
Fixed a crash with cashshop errors (#5670)
Fixes #5666

Thanks to @hostragna
2021-01-04 15:00:33 +01:00
CairoLee
01188b1501
Fixed memory leak when using loadnpc or reloadnpcfile command (#5667)
Fixes #5649
2021-01-03 21:41:57 +01:00
Aleos
b74fa9d64f
Fixes renewal weapon attack display (#5633)
Fixes #554, fixes #578, and fixes #909.
The right hand attack display should only show bonuses given by weapons and not the STR/DEX bonus.
Thanks to @reigneil, @Paoly28, @panko11, and @limitro!

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-12-21 00:52:04 +01:00
Lemongrass3110
077ca15bbd
Converted a few more packets to structs (#5641)
Fixes #5620

Thanks to @nevelis
2020-12-21 00:44:51 +01:00
Lemongrass3110
f8e703ef68
Fixed an issue with status point reset (#5640)
Only applies if you do not use the status point table.
Additionally replaced the hardcoded value with the one from the configuration.
While at it added a missing else.

Fixes #5634

Thanks to @zeffen
2020-12-18 22:20:21 +01:00
Aleos
626b93e6c6
Fixes compile errors on GCC 10.2 (#5631)
* Fixes #5629.
* Removes va_list from nullpo checks.
Thanks to @behelit2!
2020-12-17 11:43:18 -05:00
Aleos
844945d1cf
Removes a useless nullification loop (#5561)
* Fixes #5606.
* The vector is a new instantiation so it will be free and clear from the start.
Thanks to @inhyositsu!
2020-12-09 14:13:14 -05:00
Aleos
d4d8130bcf
Adds item bonus bReduceDamageReturn (#5601)
* Fixes #5488.
* Adds item bonus bReduceDamageReturn which reduces melee, ranged, and magic reflected damage.
Thanks to @Atemo!
2020-12-07 08:50:26 -05:00
Lemongrass3110
dade413935 Fixed the renewal mapcache
Fixes #5396

Reverts 9eeeb09

Thanks to @nubspixel and @aleos89
2020-12-07 02:16:44 +01:00
Aleos
9eeeb09ff6
Fixes a potential crash when adding new maps (#5422)
* Fixes a potential crash when adding new maps
* Fixes #5396.
* Fixes a potential crash on start up when adding a map to maps_athena.conf and the map has not yet been added to map_cache.dat.
Thanks to @nubspixel!

* Inverts check
2020-11-30 04:01:17 +01:00
javirst
f74915193d
Unlock target when setunitdata TARGETID 0 (#5578)
Fixes #5577
2020-11-29 21:37:28 +01:00
Joam
4bbd755f2a
Fix Friendlist disappear in 2020-09-02ragexeRE or above (#5583)
Fixes #5582

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-29 21:09:04 +01:00
Aleos
2d97ece2a2
Implements new guild skills (#5192)
* Fixes #4183.
* Adds 3 new guild skills: GD_CHARGESHOUT_FLAG, GD_CHARGESHOUT_BEATING, and GD_EMERGENCY_MOVE
* Changes 5 minute guild global cooldown to be 3 minute individual cooldowns for GD_RESTORE, GD_REGENERATION, GD_BATTLEORDER, GD_EMERGENCYCALL, and GD_ITEMEMERGENCYCALL.
* Reduces GD_RESTORE fixed cast time from 10 seconds to 1.
2020-11-28 17:16:22 -05:00
Aleos
103416ca40
Fixes Advent of Star Emperor behavior (#5424)
* Fixes #5409.
* Adjusts the behavior of Advent of Star Emperor spheres to work like Millennium Shield.
* Fixes the spheres not visually being removed when the the status ends.
Thanks to @molavian053!
2020-11-27 18:47:50 -05:00
Atemo
ae3c6ce38b
Min/max issue (#5574)
* Fixed min/max issue for zero variable value
* Added a CI test script

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-27 14:50:29 +01:00
Lemongrass3110
f97dd6e85f
Fixed an issue with fake NPCs (#5554)
Correctly removing the state tracking of fake NPC usage in case the player was detached before the script ended.

Fixes #5379

Thanks to @blipblopblip and @Patotron
2020-11-22 21:10:16 +01:00
Lemongrass3110
f37990414f
Cleanup of MVP mode checking (#5559)
Fixes #5368

Thanks to @mazvi, @attackjom and @aleos89
2020-11-22 02:09:02 +01:00
Aleos
90d74c2ed1
Cleanup/skill db fixes (#5560)
* Cleanup of some minor skill db issues.
* Fixes CastCancel documentation to describe default as false.
Thanks to @Tokeiburu!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-21 18:41:43 -05:00
Balfear
071990ebc0
Update droplight effects (#5563)
Fixes #5547

Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-22 00:16:40 +01:00
Lemongrass3110
81e7d8ef89
Converted penalty db to YAML (#5562)
Fixes #5463

Added penalty for MVP exp and MVP drops
Removed penalty support for monster classes

Thanks to @attackjom and @aleos89
2020-11-21 01:05:07 +01:00
Atemo
3cddbd0487
Added ALL_THIRD, All_Upper, All_Baby, Both_Accessory, Both_Hand field (item_db.yml) (#5535)
* Updated the DB

Thanks to @Lemongrass3110 !
2020-11-19 16:03:27 +01:00
Lemongrass3110
e50ce0224f Fixed item job restrictions
Thanks to @attackjom
2020-11-17 19:35:11 +01:00
Balfear
4935248f10
Fix Slug Shot condition (#5556)
* Fixes #5555.
* Slug Shot should do less damage to monsters than players.
Thanks to @Balferian!
2020-11-17 09:47:50 -05:00
Lemongrass3110
4f853c96e9
Fixed a bug in reloadnpcfile (#5553)
Introduced in d098c01b

Fixes #5541
Fixes #4846

Thanks to @Triedge and @Stingor
2020-11-17 12:41:34 +01:00
Lemongrass3110
602c6035e5
Fixed some potential csv2yaml crashes (#5557)
Fixes #5549

Thanks to @Atemo
2020-11-17 11:51:01 +01:00
Lemongrass3110
9cdc008bfe
Fixed missing dummy item after reloading (#5552)
Fixes #5548

Thanks to @reunite-ro and @Triedge
2020-11-17 10:14:11 +01:00
Lemongrass3110
8053a72890
Fixed headgears for autotraders (#5558)
Fixes #5408

Thanks to @gidzdlcrz
2020-11-17 09:21:50 +01:00
Aleos
10703304da
Adjusts behavior of skill fixed cast time (#5136)
* Fixes #1061.
* Skills no longer assign 20% of the variable cast to fixed cast.
* Inverts the skill database behavior so that 0 actually means 0 cast time and -1 represents 20% behavior for backwards support.
* Updates documentation.
Thanks to @Tokeiburu!
2020-11-10 12:51:08 -05:00
Aleos
97bd759fde
Fixes skill elemental damage (#4905)
* Fixes #965.
* Fixes several skills getting their elemental damage recalculated several times resulting in extra damage.
Thanks to @exneval, @julia40124009, and @RagnarokNova!
2020-11-10 10:28:30 -05:00
Lemongrass3110
c924b90b2b Follow up to be9babe
Exporting the random option ids back into the script engine, since they might be useful to some custom scripts.
2020-11-09 14:12:51 +01:00
Aleos
be9babee32
Converts the random option databases to YAML (#5494)
* Fixes #3084.
* Creating random option groups now further reflects official behavior.
* Group bonuses can now be created without having to create multiple permutations of the same group.
* Specific slot options can now be defined which guarantee a bonus.
* Non-guaranteed options can now be defined along with a maximum amount.
* Random option value can now be defined as a range instead of a static value.
* Adds conversion of official random option groups.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-11-08 12:21:52 -05:00
Lemongrass3110
9e68985f61
Fixed invisible items after VIP expiration (#5521)
Fixes #5083

Thanks to @Everade and @mazvi
2020-11-06 23:19:41 +01:00
Aleos
008a2f9585
Fixes Venom Pressure combo with Poisoning Weapon (#5343)
* Resolves the poison from Poisoning Weapon not passing onto the target when using Venom Pressure.
Thanks to @teededung!
2020-11-06 14:32:10 -05:00
Lemongrass3110
d01b718cc0
Initial support for enchantgrade (#5445)
Thanks to @LunarSHINING, @idk-whoami and @attackjom
2020-11-05 22:18:12 +01:00
Patotron
12cfe31bf1
Fixed max Doram ASPD (#5522)
Co-authored-by: Toni Pozo <porutoni@gmail.com>
2020-11-04 12:02:29 +01:00
Lemongrass3110
aa80345839
Fixed item restrictions for "All" (#5518)
Since Doram's are 16 and MAPID_ALL was defined with only the first 16 bits were covered by 0xFFFF, the job restriction failed if Summoner was not explicitly allowed.

Fixes #5516

Thanks to @kaninhot004
2020-11-03 23:56:56 +01:00
Aleos
e8fcf01ffe
Resolves null YAML node checks (#5520)
Fixes #5510.

Resolves an issue with nodeExists not checking for null nodes resulting in parsing false-positives.
Further cleanup to the item DB SQL node parsing to allow some extra options to be toggle-able.
Default stacking options to false if not defined.

Thanks to @mplaten and @Lemongrass3110!
2020-11-03 22:42:02 +01:00
Lemongrass3110
765b6a8ed2
Fixed a useless warning for PACKETVER < 20141016 (#5519)
Fixes #5515

Thanks to @joven15 and @Patotron
2020-11-03 20:30:34 +01:00
Vincent Stumpf
d158603424
Fix other character disguises on @refresh (#5366) 2020-11-01 12:58:16 -08:00
Atemo
0964881a81
Small correction of getiteminfo script command (subtype shifted the values) (#5508)
Fixed #5505 

Thanks to @Triedge !
2020-10-30 18:32:09 +01:00
inhyositsu
b61089093f
Corrects BuyingStore parsing (#5502)
* Fixes a label parse check when loading BuyingStore values for items.
Thanks to @inhyositsu!
2020-10-29 08:47:42 -04:00
Aleos
93eaf3207e
Resolves SQL header output on suffix files (#5497)
* Resolves an issue where the wrong header was being printed to the SQL files that contain a suffix to them.
Thanks to @Atemo!
2020-10-28 12:45:52 -04:00
Daegaladh
8682a9e02e
Small walkpath optimizations (#5322)
* Thanks to @mattthewaz
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-27 11:58:35 +01:00
Eric Liu
7a4bef2ab7
Fix several honor token items and add Prontera Recall skill (#5431)
Co-authored-by: Eric <eric@nomoss.co>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-26 20:44:13 +01:00
Aleos
ad3f48f9de
Cleans up the item SQL parsing (#5478)
Fixes a couple issues with the column checking.
Adds verification to table columns to make sure table format is correct.
Cleans up the node processing.
Adds a loading progress status.
Adjusts the SQL import files to not destroy previously imported data.
Updated README.md to reflect the changes for SQL importing.

Fixes #5485
Fixes #5477

Thanks to @Lemongrass3110!

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-10-26 00:16:15 +01:00
Vincent Stumpf
de621fee16
Fix erroneous freeing of global combo script (#5483)
Fixes #5476
When removing a combo, we free the bonus script in the global map
Thanks to @saya9200
2020-10-25 22:53:43 +01:00
Lemongrass3110
7a4009601d Fixed newline escaping in YAML2SQL converter 2020-10-25 00:12:00 +02:00
Lemongrass3110
579dc7b3a1 Added an initial loading message to YAML parsing 2020-10-24 22:49:19 +02:00
Atemo
4786d76ef7
Fixed a typo in the item parsing (#5480)
The 'Locations' node doesn't exist in the block
2020-10-24 22:31:30 +02:00
Daegaladh
f28019a798
Fixed Acid Terror armor break rate on renewal (#5475)
*Follow up to ea8da71cdda5cddbc05cdc736683487e5c14bf08
2020-10-23 16:21:48 +02:00