2131 Commits

Author SHA1 Message Date
Inkfish
e7faa7e498 * Some clean ups on autocast and itemskill code. (see topic:220921 for some info)
- Autocasted Teleport now skips the menu.
- Fixed nullpo info when defensive autocasts are triggered. (follow up to r13815)
- Fixed Warp portal used in item script never worked.
- Item skills now bypass skill delay check.
- Implemented SM_SELFPROVOKE. 
- Updated item db using 'itemskill' for some items.
* Basic skills will never be reset. 

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13841 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 15:30:11 +00:00
L0ne_W0lf
c778107ca8 * Implemented the Party Buff cash skills.
* Misc updates, and updates for party buff items.
- Added CASH_BLESSING, CASH_INCAGI and CASH_ASSUMPTIO skills.
- Added itemskill commands for the party buff scrolls.
- Corrected Equipment repair book's itemtype to 11.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13840 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 03:28:20 +00:00
Inkfish
e06e7945aa Fixed normal casted Teleport always skip menu.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13839 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-03 00:07:38 +00:00
Inkfish
cf43afb4c9 Fixed skills used through items and Hocus-pocus consume requirements if you have them. (bugreport:3164)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13836 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-02 11:48:33 +00:00
Inkfish
efb13f2571 Fixed Fiberlock sometimes fails due to the long interval of skill_unit_timer. It may never fail now, though this may not be official. (bugreport:3136)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13834 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-06-01 14:01:42 +00:00
brianluau
e21b25987b - Fixed an off-by-one array index in r13815 that caused skills to use SP for (SkillLV+1). (bugreport:3152)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13830 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 21:23:03 +00:00
Inkfish
47c650a49a * Fixed gemstones are still required when players equipped Mistress Card. (bugreport:3147, follow up to: r13815)
* Fiberlock only catches targets the moment its casted. (bugreport:3136)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13829 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 13:54:49 +00:00
Inkfish
98cfff889a * Multiple autocasts can go off at a time now. [Inkfish]
* Splash damage doesn't get modified by percentual modifier now. [Inkfish]
* Monster's Spiral Pierce is again...non-elemental. [Inkfish]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13827 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 10:01:08 +00:00
Inkfish
8bd4ae799e * Fixed Hocus-pocus always fails. (bugreport:3143, follow up to: r13815)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13826 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-30 02:43:44 +00:00
Inkfish
f090bdbdbc * Added a new battle flag for telling which skills can have bHealPower effect.
* Added documentation for bHealPower.
* Fixed some behaviors for healing skills, (thanks to L0ne_W0lf)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13821 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 14:25:14 +00:00
Inkfish
ac5aa55ae7 * Added new bonuses bHealPower and bHealPower2.
* Heal skills code clean up. 
- bSkillHeal can affect offensive heal now. 
- bSkillHeal2 can affect AppleIdun and SlimPitcher now.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13820 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 12:21:59 +00:00
Inkfish
586fdbcfdf * Some more fixes to skill condition issues.
- Fixed skills fail when MAX_INVENTORY reached. (bugreport:3139)
- Fixed spiritballs not being removed correctly in some situation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13818 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-29 02:25:38 +00:00
Inkfish
a4c36c7af8 Hmm...fixed my last commit making Tarotcard ignore sp requirement.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13817 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-28 11:11:38 +00:00
Inkfish
61c0d7b744 * Fixed some issues of skill condition check.
- HP is now checked at the end of cast.
- Lv 6-10 StoneCurse doesn't consume gems.
- Tarotcard's after-cast delay will still be applied if it fails.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13816 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-28 11:00:22 +00:00
Inkfish
b14a11ff5e * skill_check_condition clean up (bugreport:2770, bugreport:2957, bugreport:3010)
- Weapon, SP, HP and state are checked at the beginning of cast.
- Required items and ammos are checked at the end of cast.
- SP and status change required are removed at the end of cast without checking again.
- Required items are removed only if the skill is successfully used.
- Autocasts won't check for requirements but will remove them if you have them(except for SP/HP).

Hope won't cause any problems...

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13815 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-27 14:11:08 +00:00
ultramage
e8e8e35eed Fixed crash when attacking while having a bBreakArmorRate item equipped (typo in r13800) (bugreport:3121).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13810 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-24 20:41:39 +00:00
Inkfish
36ae721899 Taro Card can now break shoes and garment and won't affect dead target. (bugreport:2513)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13808 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-24 04:58:40 +00:00
Inkfish
579f0a250d Splash attacks do cause additional effects except for autocasts. (bugreport:2661)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13804 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-23 03:25:33 +00:00
Inkfish
45addf32f8 NPC_STOP now stops both sides and will be canceled if either side teleports or dies.(bugreport:3099)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13803 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 15:36:41 +00:00
Inkfish
e19735da51 Splash attack doesn't cause any status effects or autocasts any more.(bugreport:2661)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13801 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 12:14:54 +00:00
Inkfish
d8a02e92eb * Fixed some behaviors of additional effects (bugreport:3100,bugreport:2661)
- Coma can now be blocked by such skills as SafetyWall, Pneuma and Basilica.
- Equipment breaking behaves exactly like coma.
- Skill's self damage may now causes coma, equipment breaking and autospell/autoscript.
- GrandCross now allows you to drain hp/sp.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13800 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-22 08:37:13 +00:00
Inkfish
f3572b9e6d * Now fiberlocking a fiberlocked target doesn't renew the timer but instead increases its fireweakness [Inkfish]
- This makes doublecasting firebolts on a double fiberlocked target having double damage from both 2 bolts possible = =(bugreport:3061)


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13799 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-20 12:42:06 +00:00
skotlex
64972e4b5a - Updated NPC_DRAGONFEAR to supposedly behave as it should
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13797 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 19:14:12 +00:00
Inkfish
6e54839512 Fixed the three hits of EarthQuake not being calculated seperately.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13794 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 10:34:43 +00:00
Inkfish
dbb4774882 Fiberlock now can trap multiple enemies on the same cell and its triggering area was reduced to 1x1.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13792 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-19 09:13:23 +00:00
Inkfish
a8fda75bb0 * Eske and Eska now affect friendly guardians and slaves. (bugreport:2131)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13786 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 16:11:05 +00:00
Playtester
4e49aad859 * Some fixes to the previous commit (apparently it didn't compile with VS 2008)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13785 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:43:59 +00:00
Playtester
6bf346a172 * Monocell, Instant Death and Class Change will now fail on bosses (bugreport:2907)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13783 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:04:20 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
Inkfish
1a70b702c8 * More logical modifications on skill_additional_effect thing. Thanks to ultramage.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13771 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-14 16:15:17 +00:00
Inkfish
19ba08fe2c Fixed effects being applied improperly in some rare cases.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13768 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 11:44:14 +00:00
Inkfish
e4ed05e3f0 PNEUMA, BASILICA and SAFETYWALL no longer protect you from such negative status changes as COMA, STUN, FREEZE and etc. (bugreport:1346)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13767 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 11:07:09 +00:00
Inkfish
889de6533d * Fixed combo wait was not canceled when Kick skill was successfully used. (bugreport:1345)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13765 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 09:04:38 +00:00
zephyrus
15a8174e29 - Rental items now can be stackable items too.
- Added @font command to test kRO fonts. (Client side requires : Langtype 0 / Hex + Fonts Files on the data folder).
- Rental now announces with a maximum time to fix a problem with 1 month or more rentals.
- Reduced amount of calculations of Flee on map change (only if required).
- More security on Rental items.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13761 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 16:47:12 +00:00
Inkfish
3f0559ebca * Fixed Aid Potion can heal the Emperium (bugreport:164)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13759 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 14:53:05 +00:00
Inkfish
acdd90f4aa * Removed DEF reduction display when casting GrandCross.
- This might not be official and led to repeated calculation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13758 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 11:30:48 +00:00
Inkfish
5c56cedcbc * Magnetic Earth will never stack even if they are from the same team.(bugreport:2568)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13750 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 06:03:05 +00:00
Inkfish
f49e69515f * Lv10 Waterball used by mobs should have 81 balls instead of 121
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13741 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 23:50:11 +00:00
Playtester
5575c28e84 * Fixed up the base success rate of normal strip skills
- normal strip skills: 5% + 5%*level
- Full Strip: 5% + 2%*level

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13740 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 17:06:56 +00:00
Inkfish
96635c8c81 * Update Waterball code due to info updated
* A piece of GX casttime def reduction code I forgot to merge

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:43:37 +00:00
Inkfish
0595535167 * Fixed splash damage from Baphomet Card might miss. [Inkfish]
* Check if group unit is expired before processing it. (bugreport:3054) [Inkfish]
* Fixed Grand Corss outdated behavior (bugreport:1590) [Inkfish]
- use new damage formula
- DEF is reduced to 2/3 during cast time
- block shields switching within attack duration
- monsters don't damage themselves any more
- intervals between hits are 300ms

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13736 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:15:14 +00:00
Inkfish
68a983ce4b * Fixed players can pull water from ME cell (follow up to r13730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13733 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 09:19:58 +00:00
Inkfish
afaf28a4fa * Players now are allowed to copy the skills the level which is beyond the skill_db max. [Inkfish]
* Fixed some behaviors for Waterball (bugreport:3024) [Inkfish]
- High level Waterball used by players doesn't increase the number of balls.
- Monsters can't pull water from cells with Magnetic Earth.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13730 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 13:34:31 +00:00
Inkfish
f02ea5bfd1 * Block equipments switching for some skills (bugreport:2900)
- cannot change equipments during Arrow Vulcan's cast time
- cannot change equipments within Desperado's attack duration

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13724 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 10:20:13 +00:00
Playtester
dd635a835a * Spirit of Bard and Dancer now only works for mastered skills (bugreport:3037)
- also fixed an outdated comment in the source code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13714 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:33:41 +00:00
Playtester
33911a7594 * Fixed break equipment debuff working on bosses (bugreport:3023)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13703 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-27 16:53:12 +00:00
Playtester
7a215a7119 * First attempt to fix up the strip skills, please make sure these fixes work (bugreport:3011)
- the minimum rate of strip skills is now 5% for all levels
- duration of strip skills depends on the dex difference between target and caster and can be reduced to 0
- strip skills can now affect bosses (if duration doesn't get reduced to 0 due to their high dex)
- strip skills do a fixed -25% ATK, -15% DEF, -40% VIT or -40% INT independant of skill level
- autocasting Full Strip has a duration now (if dex is high enough)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 10:40:40 +00:00
ultramage
c17d002e07 Renamed Happy Break's status name from SC_TKREST to SC_EARTHSCROLL, since that's its official purpose and it doesn't do anything else.
Also removed the associated SI_TKREST since this status doesn't actually have an icon.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 09:37:08 +00:00
ultramage
cd82016586 Fixed several occurences of map_freeblock() being used before map_deliddb() (caused by r13503, r13505 and r13508) (bugreport:2959).
This would cause object ids (chatrooms / ground items) to never be removed when DEBUG_MEMMGR was turned on, ultimately causing a 'no free object id' fatal error.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13689 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 14:05:20 +00:00
ultramage
d6ca23f16f Made some adjustments to the land skill code, based on official information:
- Expanded and corrected the land skill view id enum in skill.h
- Renamed UNT_ATTACK_SKILLS to UNT_DUMMYSKILL and UNT_KAENSIN to UNT_KAEN (official terminology)
- changed GS_DESPERADO to use the UNT_DUMMYSKILL view id instead of UNT_KAENSIN (and is it supposed to be a land skill at all?)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 13:57:22 +00:00