13278 Commits

Author SHA1 Message Date
Cydh Ramdh
4068266d12 Fixed #893, #920. Success rate of Tarot Card of Fate's Death was accidently changed in b385fd048a6872b0fbd2562f619c51bf75f47599
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-21 17:31:18 +07:00
Playtester
30395fa9cf Merge branch 'master' of https://github.com/rathena/rathena 2016-01-20 21:39:36 +01:00
Playtester
cccd1496f7 Monster Vulture's Eye and Snake's Eye removed (fixes #916)
* Monsters no longer have Vulture's Eye level 10 and Snake's Eye level 10 learned by default
* When you tank Cecil Damon from 10-14 cells away, she will no longer use her target skills
* Added a configuration with which you can set the level of Vulture's Eye and Snake's Eye that monsters have learned
2016-01-20 21:35:54 +01:00
aleos89
5c30116c11 Follow up to a2270aa
* Fixed VC14 failing to compile on Release mode. Thanks to @mrdiablo.
2016-01-20 12:58:00 -05:00
aleos89
af773a94a9 Follow up to b98fe0b
* Added a check if allocation fails.
2016-01-20 12:52:10 -05:00
aleos89
b98fe0b597 Cleanup
* Moved parsing for start_point and start_items to separate functions.
* Moved startitem struct to mmo.h and declared start_items in the charserv_config.
* Adjusted the MAP_DEFAULT_NAME for pre-renewal to the correct map.
2016-01-20 10:18:26 -05:00
nanakiwurtz
3227356840 Item DB SQL Sync
* Synced new items from commit 1d2dc2a8

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-01-20 14:24:02 +07:00
nanakiwurtz
759cc41d99 Tool Update
* Added Unique Index to convert_sql.pl

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-01-20 14:22:20 +07:00
nanakiwurtz
1d2dc2a82a Item DB Update
* Added item 6941, 6942, 6960, 17569, 22899, 22901

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-01-20 14:19:41 +07:00
Napster
8413ae905b Follow up to d70b173
* Add support Mechanic Outfit, thank you to Rytech for client support
2016-01-20 11:53:45 +07:00
Napster
b8a05178f1 Follow up d70b173 Fixed compile warning.
thank you to @Playtester point this.
2016-01-20 10:31:18 +07:00
aleos89
20e4029e26 Updated Volcanic Ash effect
* Follow up to 71ffda3.
* Skill cast failure chance should only occur at the end of cast.
2016-01-19 14:45:14 -05:00
Playtester
9cfca1cc08 Follow up to 5d7d994 and 6ebcb67 (code optimizations)
* Waterball now uses UNT_DUMMYSKILL
* Deluge/Volcano/Gale will no longer be blocked by UNT_DUMMYSKILL units
* Waterball will no longer cancel when damage is 0, on official servers this only happens if damage is negative but rAthena is no longer coded to handle negative damage unless you enable a custom feature, so... just don't use Waterball on water monsters, ok?
* Fixed two compiler warnings
2016-01-19 20:17:04 +01:00
Playtester
4c2d5153c3 Pre-renewal cast time fixes
* Mystical Amplification cast time can no longer be reduced by item bonuses except Staff of Destruction (fixes #903)
* Foresight will no longer stack additively with other cast time reductions (fixes #899)
* Suffragium and Foresight will now be consumed by skills, even if they aren't affected by them

Note: Whether skill-specific reductions stack additively with general reductions and how it works in renewal still needs to be tested, going to create separate issues for those once confirmed.
2016-01-18 21:01:38 +01:00
Cydh Ramdh
0d0c144b09 Follow up 6ebcb67601117f0e6a39aad67a1a4de11c9b8d86. Fixed compile error.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-18 10:54:58 +07:00
Playtester
5d7d994ca0 Follow up to 9db667c (BSS fixed)
* Simplified the check (no need to check for ensemble and Adoramus separately)
* Fixed PR_BENEDICTIO not working at all
* Fixed chorus skills and WZ_COMET only counting to 1 rather than MAX_PARTY
2016-01-17 20:59:26 +01:00
Playtester
6ebcb67601 Waterball, Jupitel Thunder and Mystical Amplification behavior improved
- Implemented Waterball and Jupitel Thunder double cast (fixes #907)
* Waterball and Jupitel now won't apply a delay after they have been cast and won't notify the client about the spell until 150ms later, if another skill request is received, it will actually be cast as well
* To prevent exploits this behavior can only be used every 2 seconds
* This allows you to cast a spell after Jupitel that would not have enough range to be cast after knockback
- Finally implemented the official waterball unit behavior
* When casting Waterball, water, deluge and suiton units will be turned into waterball units
* These waterball units are then turned into waterballs one-by-one
* All unit behavior now also applies to waterball, special handling is now solved via db files
* If there are multiple waterball timers active at the same time, they will actually compete for the waterball units
* When waterball does not deal damage (100% resist), it will now cancel, allowing you to act and move again
* If this breaks anything, please notify me
- Mystical Amplification improved (fixes #908)
* Mystical Amplification will now toggle at cast begin rather than cast end
* When Mystical Amplification ends, spell damage will be immediately lower even for ongoing spells
2016-01-17 18:00:18 +01:00
Playtester
bbe9601c0d Fixed Soul Destroyer range (fixes #905)
- It is actually 9 in both renewal and pre-renewal
2016-01-16 13:37:09 +01:00
Napster
3a8aac4fb0 Follow up d70b173
*Missing document for body style
2016-01-13 16:37:23 +07:00
Napster
c1f843d755 Follow up d70b173
* Remove sctipt command closedressroom not used this
* cleanup some code
* check white space
* add detail&document packets
2016-01-13 13:10:57 +07:00
Nova
88d2cd7cfd Fixed Makibishi
Fixed an error where Makibishi unit_db was set to have an AoE, so when
you would refresh the screen you would see
http://i.imgur.com/mr3g1zG.png become http://i.imgur.com/UnecX60.png
This makes the skill behave as intended, as before the real AoE was that
of the second image.
2016-01-12 16:00:08 -08:00
aleos89
b85885c0a6 Updated Water Screen Option effect
* Behaves like Devotion now.
* Damage beyond Aqua's HP is not reflected back to the master.
* Damage is now properly displayed on Aqua rather than the master.
Thanks to @exneval.
2016-01-12 18:10:35 -05:00
Aleos
01ba54c77c Merge pull request #832 from CairoLee/master
Fixes #652 and #818
* Resolves players being able to talk to NPCs when a shop is open.
Thanks to @CairoLee, @anacondaqq, and @admkakaroto.
2016-01-12 17:56:31 -05:00
Atemo
6a62aab6d4 Merged Hercules@de7a8c0eaaeeb0994f58c8b419e5d2523c7df5a7, Eden quest were giving wrong equipments.
Merged Hercules@c7c956f71e63c9dd477c59d778c25690c6267b83 and fixed another bug in Collect Poison Spores case
2016-01-12 23:02:08 +01:00
aleos89
b439ef3168 Follow up to 8a730cd
* Fixes pc_delitem checking for an invalid index.
* Adjusted to not count Magnifiers if other checks fail.
2016-01-12 14:34:50 -05:00
aleos89
e4a3811b92 Fixes #681
* Follow up to 4019fb4.
* Corrects Hover not avoiding splash attack skills.
2016-01-12 14:17:51 -05:00
aleos89
8a730cdec9 Follow up to 5fe8145
* Cleaned up and added a few more checks to oneclick_itemidentify.
2016-01-12 12:16:21 -05:00
Lemongrass3110
9046e7ecf7 Fixed #884
Thanks to @mrjnumber1 and @csnv
2016-01-12 17:52:03 +01:00
aleos89
9db667c6ac Follow up to 4871dab
* Expanded the array for Comet's SP cost to MAX_PARTY to avoid overflow.
* Refined the count check for skill_check_condition_char_sub:
-- Included Adoramus in the check.
-- Added a fail safe check.
Thanks to @theultramage.
2016-01-12 10:51:29 -05:00
Lemongrass3110
f424a2a71d Reverted 2d03e7f and d32c857
Fixes #890 and #897

Sorry for the inconveniences guys!
2016-01-12 15:59:42 +01:00
Napster
05cb1607c5 Follow up 3f26c3d
* forgot change packets version, stick on 20130807
2016-01-12 11:06:40 +07:00
Napster
d70b1734c8 Add support body style implementation
* This feature require the client support before 2015-05-13 or newer
   Make sure you data&lub support for this

  note : read info to https://rathena.org/board/topic/104205-2015-client-support/

  Special Thanks you to Rytech, @aleos89
2016-01-12 01:55:30 +07:00
nanakiwurtz
3f26c3ddcc Fixed #895
* Thanks to @Dark8008 and @Playtester

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2016-01-12 00:14:47 +07:00
Napster
2debd47b6b Merge branch 'master' of https://github.com/rathena/rathena 2016-01-11 22:47:06 +07:00
Napster
a636732f46 Follow up to d2d1fd2
* Update Packets Change size for newer client
2016-01-11 22:46:23 +07:00
Cydh Ramdh
45aab55ca1 Fixed #866. Chain Lighting animation was sent in wrong flow.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-10 10:50:34 +07:00
Cydh Ramdh
9643230521 Follow up 0be6389c4881ad7c06ad1a546909b8f934a81d8a.
* Fixed compile error, thanks to @anacondaqq

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-09 18:11:37 +07:00
Aleos
0be6389c48 Merge pull request #888 from secretdataz/patch-1
Add master ID check in script command setunitdata
* Fixes #887
* Thanks to @secretdataz!
2016-01-08 14:32:38 -05:00
Jittapan Pluemsumran
08e26c9de9 Don't set the md->state.copy_master_mode if master_id check fails. 2016-01-09 01:51:04 +07:00
aleos89
b7eb62ffb4 Follow up to a54bb65
* Fixed the config format.
* Adjusted atcommand go to properly place players on renewal mode.
2016-01-08 13:33:24 -05:00
aleos89
a54bb653de Randomized Start Point
* Fixes #805
2016-01-08 12:27:10 -05:00
Lemongrass3110
85a4c272ca Follow up to 2b00879
Added the missing status icons(which were not in const.txt when converting it).
Also validated the status changes and removed the TODO mark since all of them are exported correctly.
2016-01-08 15:57:56 +01:00
Jittapan Pluemsumran
f2bad5e832 Add master id check in setunitdata script command. Fixes #887 2016-01-08 16:57:22 +07:00
Jittapan Pluemsumran
f987f1bcbe Mob DB Update - Added card drops
- Lighthalzen Biolab F4
- Hall of Abyss
- Malaya Port
- Eclage
- Old Glast Heim
2016-01-08 13:18:29 +07:00
Lemongrass3110
315056b02e Merge pull request #880 from rathena/cleanup/itemdb_aegisname
Added unique indices to ensure that aegis name is only used once per table.
Also added all scripts from sql-files to the travis CI script so that our build check will fail if we have a sql syntax error in there or some duplicate values.
2016-01-07 19:54:09 +01:00
Lemongrass3110
e76fdbf15b Merge pull request #881 from rathena/cleanup/const.txt
Clean up the way we handle our script constants.
Since most of them come from source anyway we now export them directly into the scripting engine to ensure that they use the correct values.
The main benefits are that you users don't have to fear that we forget to adjust something according to source changes, if you use the constants in your scripts that is, and we developers do not have to think about updating them anyway. It also guarantees that constants that used wrong values before this use the correct values that are defined source side.
2016-01-07 19:31:37 +01:00
Cydh Ramdh
68ab3d89fb Reverted Ground Drift changes on c699304bd95b5c3bf9dddcca1dd2fe842169c650
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-07 11:37:01 +07:00
aleos89
9b48263026 Fixes #882
* Resolves a potential crash with Soul Exhale and SC_NORECOVER_STATE. Thanks to @stmarier and @mrjnumber1.
2016-01-06 22:24:59 -05:00
Lemongrass3110
65347041c1 Migrated all boolean constants to source exports 2016-01-07 00:53:31 +01:00
Lemongrass3110
76725b436d Follow up to 958b6cd
Fixed compilation on linux, since those constants were only defined on windows.
2016-01-07 00:52:00 +01:00