8478 Commits

Author SHA1 Message Date
Atemo
de80c5aab6
[Suggestion] Implement cloakonnpc/cloakoffnpc (#4688)
* The player can interact with a NPC cloaked by cloakonnpc command (click, mob event..) but the NPC trigger area is disabled (= the OnTouch* part is disabled).
* The changes last until the player leaves the map, logs out, or the npc option is updated by disablenpc/enablenpc/hideonnpc/hideoffnpc/cloakonnpc/cloakoffnpc commands.

Thanks to @aleos89
2020-03-11 22:47:23 +01:00
Yashim Wong
e2de896414
Removes Bowling Bash Chain Damage (#4695)
* Fixes #4693.
* Removes Bowling Bash chained damage stacking on top of itself.
Thanks to @violent01 and @yashimwong!
2020-03-11 16:55:53 -04:00
Atemo
67a07fd4d6
Small update of npc_enable_sub (#4673)
* With this update a player standing on a NPCTYPE_WARP disabled will be warped when the npc is enabled
2020-03-10 17:42:41 +01:00
Aleos
1453bcad4f
Small fix to skill_damage_db parsing (#4696)
* Fixes #4690.
* Ignore the space after damage rate.
Thanks to @Tutankhaten!
2020-03-09 16:05:10 -04:00
Aleos
1961e0ee88 Removes incorrect MSVS file copy
* Fixes #4697.
* Follow up to ea8da71.
Thanks to @Tutankhaten!
2020-03-09 14:19:56 -04:00
Aleos
ea8da71cdd
Rebalancing of 1st/2nd/Transcendent class skills (#4072)
* Fixes #3715.
* kRO changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7040
* Refactored size_fix database to YAML.
Thanks to @flamefury for his translations!
Thanks to @Angelic234, @mrjnumber1, @Badarosk0, @OptimusM, @attackjom, @Playtester, Melvo, @cydh, @cahya1992, Sigma, @whupdo, @teededung, @ecdarreola, @hotspicy945, @RagnaWay, @sader1992 for bug testing!
2020-03-06 10:57:19 -05:00
Aleos
850904ab3e
Corrects a compile warning (#4689)
* Fixes #4686.
* Corrects a compile warning for an uninitialized variable.
Thanks to @Tutankhaten!
2020-03-06 10:38:10 -05:00
Aleos
496f362ec9
Fixes skill database reloading (#4669)
* Fixes #4660.
* Resolves an issue with skill database reloading not clearing the previous data first.
* While clearing the YAML cache it will also resize the cache to the previous capacity.
Thanks to @teededung!
2020-03-04 13:03:06 -05:00
Aleos
5c35ec7d69
Corrects skill_damage_db parsing (#4667)
* Fixes #4574.
* Removes the usage of atoi as any failure returns 0.
* Adds checks for cases of invalid data.
* General cleanups and fixes.
* Fixes the import database documentation.
Thanks to @Skormie!
2020-03-04 12:33:37 -05:00
rAthenaAPI
35b2f69530 Effect State Update 2020-03-04 05:05:27 +01:00
Amir Azman
b143241222
Fix Typo in Cleans up Summoner dual-cast attacks commit (Map Crash Issue) (#4677)
* Fixes #4676.
*  Fixes a typo in Professor’s Dual Casting check.
Thanks to @reunite-ro!
2020-03-01 15:45:23 -05:00
Joam
18ab64f2a1
Fix missing check element for non-damage skill (#4664)
* Fixes #4661.
* Resolves an issue with an element resistance check.
Thanks to @reunite-ro and @attackjom!
2020-02-26 08:04:26 -05:00
Aleos
836eda4879
Cleans up Summoner dual-cast attacks (#4658)
* Cleans up Summoner dual-cast attacks Bite, Silvervine Stem Spear, Scar of Tarou, and Picky Peck so that they behave like Professor's Double Casting.
* Adjusts success formula.
Thanks to @Rytech2!
2020-02-25 19:58:12 -05:00
Aleos
97372ff423
Adds reload attendance database atcommand (#4657)
* Fixes #4656.
* Adds an atcommand option for reloading the attendance database.
* Adds missing headers for attendance database.
* Adds missing reload options in the atcommand configuration.
Thanks to @lelouch22's suggestion!
2020-02-23 17:10:17 -05:00
Aleos
1fc4b8de20
Battleground Queue fixes (#4648)
* Fixes #4644.
* Initialize all battleground queues at startup to reduce overhead of creation/deletion during live server.
* Removes lots of duplicate code between team checks.
* Adds missing checks for script commands bg_leave and bg_desert to only warp players out using the Battleground Queue System.
* Adds documentation for script commands bg_leave and bg_desert to state players will be warped out after when using the Battleground Queue System.
* Optimizes join logic to add new players to the end of the queue rather than the front.
* Cleans up the client messages so certain responses are cleared when they need to be.
Thanks to @Balferian and @Lemongrass3110!
2020-02-20 22:25:14 -05:00
Aleos
b13bc7402c
Resolves an issue with mob avail options (#4651)
* Fixes #4647.
* Resolves an issue with mob avail options not properly checking the state of the option label.
Thanks to @Litro!
2020-02-17 20:30:05 -05:00
Lemongrass3110
d165c19b73 Fixed jump_zero for conditions over INT32_MAX
Thanks to @Atemo
2020-02-17 22:50:19 +01:00
rAthenaAPI
390eb9772a Effect State Update 2020-02-16 11:05:27 +01:00
rAthenaAPI
1e091cd58a Effect State Update 2020-02-14 02:20:45 +01:00
Lemongrass3110
b681339529 Revert "Effect State Update"
This reverts commit cee7242623c2e5572bfe5b74a57543939587df49.

Fixes #4635
2020-02-13 00:35:43 +01:00
rAthenaAPI
cee7242623 Effect State Update 2020-02-12 15:05:53 +01:00
Aleos
2931c00bd4
Implemented the Battleground Queue System (#3995)
* Fixes #1310.
* Added a battle config which allows toggling of the Battleground Queue client feature and also toggles between the modes of scripts.
* Added script commands bg_reserve, bg_unbook, and bg_desert.
* Removed old custom Battleground scripts.
Thanks to @Lemongrass3110, @Locien, @secretdataz, @InusualZ, @Normynator, @Atemo, @iubantot, @admkakaroto, and @noobzter003!
2020-02-12 08:26:59 -05:00
rAthenaAPI
c292794154 Effect State Update 2020-02-12 14:05:44 +01:00
rAthenaAPI
653631dfe1 Effect State Update 2020-02-12 14:05:30 +01:00
Lemongrass3110
d12b4fdca0
Added support for RSW 2.2 (#4627)
Merged mapserver and mapcache RSW reading code
2020-02-11 23:49:47 +01:00
aleos
9b6976ea7b Removes some warnings from script command mail
* Follow up to e5c22b3.
* Remove the warnings for refine and bound options as these aren't mandatory fields.
Thanks to @Lemongrass3110!
2020-02-11 17:25:38 -05:00
vakhet
1ec101b9a4
Changed dummy item id (#4625)
Fixes #4616
2020-02-11 22:37:22 +01:00
Jason L
e5c22b360f
Added refine and bound options for mail command (#4272)
* Added refine and bound option for mail script command.
* Made some slight corrections to the script_commands document.
* Note: Any custom scripts that use this command and give some sort of card or random option bonus need to be adjusted as refine and bound come before these options now.
Thanks to @Skormie!
Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
2020-02-11 10:18:59 -05:00
Aleos
986f8b0595 Fixes Land Protector not removing some units
* Fixes Land Protector not removing units with the RangedSingleUnit flag.
Thanks to @teededung!
2020-02-11 08:30:57 -05:00
Lemongrass3110
39f7d28872
Fixed some compiler warnings on prere (#4626)
Fixes #4621

Thanks to @Litro
2020-02-10 23:37:26 +01:00
Lemongrass3110
ee96438607 Fixed a map-server crash
Fixes #4614

Thanks to @reunite-ro
2020-02-08 16:35:02 +01:00
Daegaladh
77dd729d77
Fixed SA_FREECAST aspd calculation (#4570)
* Thanks to @Lemongrass3110
2020-02-07 22:05:33 +01:00
Aleos
e6a6c0533c
Updated 3rd class from RO 16th Anniversary Patch (#3659)
* Fixes #3602 and fixes #3653.
* Updated the 3rd class skills according to the RO 16th Anniversary Patch.
* Complete changelog here: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3890090&curpage=1
Thanks to @Badarosk0, @OptimusM, @Victor214, @Rytech2 and @laziem!
2020-02-07 10:39:35 -05:00
Lemongrass3110
b0ac1717f2
Added an option to block discount in shop (#4606)
This is required for the correct implementation of #4387
2020-02-07 00:29:33 +01:00
Lemongrass3110
57e50a1906 Fixed remove trap skills
Fixes #4605

Thanks to @Angelic234 and @mazvi
2020-02-05 23:29:01 +01:00
Sader Fawall
5386a5bcf4
Fixed some skill crit bonuses (#4454)
* Fixes #4128, fixes #4453, and fixes #4460.
* Resolves critical item bonus not applying to skills.
Thanks to @sader1992!
Co-Authored-By: Cydh Ramdh <cydh@pservero.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-02-05 14:38:56 -05:00
Daegaladh
4a1e904149
Fixed Hocus and Improvised Song ignoring mapflags (#4488)
* Fixed skills casted by SA_ABRACADABRA and WM_RANDOMIZESPELL ignoring critical mapflags
2020-02-05 15:15:14 +01:00
userid0
f76bc09fbe
Fixed a compiler warning in pc.cpp (#4601)
fix warning C4804: '>': unsafe use of type 'bool' in operation
2020-02-04 22:04:43 +01:00
Atemo
ac0d17f4aa
Corrected getfreecell command for flag 2 (#4491)
* Little simplification of the code
* Extends the target type for flag 2 to match the docs (target applicable for player, monster, pet, homunculus)
Thanks to @Lemongrass3110
2020-02-04 19:58:04 +01:00
Atemo
78eb1bcd7b
Additional check in map_mapid2mapname (#4373)
* The mapid2name script command didn't check if the map existed (potential crash)
2020-02-04 15:01:00 +01:00
rAthenaAPI
6c8840ca54 Effect State Update 2020-02-04 05:05:35 +01:00
Lemongrass3110
0b3430c777
Fixed some database redundencies (#4565)
Cleaned redundancies in guild members and friends table

Fixes #4564

Thanks to @Everade
2020-02-03 20:27:11 +01:00
Lemongrass3110
b86926a7a2
Fixed a compiler warning in script.cpp (#4586)
Fixes #4582

Thanks to @idk-whoami and @aleos89
2020-02-03 14:44:58 +01:00
Lemongrass3110
a323474433 Fixed a few hard coded element checks 2020-02-02 20:01:55 +01:00
Lemongrass3110
5cf7aceb2a Fixed some bugs with the new skill db
Fixes #4590

Thanks to @mazvi
2020-02-02 16:04:11 +01:00
aleos
7bdfe81867 Skill Ammo requirement fixes
* Fixes #4589.
* Resolves an issue with the skill converter outputting the incorrect ammo type requirement.
* Also fixes an issue with physically attacking targets while having a status option active.
Thanks to @mazvi!
2020-02-01 16:06:13 -05:00
aleos
ecd2a9af87 Fixes script command resetskill
* Follow up to dca3797.
* Resolves a missing skill index lookup during skill reset.
Thanks to @mmanlapat!
2020-02-01 08:54:34 -05:00
Aleos
dca3797d44
Converted the skill database to YAML (#4531)
* Combines skill_cast_db, skill_castnodex_db, skill_copyable_db, skill_nonearnpc_db, skill_require_db, and skill_unit_db into skill_db.
* Introduces a cached YAML class for quicker lookups.
* General cleanups and optimizations.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-31 14:14:08 -05:00
Aleos
de9f667d2f
Corrects Max Baby Third Parameter issue (#4578)
* Fixes #4576.
* Added missing case for returning battle config for Baby Third classes.
Thanks to @reunite-ro!
2020-01-29 17:03:24 -05:00
Daegaladh
ed51647311
Fixed hom_idle_no_share exp check (#4557)
* Follow up to 921b3e2c3e9eae36cbf2ca35bcede6e0d73ba074
2020-01-28 21:29:30 +01:00