205 Commits

Author SHA1 Message Date
Aleos
c67b60e375
Corrects Power Swing and Axe Boomerang behavior (#5123)
* Fixes #5109.
* Power Swing should only cast Axe Boomerang when an axe is equipped.
Thanks to @Haydrich!
2020-06-29 11:18:14 -04:00
Aleos
f45b2dd0f3
Improvements to skill_detonator (#5118)
* Fixes #3268.
* Adds more safety checks for possible nullptr skill_unit_group data.
* Adjusts order of failure checks to speed up operations.
Thanks to @uddevil and @ecdarreola!
2020-06-29 10:40:22 -04:00
Aleos
f8721de7c0
Fixes a crash non-player objects and timed skills (#5117)
* Fixes #5110.
* Fixes a potential map server crash when non-player objects attempt to use Chain Lightning, Tetra Vortex, or Flash Combo and are kill during duration.
Thanks to @Hope8888!
2020-06-29 10:04:12 -04:00
Atemo
96bf3904db
Added the race RC_PLAYER_DORAM (#5132)
* Added RC_PLAYER_DORAM to differentiate summoner race from monster race RC_BRUTE (similiarly to RC_Player_Human and RC_DemiHuman)
* Replaced PC_Player by RC_Player_Human and added a deprecation notice
2020-06-25 20:06:04 +02:00
Aleos
3158c542de
Fixes NC_REPAIR and NC_SHAPESHIFT requirements (#5129)
* Fixes #5124.
* Fixes the level independent item requirements for Repair and Shape Shift being offset by 1.
Thanks to @ecdarreola!
2020-06-23 10:58:35 -04:00
Sader Fawall
d6d56babf2
Fixes skill cast delay flag (#5127)
* Resolves an issue with CastDelayFlags not properly assigning to the correct variable.
Thanks to @sader1992!
2020-06-22 09:18:17 -04:00
Aleos
9775c947da
Lux Anima is no longer able to be canceled (#5120)
* Fixes #5026.
* Lux Anima is no longer able to be canceled like the other Rune Stones.
Thanks to @Masao87 and @flamefury!
2020-06-19 08:27:55 -04:00
Daegaladh
1f5871a85b Fixed position desync using Back Slide when being hit on pre-re
* Follow up to c4609b19d6910ae05d6424a8cb1da2142d870ef0
2020-06-19 02:51:48 +02:00
Aleos
60d03a1978
Fixes Rolling Cutter counter not resetting (#5082)
* Fixes #5052.
* Fixes Rolling Cutter counter not resetting with blown-type attacks/movements.
Thanks to @LordWhiplash!
2020-06-15 08:42:18 -04:00
Aleos
c875ebd5e2
Fixes Rune Mastery visual effects (#5027)
* Fixes #5023.
* Fixes Rune Mastery displaying a success effect under the failure effect when a Rune fails to be produced.
Thanks to @Masao87!
2020-06-12 10:53:14 -04:00
Aleos
e4e593fbbe
Fixes Ensemble skills behavior (#5014)
* Fixes #4987.
* Ensemble skills apply SC_ENSEMBLEFATIGUE which should disable skill casting and reduces movement speed/ASPD by 30%.
* Applies SC_ENSEMBLEFATIGUE to both the caster and partner.
Thanks to @LordWhiplash!
2020-06-12 10:11:57 -04:00
Aleos
2b0d13b231
Cleans up Genetic creation skills (#4957)
* Fixes #4930.
* Fixes Mix Cooking quantity calculation to be based off the difference of the good and bad stat.
* Fixes Mix Cooking failure to create a random amount of failure material that's independent of the initial quantity calculation.
* Fixes Create Bomb to behave similar to Mix Cooking without the failure materials.
* Fixes Special Pharmacy quantity calculation to be based off of the difference of the good and bad stat along with a base quantity depending on the level used.
Thanks to @mrjnumber1 and @SeravySensei!
2020-06-12 08:31:04 -04:00
Aleos
6ce5ba10b4
Corrects Hell's Plant behavior (#4966)
* Skill is no longer a unit skill but a status.
* Adjusts the attack rate timer to official.
* Skill does not proc cards.
* Skill does not reflect damage.
Thanks to @Tokeiburu, @ecdarreola, and @attackjom!
2020-06-12 08:11:25 -04:00
flamefury
39fb658810
Fixes Acolyte/Priest self-AoE skill ranges (#5056)
* Animations for Angelus, Impositio Manus, Suffragium, Magnificat, and Gloria no longer play for party members who are within skill range but outside of visible viewing range.
* Fixes AoE size of Magnificat and Impositio Manus.
* Fixes SP consumption of Impositio Manus.
* Fixes the splash range for Angelus and Gloria.
Thanks to @flamefury!
2020-06-10 08:51:57 -04:00
Aleos
35c3301dda
Clean up Summoner Power skill checks (#4999)
* Centralized the Summoner Power skill tree checks into one function.
* Fixes a couple passive skill bonuses not being recalculated when reaching 20 investment points.
Thanks to @exneval and @Balferian!
2020-06-06 22:42:30 -04:00
Daegaladh
b758a60bee Fixed death counter not being properly reseted with Super Novice link
*Follow up to 929c30c4143dc78cb85bc70d022113e75f62d0cc
2020-06-03 17:12:05 +02:00
Lemongrass3110
45cd5808b7
Initial support for newer packet versions (#4944)
Basic support for packets up to April 2020
Changing the default packet version to 2020-04-01

Thanks to everyone involved!
2020-06-03 16:35:10 +02:00
SeravySensei
cd0937c468
Fix missing pet egg checks (#5029)
Fixes #5024
2020-05-31 16:11:01 +02:00
Aleos
023dcac49f
Adjusts Reverberation behavior (#5013)
* Reverberation no longer uses any sub-attack skill.
* Adjusts hit count to be split on each hit.
Thanks to @attackjom!
2020-05-28 11:37:31 -04:00
aleos
81a2b8c995 Fixes NPC_DARKBREATH attack type
* Follow up to 70d6876.
* Fixes #4997.
* The attack type for NPC_DARKBREATH will now properly read the database value.
Thanks to @qwerty7vp!
2020-05-22 09:19:41 -04:00
LordWhiplash
46aa15a182
Summoner corrections (#4993)
* Fixes SU_POWEROFSEA max HP and max SP bonus when investing more than 20 skill points.
* Fixes SU_SPIRITOFLAND and SU_CN_POWDERING combo's perfect dodge bonus.
Thanks to @LordWhiplash, @qwerty7vp, and @Balferian!
2020-05-21 22:24:29 -04:00
Aleos
70d6876494
Corrects NPC_DARKBREATH behavior (#4982)
* Fixes #4864.
* Adjusts damage formula to official.
* Adjusts damage type from Misc to Magic.
* Skill now has a 50% success chance to damage the target.
* Removes Flee and Defense Card ignore flags.
Thanks to @Masao87 and @mrjnumber1!
2020-05-20 18:50:04 -04:00
Aleos
a34a2f6de0
Fixes Blood Sucker not being able to be recast (#4968)
* Fixes #4964.
* Fixes Blood Sucker not being able to be recast on another map if caster dies while active.
* Minor cleanups and added safety checks.
Thanks to @Everade!
2020-05-20 17:20:37 -04:00
Aleos
5d4fd1d3b7
Resolves Autospell displaying errors to console (#4921)
* Fixes #4883
* Fixes Autospell displaying invalid skill errors when clicking Ok or Cancel.
Thanks to @admkakaroto!
2020-05-19 17:19:34 -04:00
Aleos
18b642c174
Skill Database cleanups (#4902)
* When reloading the skill_db clear out Abra, Magic Mushroom, and Reading Spell Book databases as well.
* Fixes NC_SHAPESHIFT and NC_REPAIR checking an invalid ItemCost slot based on the old implementation.
* Updated a lot of references to the old skill databases.
2020-05-19 15:32:57 -04:00
Aleos
d9f533165e
Fixes Adoramus' interaction with Land Protector (#4920)
* Fixes #4876.
* Adoramus should not do damage to anyone inside the range of Adoramus.
Thanks to @teededung and @Tokeiburu!
2020-05-18 16:51:46 -04:00
Aleos
44e5c5bcc7
Job Improvement Project - Rune Knight (Part 2) (#4709)
* Fixes #4708.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=243&curpage=1
Thanks to @ecdarreola, @Litro, @Haydrich, and @LordWhiplash!
2020-05-18 13:35:07 -04:00
Aleos
a23c84d345
Job Improvement Project - Guillotine Cross (#4705)
* Fixes #4704.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=243&curpage=1
Thanks to @Angelic234, @nehpetskie, @ecdarreola, @Haydrich, @Badarosk0, and @LordWhiplash!
2020-05-18 10:47:21 -04:00
Aleos
fde031fb19
Job Improvement Project - Minstrel/Wanderer (#4701)
* Fixes #4211.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=235&curpage=1
* kRO Changelog 2: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Angelic234, @Litro, @LordWhiplash, @Feelmeone, @ecdarreola, and @teededung!
2020-05-18 09:44:12 -04:00
Aleos
061e586a1f
Few Genetic skill fixes (#4813)
* Fixes Acid Demonstration to use the target's VIT and not casters.
* Fixes Fire Expansion - Acid to behave like Acid Demonstration.
* Fixes Crazy Weed not doing 2 damage attacks.
* Crazy Weed is now a long ranged physical attack.
* Adjusts Hell's Plant behavior to no longer be removed on map change.
* Adds missing status icon for Hell's Plant.
* Fixes Hell's Plant attack formula when learning Summon Flora.
* Hell's Plant now uses the caster's weapon as the element.
* Hell's Plant no longer ignores the target's DEF and Element.
* Fixes Hell's Plant removing Thorns Trap.
* Removes fixed cast time from Xeno Slasher.
* Adds new Genetic Pharmacy potions (items are disabled until int32 item ID support).
* Fixes Spore Explosion's splash attack doing the same damage as the initial.
Thanks to @teededung, @Badarosk0, @cahya1992, and @OptimusM!
2020-05-13 21:02:57 -04:00
Daegaladh
132e74bd13 Follow up to c4609b19d6910ae05d6424a8cb1da2142d870ef0 2020-05-14 02:57:13 +02:00
Daegaladh
48fd0e859b Follow up to 8d2c26d115f0c44fb2d53efb5409c43ad0103946 2020-05-10 15:54:43 +02:00
Yashim Wong
8d2c26d115
Removed sonic blow attack animation (#4926) 2020-05-10 13:49:46 +07:00
Daegaladh
c4609b19d6
Follow up to b2aa7e698da55bcae198dfcda7ab706f35d958e3 2020-05-10 05:30:24 +02:00
~Neutral~
39f3a17f54
Fixed Dual Wielding Axes breaking when they should be unbreakable (#4518) 2020-05-10 04:21:41 +02:00
Aleos
931155ee33
Job Improvement Project - Super Novice (#4429)
* Fixes #4427.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Rytech2!
2020-05-07 14:48:44 -04:00
Aleos
5e8d9aafab
Job Improvement Project - Kagerou & Oboro (#4425)
* Fixes #4424.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Badarosk0, @OptimusM, @teededung, and @Angelic234!
2020-05-06 13:36:27 -04:00
Aleos
ea59d80490
Corrects Feint Bomb not hiding the caster (#4874)
* Resolves an issue with Feint Bomb not hiding the caster.
Thanks to @Badarosk0!
2020-05-04 11:56:14 -04:00
Aleos
9794aa2b80
Fixes an issue with status timers being destroyed (#4885)
* Fixes #4856.
* Follow up to d1f8c8c and 652d77e.
* A missing break from an old commit along with a refactor in code resulted in a "valid" fall through and breaking status change timers.
* Also fixes a potential crash with Book of Creating Star.
Thanks to @OptimusM, @technoken, @sader1992, @mazvi, and @akiyamamio16 for helping debug!
2020-05-03 11:30:50 -04:00
Aleos
e92f88a030
Fixes battle config skill_removetrap_type (#4865)
* Fixes an array out of bounds check when attempting to return used traps to a player through HT_REMOVETRAP.
Thanks to @marky291!
2020-04-30 13:51:09 -04:00
Aleos
8f19cfc3a1
Fixes Weapon Crush and Weapon Blocking combo (#4809)
* Fixes #4808.
* Weapon Crush now uses SC_WEAPONBLOCK_ON to track the target instead of SC_COMBO.
* Also fixes Quick Draw Shot target selection.
* Quick Draw Shot and Weapon Blocking should be considered a combo and not end physical attacks when casting them.
* SC_QD_SHOT_READY will no longer become active if the player has 193+ ASPD.
* SC_QD_SHOT_READY will now end once Quick Draw Shot has been casted.
* Cleans up skill_check_condition_sc_required and removes duplicate code.
Thanks to @wdivet, @LordWhiplash, and @ecdarreola!
2020-04-30 12:17:50 -04:00
Aleos
2ca94ad411
Adds back removed skills from kRO (#4803)
* Fixes #4802.
* Adds back AB_EUCHARISTICA, GN_SLINGITEM, and GN_MAKEBOMB.
* Adds back CR_CULTIVATION for renewal.
* Skills are disabled in the skill tree database but gives easy ability to re-enable.
* Fixes an issue with pre-renewal produce database spitting errors when using any production-type skills.
Thanks to @trinitynetworks!
2020-04-30 09:33:38 -04:00
Aleos
312df0f10c
Job Improvement Project - Rebellion (#4428)
* Fixes #4426.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7081
Thanks to @Tokeiburu, @OptimusM, @admkakaroto,@cahya1992, @Tolimatoi, and @Badarosk0!
2020-04-24 13:58:09 -04:00
aleos
44b80448df Removes target SP consumption from Tiger Cannon
* Removes target SP consumption based on damage dealt by Tiger Cannon.
* This effect was removed in #4256 but accidentally merged back in through #3659.
Thanks to @Badarosk0!
2020-04-14 12:16:53 -04:00
Lemongrass3110
6570489a84 Fixed Soul Reaper's Soul Collect behavior
Added missing status change cancel condition, when the player has reached the maximum amount of soul spheres.
Fixed duration display on the client.
Some cleanup of duplicate code.

Thanks to @aleos89
2020-04-14 15:25:04 +02:00
Aleos
7507065885
Corrects Brandish Spear damage stacking (#4740)
* Fixes #4739.
* Follow up to 24ecebc.
* Resolves Brandish Spear damage doing more damage than it should.
Thanks to @violent01!
2020-04-07 16:59:38 -04:00
Aleos
af8dd8b28d
Fixes issue with power skills (#4751)
* Fixes #4743.
* Resolves an issue with power skills and default data defined in the skill's array.
* Adds back linear determination and documentation for it.
* Adds a check in the converter to not print out values of 0 for levels 6 and higher for skill unit layout and skill unit range.
* Removes these values from the skill database.
Thanks to @Surefirer and @teededung!
2020-04-06 10:44:17 -04:00
victorgawk
044acebd75
Added config option for legacy NPC EMOTION behavior (#4728)
Co-authored-by: Victor Ferreira <victor.ferreira@esig.com.br>
2020-04-02 11:04:07 +02:00
Aleos
6edcf4a3a1
Fixes Wall of Thorn knockback (#4685)
* Fixes #4645.
* The knockback should be based on self and not the caster of the skill.
Thanks to @devLOOLP!
2020-03-31 08:20:04 -04:00
Aleos
652d77eb02
Job Improvement Project - Genetic (#3284)
* Fixes #2571.
* Updates Homunculus skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=218&curpage=1
* Updates Genetic skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Tokeiburu, @Badarosk0, @Balferian, and @Haydrich!
2020-03-25 13:26:26 -04:00