3811 Commits

Author SHA1 Message Date
Playtester
0affe1454c * Item-bonuses and NPC skills now use the official default durations for status changes
- you gain Curse immunity if you have 0 Luk (seems buggy but is official)
- our status defense stats are already fully correct :-)
- thanks to ultramage for testing this

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13790 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 20:45:44 +00:00
ultramage
7f18f11403 status calc code cleanup
* Inverted the status calc code order, so that status_calc_bl optionally invokes status_calc_pc/mob/whatever instead of every status_calc_* calling status_calc_bl.
 * Inlined functions status_calc_bl_sub_pc, status_calc_bl_sub_hom and status_calc_bl_sub_mer into status_calc_bl.
 * Restructured status_calc_bl to require as little bl type-specific branching as possible.
 * Split status_calc_bl into two layers - the inner does the battle status calculations, while the outer deals with running appropriate base status calculations, remembering old values and handling client updates.
 * The status_calc_bl function is now the single entry-point for all status calculations.
 * status_calc_bl will now trigger a client update only on attributes that actually changed.
 * If hp or sp changes during status_calc_bl, it will now properly refresh on the client.
 * Removed SCB_PC, now SCB_ALL should be used instead.
 * Revived the unused status calc flag SCB_BASE to indicate that a base status recalculation should be done first (that's what the status_calc_* functions are for).
 * Defined a new symbolic bitmask SCB_BATTLE (SCB_ALL - SCB_BASE) in case someone needs to only calculate the battle status (currently unused).
Please report any issues with this update.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13789 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-18 07:24:58 +00:00
ultramage
046c8f501f Removed the optional target parameter from atcommand_homshuffle, since the standard #-charcommand mechanism exists for this very purpose (code from r9671).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13788 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 20:36:05 +00:00
skotlex
0fa2e82da2 - Fixed a couple of crashes that could ensue from the last memory corruption fix to free'ing clones.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13787 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 20:24:45 +00:00
Inkfish
a8fda75bb0 * Eske and Eska now affect friendly guardians and slaves. (bugreport:2131)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13786 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 16:11:05 +00:00
Playtester
4e49aad859 * Some fixes to the previous commit (apparently it didn't compile with VS 2008)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13785 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:43:59 +00:00
Playtester
6bf346a172 * Monocell, Instant Death and Class Change will now fail on bosses (bugreport:2907)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13783 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-17 15:04:20 +00:00
Playtester
3c7f50114c * AutoSpellWhenHit now triggers on normal+skill by default (bugreport:1652)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13777 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 16:41:27 +00:00
ultramage
34def63ece Cleaning/fixing the previous commits a bit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13775 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 11:41:40 +00:00
skotlex
418f0d9200 - Fixed a bunch of invalid memory access bugs as reported by Valgrind.
- Updated unit_stop_walking to not move character an extra cell when it is already half-way there unless flag 0x4 is        passed. (bugreport:3078)
- Fixed the monster MD_CASTSENSOR code not correctly setting the monster's aggressive state.
- Corrected a few compiler warnings
- Changed a bit the code for SC_BOSSMAPINFO so it is not so hideously ugly.



git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13774 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 10:27:05 +00:00
ultramage
3e1d1414ae Changed the type of the 'first' parameter of status_calc_pc/mob/pet/homunculus/mercenary functions' from integer flag to a simple boolean.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13773 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:49:54 +00:00
ultramage
4acc0932f2 Removed the undocumented custom level feature from monster spawn lines (bugreport:3076).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13772 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-15 07:33:39 +00:00
Inkfish
1a70b702c8 * More logical modifications on skill_additional_effect thing. Thanks to ultramage.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13771 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-14 16:15:17 +00:00
Inkfish
1032d53f6e * Sorry for taking 3 steps for this ugly code. Please take it as a compromise since we do not have enough info to emulate how Aegis does.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13769 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 12:17:19 +00:00
Inkfish
19ba08fe2c Fixed effects being applied improperly in some rare cases.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13768 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 11:44:14 +00:00
Inkfish
e4ed05e3f0 PNEUMA, BASILICA and SAFETYWALL no longer protect you from such negative status changes as COMA, STUN, FREEZE and etc. (bugreport:1346)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13767 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 11:07:09 +00:00
Inkfish
889de6533d * Fixed combo wait was not canceled when Kick skill was successfully used. (bugreport:1345)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13765 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-13 09:04:38 +00:00
zephyrus
76a985f7cb - Removed "serial". Sorry i merged from my source.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13763 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 17:15:05 +00:00
zephyrus
15a8174e29 - Rental items now can be stackable items too.
- Added @font command to test kRO fonts. (Client side requires : Langtype 0 / Hex + Fonts Files on the data folder).
- Rental now announces with a maximum time to fix a problem with 1 month or more rentals.
- Reduced amount of calculations of Flee on map change (only if required).
- More security on Rental items.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13761 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 16:47:12 +00:00
zephyrus
7828b01c09 - Fixed a bug (important on Battlegrounds if you are using then).
* A player can do more than 1 damage to a plant per hit, if he equip only one weapon on left hand and keep the right hand clean and receives Weapon Element buff, for example the post effect of Magnum Break. On battleground it means you can destroy quickly crystals and barricades.
- Also fixed the extra bonus of the leaf hand, it was using the bonus of the right hand.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13760 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 15:39:17 +00:00
Inkfish
3f0559ebca * Fixed Aid Potion can heal the Emperium (bugreport:164)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13759 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 14:53:05 +00:00
Inkfish
acdd90f4aa * Removed DEF reduction display when casting GrandCross.
- This might not be official and led to repeated calculation.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13758 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-12 11:30:48 +00:00
ultramage
161d254bb3 Fixed Slow Grace decreasing aspd 10x less than it should (bugreport:2480).
It was a mistake in r12923 where I didn't realize aspd_rate uses a scale of 1000, not 100.
This also fixes Slow Grace not factoring in the Dance Lessons bonus (also 10x less than it should be).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13755 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-11 17:46:02 +00:00
Inkfish
c5b963aa46 * Fixed a crash when mob uses self-destruct skills (bugreport:2568) [Inkfish]
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13754 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-11 15:40:12 +00:00
Inkfish
bba5e225cc * Fixed the incorrect DEF reduction of Joint Beat (bugreport:3051)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13751 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 11:13:59 +00:00
Inkfish
5c56cedcbc * Magnetic Earth will never stack even if they are from the same team.(bugreport:2568)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13750 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 06:03:05 +00:00
Inkfish
c36c82150a * A typo on my last commit
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13748 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 03:13:47 +00:00
Inkfish
b6f136a75d * Now if an NPC is unloaded, only the timer of the player attached to this npc will be deleted.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13747 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-10 02:44:02 +00:00
Inkfish
bb1c9d92de * Fixed NPC timer errors
- ted->rid is not initialized for global timer
- timer_id is not set to INVALID_TIMER when timer is deleted
- run script after next event is arranged

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13746 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-09 16:12:28 +00:00
Inkfish
5343380fc4 * Fixed GX's skill level modifier is missing
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13745 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-09 14:47:09 +00:00
Inkfish
a366ac53ce * Fixed some known and unknown player attached NPC timer problems
- Attached timer now can be stopped properly.
- Attached timer will now stop if the NPC is unloaded. (bugreport:2510)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13744 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-09 01:45:11 +00:00
Inkfish
f49e69515f * Lv10 Waterball used by mobs should have 81 balls instead of 121
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13741 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 23:50:11 +00:00
Playtester
5575c28e84 * Fixed up the base success rate of normal strip skills
- normal strip skills: 5% + 5%*level
- Full Strip: 5% + 2%*level

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13740 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 17:06:56 +00:00
Inkfish
0aa94a295f * Clean up for npc timer code
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13738 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 14:52:22 +00:00
Inkfish
96635c8c81 * Update Waterball code due to info updated
* A piece of GX casttime def reduction code I forgot to merge

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:43:37 +00:00
Inkfish
0595535167 * Fixed splash damage from Baphomet Card might miss. [Inkfish]
* Check if group unit is expired before processing it. (bugreport:3054) [Inkfish]
* Fixed Grand Corss outdated behavior (bugreport:1590) [Inkfish]
- use new damage formula
- DEF is reduced to 2/3 during cast time
- block shields switching within attack duration
- monsters don't damage themselves any more
- intervals between hits are 300ms

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13736 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:15:14 +00:00
Inkfish
ed83c8817d * Added check on stackable items to 'checkweight' (bugreport:1569, bugreport:2756, bugreport 2994) [Inkfish]
* Fixed flee penalty wasn't applied for battleground and wouldn't be restored on map change [Inkfish]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13735 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 10:38:00 +00:00
Inkfish
68a983ce4b * Fixed players can pull water from ME cell (follow up to r13730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13733 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 09:19:58 +00:00
brianluau
09914e3ce6 - Fixed an uninitialized variable in r13724. (bugreport:3052)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13731 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-06 23:14:06 +00:00
Inkfish
afaf28a4fa * Players now are allowed to copy the skills the level which is beyond the skill_db max. [Inkfish]
* Fixed some behaviors for Waterball (bugreport:3024) [Inkfish]
- High level Waterball used by players doesn't increase the number of balls.
- Monsters can't pull water from cells with Magnetic Earth.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13730 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 13:34:31 +00:00
brianluau
53998c9f3d * Added the md5() script command. (follow up to r13719)
- Changed kafra storage password to be stored as md5 hash in #kafra_code$.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13728 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 08:22:53 +00:00
Inkfish
f02ea5bfd1 * Block equipments switching for some skills (bugreport:2900)
- cannot change equipments during Arrow Vulcan's cast time
- cannot change equipments within Desperado's attack duration

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13724 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 10:20:13 +00:00
Inkfish
ffa383b768 *Sorry, something I forgot to merge from my own code.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13722 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 05:05:47 +00:00
Inkfish
8704a43725 * Players now cannot be revived during pvp respawn delay
* Fix a logical problem on my last commit

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13720 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:41:04 +00:00
Inkfish
a43c9e581b * Fix several npctimer issues (bugreport:1619, bugreport:1730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13718 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:06:53 +00:00
Inkfish
8cd8f32c78 * Fix 'awake' not working (bugreport:2580)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13717 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 02:59:53 +00:00
Inkfish
39b15f37c8 * Do not log damage if it's done by mob itself (bugreport:2933) [Inkfish]
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13716 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 02:12:57 +00:00
Playtester
dd635a835a * Spirit of Bard and Dancer now only works for mastered skills (bugreport:3037)
- also fixed an outdated comment in the source code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13714 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:33:41 +00:00
brianluau
a11e789e0a - Fixed some typos in the script command documentation. (bugreport:2547)
- Fixed a misleading message in the custom Job Changer. (bugreport:682)
- Updated some NPC's facing directions. (bugreport:3030)
- Added missing newline in some ShowWarning(). (bugreport:2940)
- Fixed SC_BOSSMAPINFO time being off by 1 minutes (bugreport:3035)
Now, the seconds are rounded up to the next whole minute.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13713 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:23:30 +00:00
ultramage
23bd309798 Added missing case SC_ONEHAND (from r5227) and case SC_MERC_QUICKEN (from r13203) to function status_change_start.
Added missing case SC_AURABLADE (from r13693) to function status_change_end.
Added symbolic names for all OPT3 values and replaced the OPT1/OPT2/OPT3/OPTION defines with corresponding enums.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-30 02:26:04 +00:00