47 Commits

Author SHA1 Message Date
Atemo
4db212bf1b
Academy monster re-spawn (#3280)
* This PR adds a custom delay to avoid abusive behaviour in the novice academy.
2018-07-06 01:46:56 +02:00
Atemo
6e8599cd5b
Extra npc checks (#3274)
* Extra checks
- Added some extra check in npcs script to prevent wrong behaviour
2018-07-03 23:24:04 +02:00
Atemo
e4eddc3e61
Fixed for issue #3273 (#3275)
The npc should give Gunslinger Manual when the player doesn't have one
Fixed #3273

Thanks to @lRaikeNl !
2018-07-03 01:51:26 +02:00
Aleos
a12c79f782
Moved remaining refine NPC to the database (#3145)
* Fixes #2510.
* Added Holink and Wagjak values to their own entries in the refine database.
* Added several anti-hack checks to refine NPC.
Thanks to the suggestion from @mazvi and @Atemo!
2018-05-27 16:07:39 -04:00
Atemo
aee83557a9 Corrected a NPC name in academy.txt
Fixed #3048

Thanks to @Angelic234 !
2018-04-16 15:26:38 +02:00
Atemo
ea88ea5054
Emoticons constant name (#2527)
This PR change the emoticons constant name to match emoticonlist from client side.
Note: the previous emoticons names are now deprecated.

Additionnally emotion and unitemote scripts commands are being merged together to the new format
-> emotion <emotion number>{,<target>};
Where target use the target Game ID (GID) of the unit (npc, pet, character etc..).

* unitemote is now deprecated.
* Additionnally fixed incorrect variable in quests_brasilis.txt

Thanks to @aleos89 and @Lemongrass3110 !
2017-11-10 18:35:21 +01:00
Atemo
c7d5b61409 New Intro for Renewal - continuation of https://github.com/rathena/rathena/pull/2309 (#2530)
* Update map iz_int in mapcache.dat for the new Intro Map
* Update Academy script for the new Intro based on kRO: [http://www.inven.co.kr/webzine/news/?news=176048&site=ro](http://www.inven.co.kr/webzine/news/?news=176048&site=ro)
* Add monster spawn in the new Intro Map
     
Thanks 805a2b3b1a (diff-8d1dca8dc246e9f4d38c6f1ad0d2c930) for original script.

Thanks @jenkijo for the base, @Lemongrass3110 and @aleos89 for the review, and Divine Pride for some infos !
2017-10-21 00:23:49 +02:00
Atemo
73b798bf12 Removed extra semi-colon 2017-04-06 14:40:36 +02:00
Atemo
c6470ff4ff Clean-up permanent monster spawn: (#1831)
* Clean-up permanent monster spawn:
- <delay1>,<delay2>,<event> are actually optionnal field
- <event> value 0 and 1 are meaningless (actually event name with length < 4 are skipped)

* Exported monster AI constants

* Updated docs for monster size constants (already exported)
Notes:
- the default size for monster script cmd was small not medium
- monster script cmd now display a warning for size above SZ_BIG (previously SZ_ALL)

* - Fixed an issue to make <xs> and <ys> optionnals
- Updated npcs scripts

* Leftover in the docs for permanent monster spawn

* Corrected english docs. Credit to @aleos89
Added additionnal warning for xs / ys negative input. Credit @Lemongrass3110 

Thanks to @cydh for the idea
2017-01-22 19:03:08 +01:00
Cydh Ramdh
2896d894d1 Official Random Coordinates for Savepoint (#1756)
* Added parameters for `savepoint are range for `x` and `y` for random savepoint coordinates.
* Added documentation for new savepoint params. Credits to @aleos89
* Updated savepoint on script to follow official behaviour (random save in 3x3). All credits to @Atemo
2016-12-20 17:16:42 +07:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00
Atemo
d62f422e3d Corrected OnTouch/OnTouch_ in NPC script (#1548)
Some leftover from aegis convertion..

Skipped pre-re folder, I don't have old data.
2016-09-07 21:35:14 +02:00
Lemongrass3110
818727f7ef Fixed wrong usages of specialeffect (#1529)
* Fixed wrong usages of specialeffect

* Missing fix
2016-08-31 20:36:17 +02:00
Atemo
85f44a587d Removed useless lines 2016-06-22 15:50:40 +02:00
Atemo
7d6be7e21e Add F_getpositionname to return the EQI_* name 2016-04-18 15:50:28 +02:00
Atemo
05a1b61bed Correct script part 2016-04-16 16:45:33 +02:00
Aleos
59eef4c73b Merge pull request #1092 from secretdataz/patch-1
Added support for Summoner Basic Skill to Kafra (fixes #1117)
* Added two new global NPC functions F_CanOpenStorage and F_CanChangeJob to remove redundancy.
Thanks to @secretdataz!
2016-03-31 09:10:30 -04:00
Jittapan Pluemsumran
bd6539a9ba Follow up to c23688c
Unify all checks into one function.
Suggested by @Cydh.
2016-03-26 10:52:30 +07:00
Jittapan Pluemsumran
c23688cea4 Clean up basic skill checks 2016-03-23 21:11:57 +07:00
Atemo
7e66be5932 Replace strnpcinfo(1) by the current npc name and fix some mistake
Signed-off-by: Atemo <capucrath@gmail.com>
2016-02-29 19:45:45 +01:00
Atemo
321b1d22e8 Removed the displayed name in from of the message displayed by npctalk and unittalk scripts commands (so we can append whatever we want to).
Signed-off-by: Atemo <capucrath@gmail.com>
2016-02-23 22:12:18 +01:00
Atemo
0af2a80d06 Fixed some typo and change classchange to setnpcdisplay in novice adacemie #800 2015-12-11 00:44:39 +01:00
Atemo
3a45dd97f9 Another clean-up 2015-12-09 23:09:17 +01:00
Atemo
1f47604f57 Fixed issue #800 2015-12-02 21:31:11 +01:00
Atemo
c3e56b9c1b Update 2015-11-26 23:11:22 +01:00
Atemo
cc8edaaac6 Merged novice academie from Hercules 21564acf13
-> All Credit to Kisuka for this big work.

Added news commands to alter questinfo conditions :
- setquestinfo_level : Add level range criteria for quest info with quest id 'quest_id'.
- setquestinfo_req : Add quest requirement for quest info with quest id 'quest_id'.
   -> Player have / doesn't have the required quest.
- setquestinfo_job : To add additionnal job criteria.
-> Credit to Cydh !
2015-11-16 00:34:00 +01:00
Cydh Ramdh
9d3d34205f Skill DB clean ups
* Changed skill_db array to better memory allocation.
* Reduced MAX_SKILL_LEVEL from 100 to 10 (part of Hercules 0f4a50d135), also has changes on skill_get checks for skill level that more than 10.
* Reduced MAX_SKILL from 5020 to 1200 (actually only 1109 skills are used).
* Added macros for checking Homunculus, Guild, Mercenary, & Elemental skill ranges.
* Added skill check & index validation when player logged in and when @reloadskilldb.
* Corrected `enum e_skill_flag` order for SKILL_FLAG_REPLACED_LV_0's sake.
* Merged 'addtoskill' script command just as alias of 'skill' script command.
* Fixed #277
* Changed 'skill' script command flag to constant value

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>

NOTE:
* Decreased memory usage by map-server reduced up to 50 MB.
* Decreased memory for each player because of mmo_charstatus::skill[] only has 1200 array, before is 5020.
* Please use skill_get_index() for accessing sd->status.skill[] or skill_db[], don't reckless use skill_id as array index.
* Please import upgrade_20150211_skillset.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-12 15:50:50 +07:00
Euphy
cad0a57865 Replaced 'getserverdef' command with 'script_hardcoded_constants' function in source. These constants can now be directly accessed in scripts. (Hercules 950e3eb)
- Relocated 'Option_*' constants from 'db/const.txt' to source; added OPTION_COSTUME compound. (Hercules a5728fd)
- Added MAX_CHAT_USERS define. (Hercules 950e3eb)
- Follow-up ca9642a: applied 'Loc' changes to Pre-Renewal database.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-01 15:42:49 -05:00
Euphy
90b187ff3e Changed all "Compatible With" fields to "rAthena Project".
Edited a handful separately, as appropriate.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-12 16:24:38 -05:00
Euphy
97687ca10c Global_Function updates.
* Added the following functions:
  - "F_GetPlural" (returns plural of noun) / "F_InsertPlural" (returns plural if arg != 1)  [credits: EnglishClub for formation rules]
  - "F_InsertArticle" (returns 'a' or 'an' preceding word)
  - "F_InsertComma" (formats number with commas)
  - "F_GetNumSuffix" (formats number with '-st', '-nd', '-rd', or '-th' suffix)
* Added and removed new functions where necessary. (incomplete)
* Added new types to "F_GetArmorType" function, and weapons will now pass to "F_GetWeaponType".
* Reformatted comments.

Other changes:
* Removed some garbage text from scripts.
* Slight edits to custom warper script.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-03 20:13:44 -05:00
Euphy
d2ee0dd55f * Implemented VIP system in many official scripts.
- VIP players gain two more badges after Battleground matches.
- VIP players pay ten times less for transportation to Brasilis and Dewata.
- VIP players get free buffs and mercenary rentals in the Eden Group Headquarters. (iRO only, disabled)
- Non-VIP players must use a Reset Stone to begin the third job quests.
- Non-VIP players must have a Marriage Covenant to get married.
- Non-VIP players pay double for Kafra and Cool Event Corp. Teleport Services.
- Non-VIP players pay considerably more for refining equipment.
- Non-VIP players gain less quest reward items in Port Malaya quests.
- Non-VIP players gain less EXP rewards in Brasilis quests.
- Non-VIP players cannot access all towns in Acolyte Warpers script. (iRO only, disabled)
- A Reset Stone is required for Bossnia entry.
Note that official servers run different VIP/premium systems; the changes above are based on euRO, unless otherwise stated.

* Other script changes:
- Adding Marriage Covenant item in marriage script.
- Fixed some EXP values in Brasilis quests.
- Minor updates to Kafra functions.
- Turned Cool Event Corp. scripts into a basic function.
- Turned Battleground badge rewards into basic functions.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2013-11-18 23:54:17 -05:00
Euphy
26036efcb7 * Implemented official kRO Novice Training Grounds (RE) script. (fixes bugreport:7923 and bugreport:7759)
- Added Job Test NPC, "Job Guide Lark".
- iRO's custom features are removed (Eden Teleporter and custom mob spawns).
- NPCs and warps are now duplicated on all new_*_* maps (reason unknown).
- Note: The script will be replaced with Cryptura Academy once the scripts are translated.

Signed-off-by: Euphy <euphy@rathena.org>
2013-08-06 02:32:56 -04:00
euphyy
fdd0fd1d72 * Standardized label names and converted all labels to Pascal case. (temp. fix for bugreport:6988)
* Many fixes to Izlude Arena scripts.
* Other misc. standardization.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17410 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-07-10 07:25:44 +00:00
euphyy
4589a4d135 * Updated Eden Quests 71-85 to its latest version. (translation: Muad_Dib)
* Updated all 1st class training quests, mostly experience changes. (credits: Muad_Dib, partial revert of r17210)
* Added Pre-Renewal support to 1st class training quests. (bugreport:7808)
* Corrected level 10 AL_HEAL lines in 'npcskill' to use MVP heal.
* Corrected EXP checks in 'checkre' to use RENEWAL_EXP instead of RENEWAL.
* Fixed Hunter skill quest not accepting Rangers.
* Fixed a bug in Hall of Abyss. (bugreport:7815)
* Fix unable to move when cloaking in levels less than 3. (credits: Akinari, bugreport:7810)
* Idle timer now resets on continuous attacks, i.e. /noctrl or ctrl+click. (Hercules 19f0fcd)
* Idle timer is now initialized upon login, fixing a bug with the 'checkidle' command. (credits: Akinari)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17409 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-07-10 05:11:53 +00:00
euphyy
bb5364c2d1 > Follow-up r17048:
- Renamed 'useskilltopc' to 'npcskill';
- Removed cast time from NPC objects, code by mkbu95 (suspected official behavior);
- Documented 'npcskill';
- Replaced all instances in scripts.
* Fixed max level bypass, code by malufett (bugreport:5800).
* Updated Malangdo spawns to official.
* Some standardization of npc/quests/first_class/.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17049 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-12-27 06:11:18 +00:00
j-tkay
3f6e0b89e5 - Fixed bugreport:6997, Novice Training Ground: check quest accordingly. (re/jobs/novice/novice.txt)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17025 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-12-16 15:13:26 +00:00
euphyy
2adc9cdf28 * Follow-up r16726, more standardization on docs.
* Replaced and added dividers in many script files with one standard divider.
* Other misc. cleaning...

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16727 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-09-01 00:37:36 +00:00
j-tkay
e75f8c9fe7 - Fixed bugreport:6528, Eden Group Officer's level requirement. (npc/re/jobs/novice/novice.txt)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16679 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-22 07:21:48 +00:00
euphyy
d0d887fffa * Some cleaning of "Eden Group Quests" script, fixes include bugreport:6510 (re\quests\eden\eden_quests.txt)
* Other misc. cleaning...

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16671 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-20 19:07:14 +00:00
daegaladh
f49b3d6f55 Full npc folder reorganization. (I hope I didn't break anything D:)
-Now common scripts goes to the main npc folder, and pre-re-only/re-only ones goes to their respective folders.
-NPCs with practically the same script but little differences have been left in the main folder and uses the command checkre() for the differences.
-For those NPCs with different coordinates but same script, the script has been left in the main folder but the NPCs splitted as duplicates.
-All pre-renewal files has been reverted back to their pre-renewal behavior.

TODO:
-Correct pre-re quest rewards.
-Check for pre-re/re differences in mapflags.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-01 04:29:56 +00:00
brianluau
a70cabd131 - Added svn:eol-style=native property on some recently added text files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16534 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-30 07:32:24 +00:00
euphyy
89283445c0 * Updated custom Stylist with 'getbattleflag', so no user configuration is required, credits to Saithis (custom\stylist.txt)
* Replaced effect numerics with constants in Ex. Super Novice script (re\jobs\novice\supernovice_ex.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16511 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-27 18:45:08 +00:00
euphyy
cde78b4fc4 * Updated Super Novice Expansion quest to match the official one, thanks to Gennosuke (the original script is edited a lot, though)
* Updated "Pile Bunker" quest to official, also thanks to Gennosuke
* Follow-up r16485, removed bind limit from documentation

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16505 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-26 16:37:30 +00:00
euphyy
ec79a1b50d * Some cleaning of "Novice Training Grounds" script (npc\jobs\novice\novice.txt)
* Cleaned up "PvP NPCs" script a little bit (npc\other\pvp.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16438 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-18 02:30:53 +00:00
euphyy
a413425884 * Added a Super Novice Expansion quest with custom dialogue. Will be updated once we get the official script.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16437 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-17 15:05:13 +00:00
euphyy
b4a0f33eba * More optimization of Ash-Vacuum quests (npc/quests/quests_13_1.txt)
* Fixed a minor typo, bugreport:6191

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16387 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-10 16:12:56 +00:00
shennetsind
086af74531 Okie ladies and gentleman if this commit breaks anything it's jman's and maki's fault, yes, blame them.
Fixing pre-re / re npc support, moving /config/ folder to src root so other servers may also make use of the #define renewal dir and other stuff.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16382 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-08 19:30:07 +00:00