12282 Commits

Author SHA1 Message Date
Cydh Ramdh
1fe4ad5af4 Item Updates:
* Changed type of some box-type items, from '11' to '18'
* Corrected some Aegis names
* Uncommented some item packages
* Updated item_db_re.sql file

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-10-03 16:42:01 +07:00
aleos89
a39f9ac8a2 Various cleanups.
* Updated comments for chat.c and pet.c files.
* Cleaned up various other comments and stylization.
2014-10-02 12:49:04 -04:00
aleos89
2b870c24d5 Various cleanups.
* Added and cleaned up comments.
* Added checks to prevent map server crashes.
* Cleaned up some reports from CPPCheck.
* Other various stylization cleanups.
2014-10-02 09:16:52 -04:00
Cydh Ramdh
ce090ce916 Skill Changes:
* Wizard/Warlock Skill
  * Moved Sightrasher (WZ_SIGHTRASHER) requirement to check Sight (SC_SIGHT) is active or not to skill_check_condition_castend section.
  * Fixed Sightrasher (WZ_SIGHTRASHER) splash area to 3x3. (bugreport:9298)
  * Now Comet (WL_COMET) cannot hits Hiding target (The mistake is not at flag 0x10000 in skill_db.txt, the flash should be added by SD_ANIMATION). (bugreport:8909).
  * Now Reading Spell Book (WL_READING_SB) checking the number of available spell books in Spell Book DB first to prevent infinite loop.
* Sage Skill
  * Now Abracadabra (SA_ABRACADABRA) checking the number of available skills in Abra DB first to prevent infinite loop.
  * Reduced MAX_SKILL_ABRA_DB from 350 to 160.
* Shadow Chaser Skill
  * Fixed Chaos Panic (SC_CHAOSPANIC) effect. (bugreport:9321).
* Genetic Skill
  * Now Wall of Thorn (GN_WALLOFTHORN) can be knocked back but not a whole skill group and durability (HP & max hit) for each skill unit.
* Guillotine Cross Skill
  * Now Magic Mushroom (SC_MAGICMUSHROOM) effect checks the number of available skills in Magic Mushroom DB first to prevent infinite loop.
  * Changed 'RemoveFlag' in db/magicmushroom_db.txt value to 1 to remove skill by importing. (bugreport:9322).
* Wanderer/Minstrel Skill
  * Now Randomize Spell (WM_RANDOMIZESPELL) checks the number of available skills in Improvise DB first to prevent infinite loop.
  * Reduced MAX_SKILL_IMPROVISE_DB from 50 to 30.
* Rebellion Skill
  * Cleaned up, added, corrected some (missing) sequences & DB values.
  * Fixed Hammer of God (RL_HAMMER_OF_GOD) splash damage.
  * Fixed Shaterred Strom (RL_S_STORM) push back & force to sit effect (for player, or stun for monsters) (first implementation leftover).
  * Fixed Slug Shot (RL_SLUGSHOT) hitrate-distance penalty (first implementation leftover).
  * Fixed Howling Mine (RL_H_MINE) damage ratios (first implementation leftover).
  * Now Bind Trap (RL_B_TRAP) only can be placed 1 at same time.
  * Fixed Bind Trap (RL_B_TRAP) damage calculation by using Caster's DEX, Target's Current HP, & Skill Level. FIXME: Exact formula still unknown (refers to idAthena formula).
  * Now Dragon Tail (RL_D_TAIL) doesn't split damage among targets anymore.
  * Now Crimson Marker (RL_C_MARKER) will fails to cast if no slot available.
  * Implemented official packet `ZC_C_MARKERINFO` of Crimson Marker (RL_C_MARKER) mini-map marker (first implementation leftover). !TODO: Confirm the packet for older or newer clients (idAthena partial merge r1497)
  * References: http://forums.irowiki.org/showpost.php?p=1387992&postcount=968, follow up 507f047, dd67f9d

Misc:
* Fixed some skills that should work only in shoot range (map_foreachinshootange, by default), and added check for respecting *skill_wall_check* (map_foreachinrange).
* Fixed item stackable check for `/item` command, follow up 9b4d922.
* Fixed npc source file isn't removed properly by @unloadnpcfile. (bugreport:9311).
* Added constantan for status_change_start() and sc_start() scripts as well
  * SCSTART_NONE = 0x0
  * SCSTART_NOAVOID = 0x1
  * SCSTART_NOTICKDEF = 0x2
  * SCSTART_LOADED = 0x4
  * SCSTART_NORATEDEF = 0x8
  * SCSTART_NOICON = 0x10
* Moved and changed itemdb_unique_id() to pc_generate_unique_id().
* Seperated check for skill SC requirement to skill_check_condition_sc_required().
* Added skill unit flag `UF_KNOCKBACK_GROUP`, just an option to make skill unit can be knocked back a whole group.
* Typos and other minor changes!

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-10-01 17:42:30 +07:00
Cydh Ramdh
c6ba813994 Bug Fixes:
* Wrong calls, should be callfunc. Thank @raynra
* Follow up 8256194, updated const.txt following new MAPID values for Super Novices
  * EAJL_SUPER_NOVICE	0x8000, for Super Novice masking
  * EAJ_SUPER_NOVICE	0x8100
  * EAJ_SUPER_BABY	0xA100
  * EAJ_SUPER_NOVICE_E	0xC100
  * EAJ_SUPER_BABY_E	0xE100

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-30 09:52:29 +07:00
Playtester
b64ef9258d Merged Pathfinding code cleanup from Hercules
(https://github.com/HerculesWS/Hercules/commit/78028c8)
* This fixes a problem where units sometimes walk diagonally through a wall server-sided; there should be less client desync now (but it might not be perfect yet)
* I kept the rAthena specific option path_blown_halt
* Special thanks to piotrhalaczkiewicz for the original implementation and aleos for helping me with the merge
2014-09-29 21:14:58 +02:00
aleos89
82561947e3 Bug Fixes
* Updated Napalm Vulcan damage to official. (bugreport:9297)
* Firing Trap should be removed immediately once it has detonated.
* Updated Expanded Super Novice ASPD values for weapons to match normal Super Novices.
* Updated Expanded Super Novice and Super Baby to be able to do anything normal Super Novices can do. Guardian Angel, Dori Dori, etc.
* Super Novices are able to equip any level 4 weapons of type Daggers, 1H Swords, 1H Axes, 1H Maces, and 1H/2H Staves while Soul Linked. (bugreport:2765, bugreport:5568)
* Reverted the Warlock elemental summons to not be limited per level from 237579c. All levels allow up to 5 summons.
2014-09-29 14:22:50 -04:00
Playtester
cfef8a0088 Rewrote the hard monster AI. Monsters will now behave a lot closer to official servers:
* Monsters will now attack immediately when they are chasing a target and it comes into attack range (bugreport:7370)
* Monsters will now chase their target during their aDelay, but they still have to wait for aMotion to be able to move again (bugreport:9269)
* Monsters will now rethink their chase in a configurable interval (see monster_chase_refresh in monster.conf), official value is once per cell, previously it was once per 3 cells
* Monsters will now stop when they rethink their chase and their target is gone (player hides or target loot was picked), regardless of the monster_ai setting (note: if you want the old, stupid behavior, just increase monster_chase_refresh instead)
2014-09-27 23:50:45 +02:00
aleos89
9a4f574d12 Follow up to a080117. Fixed compile error. 2014-09-20 11:51:23 -04:00
aleos89
a080117a74 Bug Fixes
* Switching arrows no longer stops attacks. (bugreport:9270)
* Looter monsters will now randomly pick items rather than going for the closest one. (bugreport:9268)
* Follow up to 0fed97c. Moved pc_setsit before skill_sit to not break skills that count players who are sitting. (bugreport:8966)
* Follow up to 2d2991a. Cleaned up some compile warnings.
* Updated the inf3 descriptions in the skill_db.
2014-09-20 11:44:44 -04:00
Cydh Ramdh
4f6448b23f Follow up 557aaa2
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-17 19:36:12 +07:00
Cydh Ramdh
c45cc6c177 Follow up 557aaa2, bugreport:9304
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-17 19:32:37 +07:00
Cydh Ramdh
557aaa237a Merge pull request #92 from nanakiwurtz/master
Item DB updates
2014-09-16 19:06:42 +07:00
Cydh Ramdh
929acd2ca6 Follow up 9b4d922, missing parentheses at 9b4d922#diff-85d990dde8caf2d72d1e2b0f7dcf9786R2254
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-16 11:18:37 +07:00
Cydh Ramdh
9b4d922ef4 Bug Fixes:
* Follow up 2d2991a, remove trailing spaces in inter_athena.conf
* Added `bound` field on `picklog` table (bugreport:9240) Thank @icxbb-xx (Napster)
* Fixed Randomize Spell infinite loop. Failure of skill improvise db reading. (bugreport:9288)
* Added **max_extended_aspd** for caping max ASPD for KO/Rebellion, default is 193. Pointed by @raynra & Ziu
* Mail attachment
  * Added `bound` field on `mail` table, since group with PC_PERM_TRADE_BOUNDED can put bound item into attachment
  * Fixed wrong data type causing wrong zeny amount (bugreport:9291)
* Fixed item color issue for bound item (bugreport:9238)
  * Stackable item shouldn't be displayed as yellow color
  * Equip doesn't shown as yellow after relog or item is moved
* Silence status immunity for Renewal (bugreport:9227)
  * Bleeding (SC_BLEEDING): Vit -> Agi
  * Silence (SC_SILENCE): Vit -> Int
  * Sleep (SC_SLEEP): Int -> Agi
  * Thank @Playtester, @Lilith-, partial merge of Hercules:6f26451
* Fixed status check when cast a skill to hidden target
  * Stone Curse shouldn't be casted to hidden enemy when the caster has intravision (bugreport:9266)
  * Added **INF3_HIT_HIDING** for skills that *maybe* have effect to/can hit the hidden target. Previously, every Earth Element skills *always* had it, doesn't matter ground skill or single-target skill
  * **!TODO: Confirm other skills that have ability for this!**
  * **!FIXME: For now, I rely as the previous check did, I put some Earth Element skills (and) with area/ground effect**
* Correcting Devotion behavior (Hercules:e7be725, 41f28c0)
  * Failing to cast Devotion to the 6th player
  * Only player who devotes other that 'shout' Auto Guard when it active also with the walk delay
  * Status icon that inherited from devoter won't be displayed at devoted player
  * Reflect Damage on devoted player won't reflect normal attack, only melee skill attack
  * Added config **devotion_rdamage_skill_only** for backward compability, ignore the behavior above

**IMPORTANT**
  * Please import sql-files/upgrades/upgrade_20140915_log.sql
  * Please import sql-files/upgrades/upgrade_20140915.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-15 18:02:49 +07:00
lighta
20ff69e5ce Merge pull request #96 from cydh/console/server-reloadconf
server:reloadconf
Look cute enough, 
Don't forget you need to have console enable in *_athena.conf to use it.
2014-09-11 21:43:43 -04:00
Lighta
f703f591dc Merge branch 'master' of https://github.com/rathena/rathena 2014-09-10 18:08:23 -04:00
Lighta
82bb9b1f2f Fix and update Cmake build.
Update config.pl
2014-09-10 17:46:11 -04:00
Cydh Ramdh
7cac20850e * Added console command for login & char server 'server:reloadconf' to reload some config values on login_athena.conf & char_athena.conf
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-10 18:02:55 +07:00
Cydh Ramdh
8bdea5ddef * Updated packet documentation for
* Auction packets (IZ)
  * Homunculus packets (IZ)
  * Mail packets (IZ)
  * Pet packets (IZ)
  * Quest packets (IZ)
  * misc
* Inter-server updates
  * Possible send wrong packet length for pincode and wispher to GM (@request)
  * ShowInfo if player change pincode
  * Showinfo "Asking to start pincode ..." only when 'pincode_enabled: yes'

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-10 13:05:07 +07:00
lighta
7bedf4353b Add gdb check for configure suggestion on bugreport:4645.
Add the missing update in infinite_warp.txt
2014-09-07 09:01:19 -04:00
lighta
3a88e8cf39 Follow up ea8ccfc82e91efb9fc1be3d3397d538d80101c84
-Update message with Euphy suggestion.
-Add new test case.
-Fix **bugreport:9278** (infinte-warp-1ma-h-cpu-usage-100)
2014-09-07 08:30:10 -04:00
Lighta
f8f6a1f101 Fix teleport typo cuasing some crashs.
Fix sql backward rules for makefile
2014-09-03 18:49:15 -04:00
aleos89
531b89e6b0 Follow up to 2d2991a. Fixed the set property function for login_codepage and login_case_sensitive configs. 2014-09-03 17:59:33 -04:00
aleos89
2d2991a1fd TXT reference removal from emulator.
- Removed any remaining TXT and SQL references from files.
- The 'make sql' command is now replaced by 'make server'.
- Removed account.engine feature as it is no longer needed.
- Moved login and IP ban configs to inter_athena.conf.
- Cleaned up cmake files.
- Miscellaneous clean ups.
2014-09-03 17:44:35 -04:00
Euphy
3c24f458ce Hunting Missions script update.
- Added check for deleted characters. (credits: @AnnieRuru)
- Modernized script syntax and improved readability.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-09-01 13:33:39 -04:00
nanakiwurtz
9bde9dc706 Item DB updates
-- kRO 2014-07-09
-- kRO 2014-07-16
-- kRO 2014-07-23
-- kRO 2014-07-30

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2014-09-01 02:18:50 +07:00
Euphy
403c22bc4b Documentation cleaning.
- Formatting and grammar edits on recently added docs.
- Added missing NPC header and script conf include from ea8ccfc.
- Moved ER model files to a separate folder ('doc/model/').

Fixed a typo in Wolfchev instance. (bugreport:9263)
http://rathena.org/board/tracker/issue-9263-wolfchevlaboratory-script-error/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-31 12:09:38 -04:00
Euphy
ea1a247f99 Minor Renewal mob database updates. (Hercules 0fadf38)
- Some name changes.
- Enabled some previously disabled mobs (unused).
- Added mob IDs 2402~2403, 2924~2936.

Other changes:
- Changed 120 stat equality check to inequality for two items. (bugreport:9261)
http://rathena.org/board/tracker/issue-9261-bradium-brooch-bonus-if-agi-120/
- Follow-up 7cd82d0: updated data sizes in convert_sql tool.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-30 22:06:01 -04:00
lighta
ea8ccfc82e Add rewarp_count counter to prevent infinite warp loop.
bugreport:9130 (cpu-usage-goes-to-100)
2014-08-29 16:05:41 -04:00
aleos89
977797e503 Follow up to f077a8e. Fixed compile errors. (bugreport:9252) 2014-08-26 22:33:38 -04:00
aleos89
f077a8eb03 Follow up to c0ed836.
- Optimized SQL structure to better fit uint32 value for uniqueitem_counter. (bugreport:9249)
- Added font and uniqueitem_counter to load when loading character menu on char-server.
2014-08-26 16:35:58 -04:00
Cydh Ramdh
51ecd9b2bc Follow up 402170c
- Added 'ID' as identifier/index for produce_db and skill_changematerial_db to avoid 'rewriting' product result with different materials. As we can see there 'Starsand_Of_Witch' can be produced by (1) 10 Insect Feeler + 15 Blue Porcelain or (2) 100 Moth Dust + 100 Scell.
- Map-server crashed issue while @reloadskilldb. Some counters aren't zeroed on skill_readdb() makes array overflow. (bugreport:9241, bugreport:9243)
- Allowing import file to remove original entry by put certain value. See the changed db files for more details.
- Relying to skill_spellbook_db for listing available book as spell book. For Warlock skill Reading Spellbook (WL_READING_SB).

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-08-24 21:58:23 +07:00
Euphy
30b4d578a7 Some script cleaning.
- Replaced lots of numerics with constants.
- Added spacing to make some scripts more readable.

Fixed a mistake in 14fddd3.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-23 15:17:59 -04:00
Euphy
2acf9a401a Fixed item script for Glorious Holy Avenger. (bugreport:9244)
http://rathena.org/board/tracker/issue-9244-9-glorious-holy-avenger/

Script command 'preg_match' will throw a debug instead of an error if PCRE is not enabled.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 23:56:08 -04:00
aleos89
4ffe723d8c Merge branch 'master' of https://github.com/rathena/rathena 2014-08-22 17:52:28 -04:00
aleos89
c0ed836e87 * Changed how the Unique ID System saves and creates IDs for items. (Hercules dd49dbc)
- System is now enabled by default.
- All non-stackable items that previously existed will get unique IDs if items::item_check is enabled.
- Added 'getequipuniqueid' script command to get the unique ID of an equipment on a player.
- Don't forget to apply the SQL update!
* Renamed SQL update file that applied to logs.
2014-08-22 17:52:15 -04:00
Euphy
3b2762ca3c Enable NPC logging through 'logmes' by default.
- Commented some unnecessary log messages.

Bug fixes:
- M_DOPPELGANGER had too much HP. (Hercules 9cd3ec0)
- Huuma_Swirling_Petal should not have an element. (bugreport:9073)
http://rathena.org/board/tracker/issue-9073-huuma-swirling-petal/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 16:06:32 -04:00
Euphy
617b9830af Merge branch 'master' of https://github.com/rathena/rathena 2014-08-22 15:36:37 -04:00
Euphy
14fddd3790 Added script checks against swapping items using third-party hacks.
- Follow-up to 416f6d7, as further protection against item exploits.

Contains a few other fixes.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 15:36:23 -04:00
Cydh Ramdh
416f6d7ba8 - Added error messages for some script commands
- Halt script if no item equipped for 'delequip' just like 'delitem' does

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-08-23 01:47:30 +07:00
Cydh Ramdh
4fd7e46345 Follow up 70b8b8b, an error for PRE-RE
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-08-22 23:42:13 +07:00
Cydh Ramdh
70b8b8bc38 Bug Fixes:
- Fixed map-server crashed caused by Wall of Thorn when atatcked by Fire element (with wide range skill unit, bugreport9102). Also reverted some changes in c046668
- Added config conf/battle/skill.conf 'arrow_shower_knockback', as follow up 453b6d0. Direction of Arrow Shower knockback depends on Arrow Shower location

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-08-22 23:28:48 +07:00
lighta
402170c018 -Update doc/souce_doc.txt for refactoring change
-Add doc/packet_interserv.txt and doc/packet_client.txt, to refer packets
-Upd src inner documentation, map/intif mostly
-Add  common::utils::check_filepath(), fixing bugreport:9131 @loadnpc crash
-Fix pc_level_penalty_mod not using mob_class correctly
-Fix db/import/ for produce, arrow, abra, impro db...
-Upd install script (config.pl) to use mariadb for fedora/centos distrib
2014-08-20 20:58:48 -04:00
Cydh Ramdh
3efe5375f3 - Added check to clear skill unit group that created by NPC/script before the NPC/script unloaded.
- Changed enum for NPC subtype, added prefix NPCTYPE_. See map.h::npc_subtype.
- Changed Channel_Config struct usage to -> extern struct Channel_Config channel_config.
- Added restriction for atcommand that cannot be executed when Player is in autotrade, to prevent map crash. (bugreport:9196) TODO: Check other atcommand or change this behavior.
- Added enum for atcommand restriction with prefix ATCMD_NO. See atcommand.c::e_atcmd_restict.
- Updated atcommand documentations.
- Changed dummy_sd's attributes to group_id & group_level 99, and gives all permissions (PC_PERM_ALLPERMISSION). dummy_sd is being used by 'atcommand' or 'useatcmd' script when no rid/player attached.

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-08-18 19:59:16 +07:00
Euphy
880903bdab Updated Renewal Izlude Magazine & Bullet dealer locations.
- Coordinates taken from a recent iRO update.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-17 15:13:24 -04:00
Euphy
17bace0ae6 Script bug fixes.
- Added Renewal location for "Knight De Thomas" NPC (previously inaccessible), and upgraded the script to the latest version.
- Fixed Pre-Renewal Merchant Quest questlog commands. (bugreport:9218)
http://rathena.org/board/tracker/issue-9218-merchant-quest-add-error-quest-add-1010/
- Corrected a handful of 'rand(1)' statements.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-16 19:10:19 -04:00
aleos89
191f65bdcd Merge pull request #94 from anubisK/else_correction
Follow up to adabedb. Preprocessor cleanup.
2014-08-16 18:35:05 -04:00
aleos89
25969358e4 Merge branch 'master' of https://github.com/rathena/rathena 2014-08-16 16:16:40 -04:00
aleos89
60b0ed9c8b Bug Fixes
* Fixed mouse cursor displaying incorrectly for PvP scenarios. Thanks to Napster. (bugreport:8605)
* Fixed summons getting stuck when master gets too far off screen or changes maps. (bugreport:9152)
* Added a battle_config 'spawn_direction' for keeping a  character's face direction when teleporting/changing maps/logging in. Default is always North (official). (bugreport:8754)
* Cast sensor mobs should always target the caster whenever any skill is used. (bugreport:8555)
* Added a packet version check to char_del_option based on client date. (bugreport:8521)
* Script command query_sql will now return -1 on an empty result or failed result. (bugreport:5937)
2014-08-16 16:15:50 -04:00