2131 Commits

Author SHA1 Message Date
Cydh Ramdh
09b2ea06ee * Refactor pc_setparam for SP_BASEEXP and SP_JOBEXP.
* Added script command `getexp2` for safety usage of `set BaseExp,n;` and `set JobExp,n` usages.
* Cleanup exp lost functionto `pc_lostexp`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-20 12:31:44 +07:00
aleos89
daa9e018f4 Release of Doram Race!
* Requires client 2015-10-01 and newer.
* All skills are usable from from the base list to all 3 branch types.
-- Some skills still need their official activation chance and durations.
* Adjusted the char-server start point and start item split functions to be more dynamic.
Thanks to Rytech and @NovaRagnarok for their information!
2016-03-19 14:09:30 -04:00
Playtester
1ca9fb58f2 Decrease Agi, Adoramus (fixes #1067)
* The chance of Decrease Agi and Adoramus is now reduced by a fixed 1% per MDEF
* Decrease Agi can now overwrite itself with a lower level
* The base chance to cause blind when Adoramus activates is now 1000%
* Adoramus now has a blind duration of 7s+1s*level and an Adoramus duration of 10s+5s*level for both players and monsters
* Adoramus and Decrease Agi cancel each other out
* Adoramus no longer reduces speed (only AGI reduction and blind)
* Adoramus no longer cancels ASPD/Speed increasing buffs
* Adoramus can no longer be blocked/canceled by ASPD/Speed increasing buffs
* When Adoramus ends, it will no longer automatically end blind at the same time
2016-03-18 23:06:29 +01:00
aleos89
a021829cda Fixed Epiclesis interval checks (fixes #1066)
* Epiclesis will now properly check for hidden players every 5 seconds.
* Adjusted the skill unit interval to check every second rather than every 3 seconds.
2016-03-18 13:38:12 -04:00
Playtester
aa6a1110bd Arrow Shower and Arms Cannon (follow-up to 7906f0a)
* Fixed Arrow Shower not hitting Traps and Icewall in pre-renewal
* Arms Cannon can no longer hit Traps and Icewall (see #1056)
2016-03-17 21:24:37 +01:00
Cydh Ramdh
f31475d5e3 Merge pull request #986 from rathena/feature/pk_traps_setting
Trap Invisibility, Fixes #892
* Changed `traps_setting` config values.
  * 0 = Always visible (default)
  * 1 = Enable invisibility in versus maps (GVG/PVP/BG)
  * 2 = Enable invisibility in all maps
* Added skill unit flag `UF_HIDDEN_TRAP = 0x20000` for trap invisibility. By default, there are (renewal) Hunter traps with this flag:
  * HT_SKIDTRAP
  * HT_LANDMINE
  * HT_ANKLESNARE
  * HT_SHOCKWAVE
  * HT_SANDMAN
  * HT_FLASHER
  * HT_FREEZINGTRAP
  * HT_TALKIEBOX
* Added some skills and effects that can reveal hidden traps. By default, Detect, Sight, Ruwach, and Improve Concentration can reveal hidden traps.
2016-03-17 05:45:27 +01:00
Playtester
b5de854b90 Snap, Ganbantein, Gravitational Field, Flying Kick (fixes #1052)
* Snap now has a server-sided range of 14
* Snap, Ganbantein and Gravitational Field will no longer cause you to move if you target a cell out of range
* Snap and Flying Kick will now check for obstacles on a linear path rather than on the normal walkpath
* Range specified in skill_db is now equal to the client-sided range
* Some range code cleanup
2016-03-13 16:42:46 +01:00
Playtester
a6f73a6227 Status changes that cause damage reworked (fixes #1033, fixes #448)
* Created a better structure for status changes with intervals and integrated the status changes Stone, Poison, Deadly Poison, Bleeding, Magic Mushroom, Burning, Pyrexia, Leech's End and Toxin into the new structure
-- The exact remaining duration of these status changes will now be stored
-- The correct duration is reloaded when logging back in, you can't avoid a single tick be re-logging
-- It will now show the correct duration on the icon of the status change after re-logging, no longer negative values
-- The durations are now accurately transferred when using Deadly Infect
-- These status changes now use unified code, which makes it much easier to integrate more status changes into this structure with low risk of breaking something
* Removed all the status change specific logging of damage and integrated it into the normal logging behavior
-- The following skills deal "No source" damage: Stone, Poison, Deadly Poison, Bleeding, Coma, Magic Mushroom
-- The following skills deal "Self" damage: Burning, Pyrexia, Leech's End, Toxin
-- "No source" will neither be logged nor contribute to the total damage, your exp share doesn't increase from the damage, but it also won't cause the monster to give less EXP, it won't break freeze or similar status changes, it won't make you stand up, it won't make you stop moving, it won't prevent you from logging out
-- "Self" damage will now be logged and contribute to the total damage, it makes monster give the exp tap bonus, but also makes monsters give less exp the more "self damage" they've taken, it will break freeze and similar status changes, it will make you stand up properly now, it will make you flinch and stop moving, it will prevent you from logging out, but angry type monsters will not lose their aggressive bit from it and it will not cause monsters to use their rude-attack skill
-- Monsters will now use their rude-attack skill on the first rude-attack as long as the damage does not come from self
-- When a monster takes damage from a status change, its HP meter will now be updated
* Burning now has an interval of 3s and a minimum duration of 10s
* Pyrexia now causes blind for Pyrexia's duration instead of just 30s
* Ground Drift's poison base duration is now 60s in pre-re (follow-up to e7150ee)
* Fixed a bug where the minimum duration failed to apply when the received duration was below 1ms
* map_foreachindir and map_foreachinshootarea will now properly print their function names in case of an error
* Updated documentation (transferring source ID is no longer required, remaining tick should now always be in val4)

If this breaks anything, please report asap.
2016-03-12 16:50:50 +01:00
aleos89
0fb78d45b7 Corrected Tiger Cannon splash damage (fixes #1020)
* The splash damage now factors in resistances from the splash targets.
2016-03-09 13:32:49 -05:00
Playtester
80e026433f Official status change base durations for Stun (fixes #1019)
* NPC_LICK now has a base chance of 20%*level and a base duration of 5s
* Excruciating Palm now has a base duration 5s
* Shield Press now has a base duration of 5s+0.5s*level
* Earth Shaker now has a base duration of 2s (level 2-3) and 3s (level 4-5)
* Blind follow-up: Sightless Mind now has a base duration of 30s in pre-re and 20s in renewal
2016-03-06 19:46:45 +01:00
Playtester
e7150ee936 Gunslinger Mine / Ground Drift (fixes #998)
* Fixed knock back being 6 tiles instead of 3
* Stun duration is now 5 seconds
* Blind / Silence durations are now 30 seconds (pre-re) or 20 seconds (re)
* The damage is now delayed by aMotion; as the status effect kicks in immediately, damage will break Freeze
* The base chance for a status change is now 50% instead of 5%
* It is now a weapon skill, damage% increase/reductions are now considered, in renewal the skill can completely miss
* Damage in pre-renewal is 100% + fixed damage of 50*level
* Damage in renewal is 200%+20%*level
* Fixed sphere attack not being considered in the damage formula
* The ground effect disappears immediately after activation now
2016-03-06 12:09:46 +01:00
Playtester
7906f0a3ff Line of Sight System updated (fixes #937, fixes #994)
* You can now target walls with ground skills
* Updated path check to not check the last cell
* Unit skills will now place units depending on line of sight to the caster rather than the cast center
* Implemented a new algorithm that retrieves all units in an area that are in line of sight with the area center
* Arrow Shower, Dragon Breath, Cold Slower, Wind Cutter and Arms Cannon now use the new algorithm (Arrow Shower is no longer a unit skill)
* Nodamage skills will no longer fail when the target walked around a corner
* The following damage skills will no longer damage through walls: Raging Thrust, Tornado Kick, Splash Attack, Venom Splasher, Fireball, Meteor Assault, Desperado, Spread Attack, Pulse Strike, Hell's Judgment, Vampire Gift, Magnum Break, Sightrasher, Frost Nova, Explosion, Self Destruction, Firing Trap, Icebound Trap, Cluster Bomb, Claymore, Fire Pillar
2016-03-05 18:02:22 +01:00
Playtester
2b7eb9f523 Follow-up to ecb01c4 (Angry mode)
* When monsters switch modes from or to angry mode, the aggressive bit will now be set properly
2016-03-04 21:40:38 +01:00
Playtester
61a48b9b0b Jack Frost, Status Traps, Stone Fling, Leap, Cannon Spear
* Fixed status base chances of Jack Frost and Status Traps (fixes #997)
-- Jack Frost: 200% freeze chance instead of 100%
-- Land Mine: 10% stun chance instead of 35%-55%
-- Flasher: 100% blind chance instead of 40%-80%
-- Freezing Trap: 100% freeze chance of instead 38%-50%
* Sandman Sleep and Throw Stone Blind base duration is now 30s in pre-re and 20s in renewal
* Leap now has a shorter distance when used diagonally (fixes #1007)
* Cannon Spear now shows the skill animation even if it doesn't hit anything (fixes #1004)
2016-03-03 22:11:41 +01:00
Cydh Ramdh
20588abcd8 Merge pull request #987 from rathena/feature/exp_max_level
EXP on Max Level
* Fixed #942
* 'Last' EXP for max base level is 99,999,999 and 999,999,999 for Job EXP on max job level.
* Player still obtains EXP on max level (of course until both base & job reach 100%).
* This behavior is used for Base EXP check for:
  * Super Novice's Explosion Spirit.
  * Royal Guard's Inspiration.
  * High Priest's Redemptio.
* Added config `death_penalty_maxlv`, default is set to 0. Player on max level, never loss EXP by death penalty.
* On EXP lost by death penalty. EXP will be shown as negative value.
* Fixed check for EXP value on packet `0x07f6`. EXP is limited to INT_MIN until INT_MAX by client (so don't expect client to displays value more than this!)
* Added EXP gained/lost message by `@showexp` on death penalty too.	
* Fixed PR_REDEMPTIO and LG_INSPIRATION requirement  …
  * Only charge the Base EXP.
  * Lost EXP will be displayed
2016-02-29 21:05:45 +07:00
Cydh Ramdh
dc679b8c06 Follow up d9a35c8c6a7c08d5397647cb0ae470bd5692898d
* A little check to avoid unnecessary process.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-29 19:50:24 +07:00
Playtester
b3b3e9cc71 Official status change base durations for Silence and Stone (fixes #990)
* The renewal default duration for Silence is now 20s (30s in pre-re)
* Items, NPC_SILENCEATTACK and NPC_WIDESILENCE and monster Lex Divina use the default silence duration
* Incubation time for Stone is now subtracted from the Stone duration
* Incubation time is now 100ms for all Stone skills except Stone Curse (5 seconds)
* The Stone timer is now more exact and now deal 1% HP damage exactly every 5 seconds, even if it's on the last tick
* Fixed Sienna Execrate missing its skill animation
2016-02-28 17:37:41 +01:00
Playtester
ec59446043 Official status change base durations for Freeze and Blind (fixes #988)
* Snowflake Draft now has a skill-specific duration of 5s*level
* All freeze durations (default and skill-specific) are increased by 2.5s in renewal
* The renewal default duration is now 27.5s (+2.5s)
* Items, Storm Gust, Frost Joke, NPC_ICEBREATH and NPC_WIDEFREEZE use the default freeze duration
* All items and skills that cause blind now have a base duration of 30s in pre-re and 20s in renewal
* Fixed NPC_DARKCROSS and NPC_GRANDDARKNESS not giving the blind status change
2016-02-28 01:03:14 +01:00
aleos89
1b9a0b5af5 Updated Kyomu effect and Magic Reflection effect
* All skills have a chance of failing at 25%, not just Shield Reflect and Reflect Damage.
* Kaite, Magic Mirror, and Shield Spell - Defense are not nullified by Kyomu.
* Item-based and Magic Mirror reflection damage Boss monsters, Kaite does not.
2016-02-26 18:33:07 -05:00
Playtester
7cfdd9ddef Pre-renewal Impressive Riff (fixes #111)
* Fixed the pre-renewal ASPD bonus being almost double as high as officially
* Follow-up to 13d1c2d
2016-02-25 19:06:58 +01:00
aleos89
473e7f8fa5 Fixed compile warnings
* Follow up to 03fab34.
2016-02-24 13:48:33 -05:00
aleos89
03fab34fa3 Updated wall checks for some 3rd class skills
* Wind Cutter, Cold Slower, Arms Cannon, Dragon Breath, Dragon Breath - Water, and Arrow Storm will no longer damage targets around walls.
2016-02-24 13:31:36 -05:00
Cydh Ramdh
9944c1dd46 Fixed PR_REDEMPTIO and LG_INSPIRATION requirement
* Only charge the Base EXP.
* Lost EXP will be displayed.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-24 12:26:04 +07:00
Playtester
c144febc30 Elemental Resist Potions vs Dispell (fixes #977)
* The status effect from Elemental Resist Potions can no longer be removed by "Dispell"
2016-02-23 18:07:27 +01:00
aleos89
d512f1588c Refactored Monster Mode
* Refactored all monster mode checks to use the enum e_mode.
* Created elemental_skillmode enum to separate usage from monster mode enum.
* Renamed EL_SKILLMODE_PASIVE -> EL_SKILLMODE_PASSIVE.
* elemental_change_mode() will now return the proper value from elemental_change_mode_ack().
2016-02-23 11:21:45 -05:00
Cydh Ramdh
d9a35c8c6a Follow up 51c422cf7cc9e6046886ec89cb9cec07c9cb0d3e.
* Added some skills and effects that can reveal hidden traps.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-22 23:33:27 +07:00
Cydh Ramdh
51c422cf7c Corrected trap invisibilty behavior.
* Changed `traps_setting` config values.
  * 0 = Always visible (default)
  * 1 = Enable invisibility in versus maps (GVG/PVP/BG)
  * 2 = Enable invisibility in all maps
* Added skill unit flag `UF_HIDDEN_TRAP 0x20000` for trap invisibilty.

NOTES:
* Invisible traps are always visible for the trapper and trapper's partymates.
* If the trap is invisible, it always be hid immediately (except the people above).
* Revealed hidden traps, are always visible by everyone.
* Currently, only `HT_DETECTING` that can reveal the hidden traps (hardcoded). TODO: Sight, Ruwach, and Improve Concentration also able to reveal hidden traps.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-22 22:34:08 +07:00
aleos89
2ad4972be8 Corrected Moon Slasher effect
* Now able to stop Boss monsters.
* Has a random duration of 1~3 seconds.
Thanks to @Playtester!
2016-02-22 09:14:54 -05:00
Playtester
3449b67abc Follow-up to 8d20393 and a63b031
* Thunder Storm, Exploding Dragon, Lightning Jolt and Snowflake Draft can now damage more than just once every 500ms
* Fixed a problem with negative aftercast delay
2016-02-21 19:34:34 +01:00
Playtester
a63b031958 aMotion delay is now set at cast begin (fixes #944)
* When casting a spell with cast time shorter than aMotion, the delay will now be set to aMotion or min_skill_delay_limit
* aMotion and min_skill_delay_limit are no longer applied at cast end nor by auto spells
* Aftercast delay can only increase the delay and never decrease it
* When there is no aftercast delay, the client will no longer show a non-existent 10 second delay
* Removed "double cast" code of Jupitel and Waterball, it's no longer needed as it fits into the official delay system
* Added a constant SECURITY_CASTTIME, which is added at cast begin and subtracted at cast end to prevent hackers to send in skill packets before the timer triggers cast end
* Set skill_amotion_leniency to 0 by default as it applies delay at cast end and would consequently block the official system from working; you can set it back to 90 or even 140 for increased security
2016-02-21 17:06:39 +01:00
aleos89
f264885411 Follow up to 7c5bda2
* Corrected the Flash Combo bonus ATK not being applied to the caster and not displaying in the status window.
* Corrected Sky Net Blow not casting at the end of Flash Combo if the target is dead.
2016-02-21 09:53:05 -05:00
Cydh Ramdh
70a67d6c57 Official EXP on Max Level
* Fixed #942
* 'Last' EXP for max base level is 99,999,999 and 999,999,999 for Job EXP on max job level.
* Player still obtains EXP on max level (of course until both base & job reach 100%).
* This behavior is used for Base EXP check for:
  * Super Novice's Explosion Spirit.
  * Royal Guard's Inspiration.
  * High Priest's Redemptio.
* Added config `death_penalty_maxlv`, default is set to 0. Player on max level, never loss EXP by death penalty.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-02-21 18:43:24 +07:00
Playtester
4c1c6e6d2f Merge branch 'master' of https://github.com/rathena/rathena 2016-02-20 21:42:01 +01:00
Playtester
8d20393b10 Ninja Skills vs Land Protector (fixes #971)
* Exploding Dragon, Lightning Jolt and Snowflake Draft are now unit skills
-- They no longer can deal damage on Land Protector
-- They will deal damage instantly, regardless of your ASPD
* Exploding Dragon now deals 150%+150%*level damage divided by number of hits, it can no longer damage plants
* Snowflake Draft's freeze base duration is now 2500ms+5000ms*level
* Renewal: Lightning Jolt's AoE is now 3x3 on level 1-2, 5x5 on level 3-4 and 7x7 on level 5
* Pre-Renewal: Cast time of Wind Blade level 8-10 is now 500ms shorter
* Watery Evasion now makes non-Ninja enemies stop when they walk on it and are not knock-back immune
2016-02-20 21:41:01 +01:00
aleos89
10b57568ee Corrected Sniper Trap behavior
* Cluster Bomb and Ice Bound Trap now have a 1 second delay after activation.
* Firing Trap is now activated immediately.
Thanks to @Tokeiburu!
2016-02-20 08:16:31 -05:00
Playtester
cac5b3cb1d Monster level 10 skills (Part 3), Fire Pillar, Storm Gust (fixes #973)
* Monster level 10 Frost Diver now deals 500% damage and has a 100% freeze base chance
* Added the remaining explanations and corresponding rAthena level to mob_skill_db_powerskill.txt, now all powered-up skills are listed
* Damage of Fire Pillar is now multiplied by number of hits when used by monsters
* Storm Gust's freeze duration is now 30 seconds in renewal
2016-02-19 23:25:05 +01:00
Playtester
2c3cb602dc Blaze Shield slowdown, Sanctuary knock-back (fixes #963)
* Blaze Shield now properly slows down enemies while still making sure they take all the hits while moving over a fire cell
* Fixed some skills still having damage delay, even though their source is a unit (BL_SKILL)
* Sanctuary knock-back is now 2 cells instead of 1 and pushes "away from cell center of each cell", similar to Storm Gust
2016-02-18 18:42:13 +01:00
aleos89
9f0ae12824 Fixes #863
* Striking now takes the target's weapon level into account.
* Now displays the proper skill fail message when used on wrong targets.
2016-02-17 10:49:18 -05:00
aleos89
cff0c35662 Fixes #919
* Marsh of Abyss was removing the wrong status change for Increase Agility.
* Moved the skill to the proper switch to get rid of unused values.
2016-02-16 10:41:51 -05:00
aleos89
7c5bda2978 Updated Flash Combo effect
* Clean up of revert fc68007.
* Removes SR_FLASHCOMBO_ATK_STEP# skills. Packet dump shows these skill IDs are not used.
* Fixes damage calculation for Tiger Cannon and Skynet Blow.
* Tiger Cannon is now passed as a neutral elemental attack.
* Tiger Cannon now properly removes 10% of damage done to target instead of 10% of max SP.
* Skynet Blow now properly casts at the end of Flash Combo.
* Updated the range for Dragon Combo, Fallen Empire, and Tiger Cannon to 1.
Thanks to @RagnarokNova and @Lemongrass3110 for packet information!
2016-02-15 18:12:53 -05:00
aleos89
1df18a4a78 Compile Warning Cleanup
* Resolves some warnings from the gcc compiler.
2016-02-14 09:10:42 -05:00
Playtester
bd5911abb5 Monster level 10 skills (Part 2), Magnum, Brandish (fixes #958)
* The following monster level 10 skills now have their official effect
-- Brandish Spear: 5x5 line of damage. 562% damage to all cells.
-- Magnum Break: 9x9 AoE. 600% damage to all cells.
-- Mammonite: 1200% damage.
-- Fireball: Renewal: 1020% damage. Pre-renewal: 510% damage.
* Added explanations and corresponding rAthena level to mob_skill_db_powerskill.txt
* When used by monsters, Brandish Spear and Magnum Break now always deal full damage, independent of distance
2016-02-14 13:01:52 +01:00
Playtester
7a62ab49dc Monster level 10 skills (Part 1), LoV (fixes #957)
* The following monster level 10 skills now have their official effect
-- Two-Hand Quicken: Increases ASPD by 70%. Duration 300s.
-- Lord of Vermilion: Deploys units in a 15x15 area that splash 1 cell into LP each. 520% damage per wave.
-- Thunderstorm: 20 Hits, 7x7 AoE. Splashes 3 cells into LP.
-- Decrease Agility: Reduces Agi by 50. Duration 130s.
-- Hammer Fall: 25x25 AoE. 100% base stun chance.
* Added a document that will contain all information on these special level 10 monsters skills
* Implemented official damage formula for renewal Lord of Vermilion; it only applies to LoV cast by players
2016-02-13 11:50:12 +01:00
aleos89
c9fde7655c Updated Illusion - Death effect
* Curse duration is not reduced by VIT.
* Cannot kill the target when lowering HP.
2016-02-12 09:21:12 -05:00
Playtester
e3667f4a07 Fixed boss monster skills being completely random (fixes #951)
- Boss monster skills no longer will have a random element
- Fixed boss monster skills being significantly weaker than they should be
- Prepared layout defines for upcoming MVP skill fixes
- Increased MAX_SKILLTIMERSKILL to 50 as this is maximum number of meteors you can have "in store" officially
2016-02-11 20:34:36 +01:00
aleos89
b9cce000bf Follow up to a7de6f8
* Fixed a compile error.
2016-02-11 11:06:59 -05:00
aleos89
a7de6f8f63 Updated Wedding Skills effect
* Male max HP required increased from 10% to 15%.
* Female max SP required increased from 10% to 15%.
-- These changes only affect renewal mode.
2016-02-11 09:54:25 -05:00
aleos89
bddb3fb3b3 Fixes #708
* Follow up to 4f4d8fe.
* Dispell is now usable outside PvP in Duels.
* Dispell is now usable outside PvP in the caster's party.
2016-02-09 10:12:32 -05:00
aleos89
744aed55e3 Updated Madogear effect
* Canto Candidus can now increase the agility of Madogear-ed players in the party.
* Heal, Increase Agility, Decrease Agility, Dispell, Renovatio, and Highness Heal now display the correct skill fail message.
2016-02-08 10:34:56 -05:00
Playtester
f5ea1dcb3e Several no-damage status change skills updated
* Scream and Frost Joke (fixes #945)
-- The delay until the status change kicks in was increased from 2s to 3s
-- Aftercast delay in pre-renewal was increased from 3s to 4s (already 4s in renewal)
-- Duration of Freeze from Frost Joke increased from 10-14s to 30s
* Hammer Fall, Lex Divina and offensive Status Recovery (fixes #945)
-- A delay of 1 second until the status change kicks in was added
-- Hammer Fall will hit the targets that are in the AoE before the delay (so you can't dodge)
-- Offensive Status Recovery's base duration reduced from 30s to 20s and base chance increased to 100%
-- Increased the maximum number of skill timers from 15 to 40 as they are needed for delayed status changes
* Stone and Freeze now remove Lex Aeterna (fixes #947)
-- For stone this refers to the second phase
* Scream, Frost Joke and Hammer Fall no longer make a target stop (fixes #948)
-- Similar behavior to e.g. Ankle Snare against bosses or in WoE
-- If the target was singing/dancing, it will still stop and the song/dance will be canceled
-- Fixed a bug that caused position lag when targets that are still moving but can't move anymore are hit
2016-02-07 18:58:53 +01:00