2131 Commits

Author SHA1 Message Date
aleos89
31c5914bb2 Updated Stasis effect
* Fixes #830 and fixes #918.
* All players within the skills range (depending on level) are effected by Stasis.
-- Resolves issue with players behind walls not being effected.
* Duration is now 10 + (10 * skill_lv) seconds with a minimum of 10 seconds after being reduced by VIT + DEX.
* Status Recovery now removes Stasis and White Imprison.
* All players effected by Stasis are unable to cast any skill except Status Recovery, Dispell, Clearance, and Banishing Buster.
2016-02-03 15:16:23 -05:00
Playtester
6ad062f6e3 Official line of damage path algorithm (fixes #658)
* Implemented the official line of damage algorithm that official servers use; it will calculate the direction between caster and target and apply one of eight possible AoEs
* Added a config setting with which you can switch back to the custom emulator path algorithm
* Updated Brandish Spear(5x5), Focused Arrow Strike(13x3), First Wind(5-9x3), NPC Breath attacks(14x7), Flame Launcher(5x3) and Cannon Spear(11x3) to use this algorithm and corrected range, splash and maxcount values for all these skills
* Fixed Brandish Spear's AoE being completely wrong and having holes in its AoE when attacking diagonally; also fixed the knock back being 3 instead of 2 and not working at all for the longest reach; Brandish Spear's AoE width and length can now be defined in skill_db.txt
* Focused Arrow Strike, First Wind and NPC breath attacks will at least hit one target, if no enemy is on the AoE, the target will be hit instead; Brandish Spear, Flame Launcher and Cannon Spear can completely miss
2016-02-02 23:41:05 +01:00
aleos89
79229c83c5 Follow up to 77e9eff
* Resolves compile warnings from the revert.
2016-02-02 11:58:47 -05:00
aleos89
77e9eff40d Revert "Updated Flash Combo effect"
This reverts commit fc68007.
2016-02-02 11:37:45 -05:00
aleos89
79d6eb29ee Compile Warning Cleanup
* Resolves some warnings from the gcc compiler.
2016-01-30 11:47:03 -05:00
aleos89
fc6800701b Updated Flash Combo effect
* Includes fixes for Dragon Combo, Fallen Empire, Tiger Cannon, and Sky Net Blow.
* Removed the SR_FLASHCOMBO_ATK_STEP usage.
* Fixes #627, fixes #725, fixes #741, and fixes #765.
Thanks to @exneval and @Rytech!
2016-01-29 11:15:00 -05:00
aleos89
497cca198e Updated Chorus skill type effect
* Fixes 921
* Chorus skills now work as long as another performer is in the same party and on screen as the caster -- no longer has to be adjacent to caster.
2016-01-27 09:58:17 -05:00
Cydh Ramdh
dddc313c7d Clean up usage of unit_movepos and GVG/BG mpa checks on skill.c.
* Follow up 5afc620e740f03775b36925cb187b7d54124274a, 45936c7dc607f25ce3c7a33020aa691176978b73

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-27 13:03:05 +07:00
aleos89
5afc620e74 Updated Illusion - Bewitch effect
* Positions are not swapped on GvG/Battleground maps.
* Confusion is applied no matter the map type and ignores status resistances.
2016-01-26 14:40:01 -05:00
aleos89
45936c7dc6 Updated Knuckle Arrow effect
* Caster can not move to target on GvG/Battleground maps.
2016-01-25 14:12:16 -05:00
Playtester
ec149014a6 Fixed server crash when monster use blacksmith skills (fixes #930)
* Special thanks @reunite-ro
2016-01-25 19:13:10 +01:00
Playtester
41e6b4a049 Sightblaster (fixes #788)
* Fixed Sightblaster printing errors to the map server log every time it's not used against a trap
* Fixed Sightblaster displaying damage twice and showing it's animation on every hit (partial revert of d95f5d2)
(Added a few comments so that it's clear it can't be moved to the other traps.)
2016-01-24 22:06:03 +01:00
Playtester
4fd4c1d5bf Pneuma / ArrowShower / Ranges, Charge Attack, Waterball / Jupitel fixes
* Pneuma / Arrow Shower / Ranges (fixes #915)
-- Pneuma now also protects against knockback from ranged skills
-- Arrow Shower cast by monsters is now always a melee skill and cannot be blocked by Pneuma, but can always be blocked by Safety Wall
-- When monsters cast a skill that has no specific rule, it will be considered melee when the target is within a 7x7 area around the monster, rather than a 11x11 area
* Charge Attack (fixes #417)
-- Damage: 0-3 cells 100%, 4-6 cells 200%, 7-9 cells 300%, 10-12 cells 400%, 13 cells 500%
-- Cast time pre-Renewal: 0-3 cells 500ms, 4-6 cells 1000ms, 7+ cells 1500ms
-- Cast time renewal: 500ms (250ms fixed)
-- The caster will now move to the cell next to the target rather than right on it
-- When the attack misses, there won't be knockback (but the caster will still move)
* Waterball/Jupitel (follow up to 6ebcb67, fixes #907)
-- Waterball/Jupitel now can hit through shootable walls
-- Waterball cells now can overlap
2016-01-24 17:54:02 +01:00
Playtester
9721dc94a5 NPC_EVILLAND and Sanctuary updates (fixes #927)
* NPC_EVILLAND now has 3+level intervals, a target range of 7 and ignores flee,
* NPC_EVILLAND's area of effect per unit is now 11x11 on level 1-9 and 27x27 on level 10
* NPC_EVILLAND now ignores Devotion
* Sanctuary now has exactly 1+3*level heal intervals, regardless of number of players healed
* Sanctuary will end early when 3+level targets have been hit, targets currently on Sanctuary might still be hit when it expires
2016-01-24 01:06:00 +01:00
Playtester
42b7d27e10 Merge branch 'master' of https://github.com/rathena/rathena 2016-01-22 22:57:42 +01:00
Playtester
e12fb643de Blacksmith skill update (fixes #912)
* Power-Thrust will no longer affects players that don't have a weapon equipped
* If weapon requirements on Adrenaline Rush or Power-Thrust are not met, the target will no longer display the buff animation
* Party members now only gain +5% ATK from Power-Thrust on all skill levels
* Hilt binding now increases the duration of Adrenaline Rush, Power-Thrust and Power Maximize for all party members as long as the caster has learned it
2016-01-22 22:57:21 +01:00
aleos89
8e6a65fff9 Updated Warg skills effects
* Tooth of Warg damage is now considered Weapon Mastery ATK which ignores elements.
* Warg Dash damage is no longer affected by player weight.
* When under the Warg Bite status players cannot use Hide, Cloaking, Cloaking Exceed, or Camouflage.
* Dance With Wug:
-- Damage is now considered a SC bonus.
-- Skills affected by Dance With Wug are now in INF3.
* Warg Strike and Warg Bite:
-- No longer affected by caster's % damage cards.
-- No longer ignores target's flee.
-- Ignores Demi-Human and Elemental reductions.

Thanks to @NovaRagnarok for helping test and get info!
2016-01-22 14:09:14 -05:00
Cydh Ramdh
4068266d12 Fixed #893, #920. Success rate of Tarot Card of Fate's Death was accidently changed in b385fd048a6872b0fbd2562f619c51bf75f47599
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-21 17:31:18 +07:00
Playtester
cccd1496f7 Monster Vulture's Eye and Snake's Eye removed (fixes #916)
* Monsters no longer have Vulture's Eye level 10 and Snake's Eye level 10 learned by default
* When you tank Cecil Damon from 10-14 cells away, she will no longer use her target skills
* Added a configuration with which you can set the level of Vulture's Eye and Snake's Eye that monsters have learned
2016-01-20 21:35:54 +01:00
Playtester
9cfca1cc08 Follow up to 5d7d994 and 6ebcb67 (code optimizations)
* Waterball now uses UNT_DUMMYSKILL
* Deluge/Volcano/Gale will no longer be blocked by UNT_DUMMYSKILL units
* Waterball will no longer cancel when damage is 0, on official servers this only happens if damage is negative but rAthena is no longer coded to handle negative damage unless you enable a custom feature, so... just don't use Waterball on water monsters, ok?
* Fixed two compiler warnings
2016-01-19 20:17:04 +01:00
Playtester
4c2d5153c3 Pre-renewal cast time fixes
* Mystical Amplification cast time can no longer be reduced by item bonuses except Staff of Destruction (fixes #903)
* Foresight will no longer stack additively with other cast time reductions (fixes #899)
* Suffragium and Foresight will now be consumed by skills, even if they aren't affected by them

Note: Whether skill-specific reductions stack additively with general reductions and how it works in renewal still needs to be tested, going to create separate issues for those once confirmed.
2016-01-18 21:01:38 +01:00
Cydh Ramdh
0d0c144b09 Follow up 6ebcb67601117f0e6a39aad67a1a4de11c9b8d86. Fixed compile error.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-18 10:54:58 +07:00
Playtester
5d7d994ca0 Follow up to 9db667c (BSS fixed)
* Simplified the check (no need to check for ensemble and Adoramus separately)
* Fixed PR_BENEDICTIO not working at all
* Fixed chorus skills and WZ_COMET only counting to 1 rather than MAX_PARTY
2016-01-17 20:59:26 +01:00
Playtester
6ebcb67601 Waterball, Jupitel Thunder and Mystical Amplification behavior improved
- Implemented Waterball and Jupitel Thunder double cast (fixes #907)
* Waterball and Jupitel now won't apply a delay after they have been cast and won't notify the client about the spell until 150ms later, if another skill request is received, it will actually be cast as well
* To prevent exploits this behavior can only be used every 2 seconds
* This allows you to cast a spell after Jupitel that would not have enough range to be cast after knockback
- Finally implemented the official waterball unit behavior
* When casting Waterball, water, deluge and suiton units will be turned into waterball units
* These waterball units are then turned into waterballs one-by-one
* All unit behavior now also applies to waterball, special handling is now solved via db files
* If there are multiple waterball timers active at the same time, they will actually compete for the waterball units
* When waterball does not deal damage (100% resist), it will now cancel, allowing you to act and move again
* If this breaks anything, please notify me
- Mystical Amplification improved (fixes #908)
* Mystical Amplification will now toggle at cast begin rather than cast end
* When Mystical Amplification ends, spell damage will be immediately lower even for ongoing spells
2016-01-17 18:00:18 +01:00
aleos89
b85885c0a6 Updated Water Screen Option effect
* Behaves like Devotion now.
* Damage beyond Aqua's HP is not reflected back to the master.
* Damage is now properly displayed on Aqua rather than the master.
Thanks to @exneval.
2016-01-12 18:10:35 -05:00
aleos89
e4a3811b92 Fixes #681
* Follow up to 4019fb4.
* Corrects Hover not avoiding splash attack skills.
2016-01-12 14:17:51 -05:00
aleos89
9db667c6ac Follow up to 4871dab
* Expanded the array for Comet's SP cost to MAX_PARTY to avoid overflow.
* Refined the count check for skill_check_condition_char_sub:
-- Included Adoramus in the check.
-- Added a fail safe check.
Thanks to @theultramage.
2016-01-12 10:51:29 -05:00
Cydh Ramdh
45aab55ca1 Fixed #866. Chain Lighting animation was sent in wrong flow.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-01-10 10:50:34 +07:00
aleos89
9b48263026 Fixes #882
* Resolves a potential crash with Soul Exhale and SC_NORECOVER_STATE. Thanks to @stmarier and @mrjnumber1.
2016-01-06 22:24:59 -05:00
Lemongrass3110
a7f920a071 Follow up to 4871dab
Also suggested by @lighta
2015-12-31 00:49:21 +01:00
Lemongrass3110
4871dab7de Fixed #854
Thanks to @theultramage for reporting and pinpointing the error as always!

Commiting this one for @aleos89, he fixed it for you guys.
2015-12-30 21:20:25 +01:00
Napster
99845c1fd6 Follow up to 71c6896541
* check white space
* add missing old packet
2015-12-25 10:53:43 +07:00
Napster
060f33408d Merge branch 'master' of https://github.com/rathena/rathena 2015-12-24 16:31:10 +07:00
Napster
71c6896541 Add New Skill(Pushcart Decoration)Packet Implemented
* This feature require the client support before 2015-08-26 or newer
  user can select cart for change to new design
​  Make sure you data&lub support for this

  Special Thanks you @Lemongrass3110, @renniw
  This is a Christmas gift for the rAthena people.
2015-12-24 16:29:40 +07:00
aleos89
f47d4dcc0f Updated Hells Plant effect
* Hells Plant can be removed from Crazy Weed and Land Protector.
2015-12-23 14:15:07 -05:00
aleos89
9632d2a217 Updated Howling of Mandragora effect
* Timer is not refreshed when casted on target again.
* Target's SP is not zapped again when already active.
2015-12-22 12:05:13 -05:00
aleos89
49f1c439b9 Updated Flying Side Kick effect
* Fog Wall should still apply to players who use Flying Side Kick to get out.
* Follow up to 08667a3.
2015-12-22 10:36:30 -05:00
aleos89
27e90f8f45 Fixed #828
* Resolves required equipment check needing all equipment given to be equipped rather than just one. Thanks to @Paoly28.
2015-12-11 08:47:32 -05:00
aleos89
66298f3de5 Updated Chaos Panic effect
* Placing Chaos Panic down again will remove the previous instance.
2015-12-10 13:58:25 -05:00
aleos89
43585041e9 Updated Emergency Escape effect
* Now does a single fluid back slide.
* Adjusted Emergency Escape and Feint Bomb to use blewcount in skill_db.
2015-12-10 12:19:56 -05:00
aleos89
b0e289fbf3 Follow up to 89a33a7
* Added missing status change defines to const database.
* Updated documentation for bSateNoRecoverRace.
2015-12-10 11:36:13 -05:00
aleos89
29306b1f84 Follow up to c7ede8d
* Cleaned up Shadow Form to not be canceled by detection skills at 100%.
* Phantom Menace and Sensitive Keen do not do damage if the target is in Shadow Form.
* Body Paint has a chance to decrease attack speed and blind all targets around the caster, not just the hidden targets.
2015-12-10 10:34:35 -05:00
aleos89
89a33a77ad Updated Genetic Sling Item effects
* Moved all item effects to source.
* Updated HP/SP Increase Potions to use the official statuses.
* Updated Vellum Flail to use the official status instead of Critical Wound.
Thanks to @exneval.
2015-12-08 14:38:55 -05:00
aleos89
be3d5fe298 Fixes #821
* Earth Strain no longer strips enemies that don't receive damage.
* Cleaned up the dmg_lv parameter type for skill_additional_effect().
2015-12-07 20:14:49 -05:00
aleos89
2e2e1abdc8 Fixes #804
* Corrected Hesperus Lit and Ray of Genesis Banding check.
2015-12-07 16:53:53 -05:00
aleos89
c7ede8ddbd Fixes #563
* Updated various detection skills pulling out hidden targets.
2015-12-04 16:24:54 -05:00
aleos89
8f4660b774 Fixes #524
* Spore Explosion will now properly give damage to targets.
2015-12-04 16:10:13 -05:00
aleos89
523cb145f5 Follow up to a7b8fd4
* Resolves a check for skills that have required equipment items to check for all items in the list.
* Fixes #782 - Removed renewal items from pre-renewal skill requirements for 3rd classes.
2015-12-03 11:20:12 -05:00
aleos89
af60b286d1 Bug Fixes
* Fixes #754 - Corrected Zenkai duration.
* Fixes #755 - Corrected a typo for SC_INCCRI.
* Fixed 16th Night (Izayoi) increasing variable cast time instead of decreasing.
2015-11-20 09:14:29 -05:00
lighta
4342221a1e Follow up a7b8fd4a5d33de75ae
Fix an invalid check on skill_parse_row_requiredb() for EQUIP_REQUIRE
Fix itemdb_group_free call in itemdb_read_itemgroup_sub using real
va_list, (preventing compilation on ARM)
Add some notes.
2015-11-17 00:21:05 -05:00