460 Commits

Author SHA1 Message Date
Aleos
7507065885
Corrects Brandish Spear damage stacking (#4740)
* Fixes #4739.
* Follow up to 24ecebc.
* Resolves Brandish Spear damage doing more damage than it should.
Thanks to @violent01!
2020-04-07 16:59:38 -04:00
Aleos
af8dd8b28d
Fixes issue with power skills (#4751)
* Fixes #4743.
* Resolves an issue with power skills and default data defined in the skill's array.
* Adds back linear determination and documentation for it.
* Adds a check in the converter to not print out values of 0 for levels 6 and higher for skill unit layout and skill unit range.
* Removes these values from the skill database.
Thanks to @Surefirer and @teededung!
2020-04-06 10:44:17 -04:00
victorgawk
044acebd75
Added config option for legacy NPC EMOTION behavior (#4728)
Co-authored-by: Victor Ferreira <victor.ferreira@esig.com.br>
2020-04-02 11:04:07 +02:00
Aleos
6edcf4a3a1
Fixes Wall of Thorn knockback (#4685)
* Fixes #4645.
* The knockback should be based on self and not the caster of the skill.
Thanks to @devLOOLP!
2020-03-31 08:20:04 -04:00
Aleos
652d77eb02
Job Improvement Project - Genetic (#3284)
* Fixes #2571.
* Updates Homunculus skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=218&curpage=1
* Updates Genetic skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Tokeiburu, @Badarosk0, @Balferian, and @Haydrich!
2020-03-25 13:26:26 -04:00
Aleos
24ecebcaf3
Fixes Brandish Spear from renewal balance (#4711)
* Fixes #4707.
* Follow up to ea8da71.
* Skill now applies long range damage.
* Skill now does 3 hits.
* Target's placement in the AoE does not affect damage; it's all the same for each target.
* Updates strength bonus.
* Reverts Mercenary Brandish Spear to pre-renewal effects.
Thanks to @violent01 and @mrjnumber1!
2020-03-24 18:33:01 -04:00
aleos
0021b6d577 Revert "SQL synchronization"
This reverts commit 53761b952af832455526401acfc8b388a60a5d84.
2020-03-24 17:49:00 -04:00
rAthenaAPI
53761b952a SQL synchronization 2020-03-24 18:38:07 +01:00
Aleos
412d90048d
Implemented Star Emperor and Soul Reaper classes (#4386)
* Initial implementation of these two classes skills.
* Includes kRO balancing patch: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3921697
Thanks to @Rytech2, @Mateuus, @nubspixel, @exneval, @idamonli, @hotspicy945, @admkakaroto, @cahya1992 and @RagnaWay!
2020-03-24 13:37:58 -04:00
San
58e82dc149
Adds config for Land Protector Behavior (#4675)
Adds config for Land Protector Behavior
* This battle config option adds the ability to change Land Protector to the old behavior.
* Related to #1404 and #4412.
* Thanks to @Cydh for the initial release. Thanks to @Tydus1 for the pull request!
2020-03-11 18:29:58 -04:00
Yashim Wong
e2de896414
Removes Bowling Bash Chain Damage (#4695)
* Fixes #4693.
* Removes Bowling Bash chained damage stacking on top of itself.
Thanks to @violent01 and @yashimwong!
2020-03-11 16:55:53 -04:00
Aleos
1453bcad4f
Small fix to skill_damage_db parsing (#4696)
* Fixes #4690.
* Ignore the space after damage rate.
Thanks to @Tutankhaten!
2020-03-09 16:05:10 -04:00
Aleos
ea8da71cdd
Rebalancing of 1st/2nd/Transcendent class skills (#4072)
* Fixes #3715.
* kRO changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7040
* Refactored size_fix database to YAML.
Thanks to @flamefury for his translations!
Thanks to @Angelic234, @mrjnumber1, @Badarosk0, @OptimusM, @attackjom, @Playtester, Melvo, @cydh, @cahya1992, Sigma, @whupdo, @teededung, @ecdarreola, @hotspicy945, @RagnaWay, @sader1992 for bug testing!
2020-03-06 10:57:19 -05:00
Aleos
850904ab3e
Corrects a compile warning (#4689)
* Fixes #4686.
* Corrects a compile warning for an uninitialized variable.
Thanks to @Tutankhaten!
2020-03-06 10:38:10 -05:00
Aleos
496f362ec9
Fixes skill database reloading (#4669)
* Fixes #4660.
* Resolves an issue with skill database reloading not clearing the previous data first.
* While clearing the YAML cache it will also resize the cache to the previous capacity.
Thanks to @teededung!
2020-03-04 13:03:06 -05:00
Aleos
5c35ec7d69
Corrects skill_damage_db parsing (#4667)
* Fixes #4574.
* Removes the usage of atoi as any failure returns 0.
* Adds checks for cases of invalid data.
* General cleanups and fixes.
* Fixes the import database documentation.
Thanks to @Skormie!
2020-03-04 12:33:37 -05:00
Amir Azman
b143241222
Fix Typo in Cleans up Summoner dual-cast attacks commit (Map Crash Issue) (#4677)
* Fixes #4676.
*  Fixes a typo in Professor’s Dual Casting check.
Thanks to @reunite-ro!
2020-03-01 15:45:23 -05:00
Joam
18ab64f2a1
Fix missing check element for non-damage skill (#4664)
* Fixes #4661.
* Resolves an issue with an element resistance check.
Thanks to @reunite-ro and @attackjom!
2020-02-26 08:04:26 -05:00
Aleos
836eda4879
Cleans up Summoner dual-cast attacks (#4658)
* Cleans up Summoner dual-cast attacks Bite, Silvervine Stem Spear, Scar of Tarou, and Picky Peck so that they behave like Professor's Double Casting.
* Adjusts success formula.
Thanks to @Rytech2!
2020-02-25 19:58:12 -05:00
Aleos
2931c00bd4
Implemented the Battleground Queue System (#3995)
* Fixes #1310.
* Added a battle config which allows toggling of the Battleground Queue client feature and also toggles between the modes of scripts.
* Added script commands bg_reserve, bg_unbook, and bg_desert.
* Removed old custom Battleground scripts.
Thanks to @Lemongrass3110, @Locien, @secretdataz, @InusualZ, @Normynator, @Atemo, @iubantot, @admkakaroto, and @noobzter003!
2020-02-12 08:26:59 -05:00
Aleos
986f8b0595 Fixes Land Protector not removing some units
* Fixes Land Protector not removing units with the RangedSingleUnit flag.
Thanks to @teededung!
2020-02-11 08:30:57 -05:00
Lemongrass3110
ee96438607 Fixed a map-server crash
Fixes #4614

Thanks to @reunite-ro
2020-02-08 16:35:02 +01:00
Aleos
e6a6c0533c
Updated 3rd class from RO 16th Anniversary Patch (#3659)
* Fixes #3602 and fixes #3653.
* Updated the 3rd class skills according to the RO 16th Anniversary Patch.
* Complete changelog here: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3890090&curpage=1
Thanks to @Badarosk0, @OptimusM, @Victor214, @Rytech2 and @laziem!
2020-02-07 10:39:35 -05:00
Lemongrass3110
57e50a1906 Fixed remove trap skills
Fixes #4605

Thanks to @Angelic234 and @mazvi
2020-02-05 23:29:01 +01:00
Daegaladh
4a1e904149
Fixed Hocus and Improvised Song ignoring mapflags (#4488)
* Fixed skills casted by SA_ABRACADABRA and WM_RANDOMIZESPELL ignoring critical mapflags
2020-02-05 15:15:14 +01:00
Lemongrass3110
a323474433 Fixed a few hard coded element checks 2020-02-02 20:01:55 +01:00
Lemongrass3110
5cf7aceb2a Fixed some bugs with the new skill db
Fixes #4590

Thanks to @mazvi
2020-02-02 16:04:11 +01:00
Aleos
dca3797d44
Converted the skill database to YAML (#4531)
* Combines skill_cast_db, skill_castnodex_db, skill_copyable_db, skill_nonearnpc_db, skill_require_db, and skill_unit_db into skill_db.
* Introduces a cached YAML class for quicker lookups.
* General cleanups and optimizations.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-31 14:14:08 -05:00
Aleos
271489960a
Corrected Feint Bomb infinite status (#4550)
* Fixes #4508.
* Resolves an issue where Feint Bomb was giving users infinite duration from AoE statuses.
Thanks to @laziem!
2020-01-23 16:09:52 -05:00
Lemongrass3110
e72c7360cf
Added int64 support to the script engine (#4522)
Added support for signed 64 bit integer value computation into the script engine.
This is required because newer official features require support for bigger numbers inside the scripts.

This also cleans up a lot of messy code and fixes a few issues like script stack corruptions.

Thanks to @aleos89 and everyone who supported me with this.
2020-01-13 14:44:48 +01:00
Aleos
c52b3b784a
Expanded a couple baby job names (#4500)
* Expanded Job_Baby_Rune -> Job_Baby_Rune_Knight, Job_Baby_Bishop -> Job_Baby_Arch_Bishop, Job_Baby_Cross -> Job_Baby_Guillotine_Cross, Job_Baby_Guard -> Job_Baby_Royal_Guard, and Job_Baby_Chaser -> Job_Baby_Shadow_Chaser.
* Expanded related MAPID/EAJ constants as well.
* Added deprecation notice for old constants.
* Updated database and NPC scripts to use new constants.
2020-01-01 22:53:40 -05:00
Aleos
464fd40607
Corrected Vacuum Extreme behavior (#2526)
* Fixes #2497.
* Vacuum Extreme will now pull players into the center.
* Vacuum Extreme should only pull in players that stop within it's AoE.
* It will now ignore "no knockback" bonuses players have.
Thanks to @esu1214, @cydh and @exneval!
2019-12-23 18:36:54 -05:00
Aleos
77d86c6da5
Converted Reading Spellbook Database to YAML (#4440)
* Split database between pre-renewal and renewal.
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2019-12-20 12:37:16 -05:00
Aleos
77045ef287
Converted Improvised Song Database to YAML (#4481)
* Split database into pre-renewal and renewal.
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2019-12-19 18:06:37 -05:00
Lemongrass3110
deb0615639 Follow up to 2fc7472
Fixed an issue with random calculation on abra in some cases.
Moved some commonly used functions into util and yaml database for global usage.

Thanks to @Daegaladh and @aleos89
2019-12-19 22:12:55 +01:00
Aleos
2fc7472001
Converted Abra Database to YAML (#4480)
* Removed useless skill name usage in the database.
2019-12-18 18:40:50 -05:00
Daegaladh
28c70cde3d
Fixed SC_KEEPING and SC_BARRIER exploit after classchange (#4486)
* Fixed monsters affected by SC_KEEPING and SC_BARRIER not moving or attacking after classchange
* Thanks to @aleos89
2019-12-17 23:40:46 +01:00
Aleos
d56553775a
Converted Magic Mushroom Database to YAML (#4482)
* Split database into pre-renewal and renewal.
* Left pre-renewal database empty.
2019-12-17 16:07:17 -05:00
Cydh Ramdh
e6bf2d18f9
bonus bVariableCast and bonus2 bSkillVariableCast for Pre-renewal (#4268)
* `bonus bVariableCast,t;` now works in pre-renewal to increase casting time
* `bonus2 bSkillVariableCast,sk,t;` now works in pre-renewal to increase casting time by skill name
* Item bonus documentation update
2019-11-04 08:03:15 +07:00
Joam
375aea6b86 Fix item bonus SkillUseSPRate (#4418)
* Resolves item bonus SkillUseSPRate not decreasing SP usage.
Thanks to @attackjom!
2019-10-25 09:28:40 -04:00
Aleos
abec31f320
Updated Ninja Skills (#4267)
* Fixes #4114.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7084
Thanks to @SeravySensei and @Tokeiburu!
2019-10-21 14:37:32 -04:00
Aleos
24c4c49610
Job Improvement Project - Sura (#4256)
* Fixes #4210.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7099
Thanks to @flamefury, Sigma, and @attackjom!
2019-10-18 13:10:17 -04:00
Aleos
fb6dbc306a
Corrected battle config default_fixed_castrate (#4341)
* When default_fixed_castrate is set to 0, it should not replace the value of the databases' fixed value when greater than 0.
Thanks to @SeravySensei!
2019-10-15 13:48:41 -04:00
Aleos
e3fd7a6ff0
Fixed Escape not working with bNoKnockback (#4353)
* Fixes #4344.
* Resolved Escape not letting the player backslide when wearing items that give bNoKnockback bonus.
Thanks to @Badarosk0!
2019-09-20 13:59:04 -04:00
Jittapan Pluemsumran
08d160aaac
Added multi-hit critical damage display support (#2982)
* Fixed #1788.
* Double Attack and Fear Breeze can now critically strike.
2019-09-17 14:48:29 +07:00
Aleos
90d603d141
Removed leftover variable (#4275)
* Removed an unused variable.
Thanks to @pigati23!
2019-07-30 15:42:22 -04:00
Aleos
3caf66870f
Corrected pre-renewal Heal formula (#4261)
* Fixes #4258.
* Partial reversions in formulas for pre-renewal to be multiplicative.
Thanks to @Indigo000!
2019-07-25 08:42:48 -04:00
Aleos
4ea1b25483
Corrected Strip duration (#4257)
* Fixes #4214.
* Corrected Strip duration becoming negative which results in the status not expiring.
Thanks to @Stingor!
2019-07-25 07:45:01 -04:00
Aleos
5702dc3c85
Corrected another potential crash with Joint Beat (#4255)
* Follow up to cb2c553.
Thanks to @teededung!
2019-07-22 08:40:49 -04:00
Aleos
6d199ca7d2
Corrected a potential crash with Joint Beat (#4251)
* Follow up to cb2c553.
Thanks to @teededung and @cahya1992!
2019-07-18 12:25:57 -04:00