430 Commits

Author SHA1 Message Date
Atemo
3a45dd97f9 Another clean-up 2015-12-09 23:09:17 +01:00
Cydh Ramdh
9d3d34205f Skill DB clean ups
* Changed skill_db array to better memory allocation.
* Reduced MAX_SKILL_LEVEL from 100 to 10 (part of Hercules 0f4a50d135), also has changes on skill_get checks for skill level that more than 10.
* Reduced MAX_SKILL from 5020 to 1200 (actually only 1109 skills are used).
* Added macros for checking Homunculus, Guild, Mercenary, & Elemental skill ranges.
* Added skill check & index validation when player logged in and when @reloadskilldb.
* Corrected `enum e_skill_flag` order for SKILL_FLAG_REPLACED_LV_0's sake.
* Merged 'addtoskill' script command just as alias of 'skill' script command.
* Fixed #277
* Changed 'skill' script command flag to constant value

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>

NOTE:
* Decreased memory usage by map-server reduced up to 50 MB.
* Decreased memory for each player because of mmo_charstatus::skill[] only has 1200 array, before is 5020.
* Please use skill_get_index() for accessing sd->status.skill[] or skill_db[], don't reckless use skill_id as array index.
* Please import upgrade_20150211_skillset.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2015-02-12 15:50:50 +07:00
Euphy
30b4d578a7 Some script cleaning.
- Replaced lots of numerics with constants.
- Added spacing to make some scripts more readable.

Fixed a mistake in 14fddd3.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-23 15:17:59 -04:00
Euphy
14fddd3790 Added script checks against swapping items using third-party hacks.
- Follow-up to 416f6d7, as further protection against item exploits.

Contains a few other fixes.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 15:36:23 -04:00
Euphy
17bace0ae6 Script bug fixes.
- Added Renewal location for "Knight De Thomas" NPC (previously inaccessible), and upgraded the script to the latest version.
- Fixed Pre-Renewal Merchant Quest questlog commands. (bugreport:9218)
http://rathena.org/board/tracker/issue-9218-merchant-quest-add-error-quest-add-1010/
- Corrected a handful of 'rand(1)' statements.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-16 19:10:19 -04:00
Euphy
2688d78e6a Added a few missing 'changequest' commands to Alchemist job quest. (Hercules 4b4e573)
Minor cleanup in Wolfchev's Laboratory script.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-05-18 08:36:12 -04:00
Cydh Ramdh
3441d4a30b * Updated/added item_db, thank https://github.com/ROClientSide/Translation for some item view ids
* Follow up 0724d1e
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 19:07:05 +07:00
Euphy
0724d1ebab Minor updates.
* Added Cryptura Academy monster spawns, commented until the scripts are implemented. Does not include monsters from job quests.
* Fixed two label errors in Wizard job quest. (bugreport:8590)
http://rathena.org/board/tracker/issue-8590-wizard-job-quest-label-error/
* Updated AUTHORS file. (credits to AnnieRuru and Keyworld for providing some missing names)
* Uncommented a mapflag in custom 'mvp_ladder' script. (credits: AnnieRuru)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-04 21:35:36 -05:00
Euphy
90b187ff3e Changed all "Compatible With" fields to "rAthena Project".
Edited a handful separately, as appropriate.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-12 16:24:38 -05:00
Euphy
b2d96cbc7f Implemented Kagerou/Oboro job change quest.
Uses official script structure, with iRO dialogue taken from M45T3Ryu/KO-Proyect@d78f847.

Added Kagerou/Oboro support to other Ninja-related files.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-11 22:37:36 -05:00
Euphy
97687ca10c Global_Function updates.
* Added the following functions:
  - "F_GetPlural" (returns plural of noun) / "F_InsertPlural" (returns plural if arg != 1)  [credits: EnglishClub for formation rules]
  - "F_InsertArticle" (returns 'a' or 'an' preceding word)
  - "F_InsertComma" (formats number with commas)
  - "F_GetNumSuffix" (formats number with '-st', '-nd', '-rd', or '-th' suffix)
* Added and removed new functions where necessary. (incomplete)
* Added new types to "F_GetArmorType" function, and weapons will now pass to "F_GetWeaponType".
* Reformatted comments.

Other changes:
* Removed some garbage text from scripts.
* Slight edits to custom warper script.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-03 20:13:44 -05:00
Euphy
1d64b8f9e1 Script/database bug fixes.
* Fixed an issue in "Message Delivery" quest blocking level 100+ characters. (bugreport:8373)
http://rathena.org/board/tracker/issue-8373-message-delivery/
* Added Renewal quest items to Ayothaya Dungeon Entrance quest. (bugreport:8375)
http://rathena.org/board/tracker/issue-8375-ayothaya-dungeon-entrance-quest/
* Temporarily moved the Renewal location of "Strange Machine" in the "Muff's Loan" quest; confirmation needed. (bugreport:8370)
http://rathena.org/board/tracker/issue-8370-muffs-loan/
* Updated Blacksmith job quest with some extra conditions. (fixes bugreport:8347)
http://rathena.org/board/tracker/issue-8347-about-blacksmith-job-quest/
* Changed all 'bAtk' bonuses to 'bBaseAtk', a continuation of r17149. (fixes bugreport:8372)
http://rathena.org/board/tracker/issue-8372-daehyon-card-is-not-working/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2013-12-28 22:47:32 -05:00
Euphy
7cb4145691 * Cleaned up some unnecessary global ($) and temporary character (@) variables in scripts.
* Removed unnecessary labels, particularly those in warp scripts.
* Some optimization of the Hugel Bingo script.
* Fixed a mob_db error. (bugreport:8051)
* Fixed incorrect/incomplete random Glast Heim warp.
* Removed useless 'getJobName' function from GlobalFunctions.txt.

Signed-off-by: Euphy <euphy@rathena.org>
2013-09-06 19:37:14 -04:00
Euphy
bf68ccefa3 * Script style standardization.
- Standardized cases on constants (Zeny, Sex, BaseLevel, etc.).
- Replaced numerics with constants.
- Standardized parts of script headers.
- Changed some script styles to K&R.
- Added some official script file names as comments.
- Replaced most 'misceffect' commands with 'specialeffect'.

Signed-off-by: Euphy <euphy@rathena.org>
2013-08-27 03:28:41 -04:00
Euphy
5ab4d5ea90 * Script updates:
- Updated Nameless Island quests and added questlog support in quests_nameless and quests_prontera. (fixes bugreport:7992)
- Updated "God Item Creation" scripts to their latest versions: seals roll at 25/50 instead of 50/100 in Renewal.
- Updated Soul Linker job quest with new checks.
- Fixed an untranslated Manuk NPC.
- Some follow-ups to previous commits.

* GM Management System:
- Enabled all official GM Management NPCs and wrote a function to control their usage.
- Implemented some missing GM Management NPCs (still incomplete).

Signed-off-by: Euphy <euphy@rathena.org>
2013-08-25 20:56:46 -04:00
Euphy
c2bdd52865 * Kareka now offers to reset enchantments on Light of El Dicastes. (bugreport:7890)
* Fixed Malangdo rentals lasting for 1 day instead of 1 hour. (bugreport:7889)
* Added Old Glast Heim location to custom warper.
* @mobinfo now displays slots for MVP drops.
* Fixed a label execution in Dancer job quest.

Signed-off-by: Euphy <euphy@rathena.org>
2013-07-23 15:21:32 -04:00
Euphy
be2428b832 * In Pre-Renewal, players can use items and self-targetting skills while talking to NPCs. (continuation of bugreport:6527)
* Fixed an issue in Malangdo quests. (bugreport:7863)
* Fixed two incorrect event calls in Assassin job change quest.

Signed-off-by: Euphy <euphy@rathena.org>
2013-07-18 23:32:25 -04:00
Euphy
3beb7833f9 * Fixed Guardian Stone respawns in WOE SE. (bugreport:7849)
* Fixed job checks in Falcon Flute Trader script. (bugreport:7839)
* Fixed Guillotine Katar slots. (bugreport:7838)
* Fixed @itembound type 4 not working.
* Bossnia changes:
- Monsters should not be spawned with 'boss_monster' according to official scripts; removed 'notomb' mapflags accordingly (partial revert of r17404).
- Merged file into events/bossnia.txt, since the spawns and warps should be disabled by default.

Signed-off-by: Euphy <euphy@rathena.org>
2013-07-17 23:16:15 -04:00
euphyy
fdd0fd1d72 * Standardized label names and converted all labels to Pascal case. (temp. fix for bugreport:6988)
* Many fixes to Izlude Arena scripts.
* Other misc. standardization.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17410 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-07-10 07:25:44 +00:00
lemongrass3110
6e9ce692b3 Fixed not working cutins. bugreport:6466
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17265 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-04-16 21:33:06 +00:00
euphyy
c77b6ef1c3 * Fixed some issues in Moscovia quests. (bugreport:7361)
* Added official warper for Undersea Tunnel floor 6; added shops for Mora and Port Malaya; added some Izlude RE warp coordinates. (ea:15236)
* Fixed Arrow Storm cast time and cooldown. (Hercules 54b5ec9)
* Cleaned and updated README.txt.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17203 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-03-19 21:47:32 +00:00
euphyy
6aa1beed27 * Changed remaining bEquipmentMatk bonuses to bMatk in item_combo_db (follow-up r16981).
* Reverted r17116.
* Merged eAthena ea:15231, ea:15232 by ai4rei.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17117 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-02-02 05:45:09 +00:00
flaid
8b409e29b0 Splited hunter quest into renewal and pre-renewal.
Hunter quest in renewal doesn't require Claw of Desert Wolf anymore, it requires the normal Wolf Claw.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17116 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-02-02 00:20:10 +00:00
euphyy
f1577d8183 * Added a missing checkre() in Hunter job quest (bugreport:7230).
* Fixed item 18103 job and script (bugreport:7137).
* Added a note for where party_share_level is located in conf/battle/party.conf (tid:75137).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17115 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-01-31 22:34:30 +00:00
euphyy
5b456c67a1 * Documented @set command from r16123.
* Fixed a waitingroom bug in Wizard job quest (bugreport:7189).
* Fixed getequipname() returning -1 instead of an empty string (bugreport:7186).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17100 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-01-16 01:09:24 +00:00
euphyy
62dee5b8c7 * Updated Geneticist, Warlock, and Sura job quests to their latest versions.
* Added a clearer example for party_even_share_bonus (tid:58005).
* Standardized job headers.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17010 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-12-08 18:18:36 +00:00
brianluau
ec75513871 - Fixed missing 'close' in priest.txt (bugreport:6921)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16943 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-11-22 16:45:51 +00:00
j-tkay
de9950737d - Fixed bugreport:6785, missing changequest in Knight Job Quest. (npc/jobs/2-1/knight.txt)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16819 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-10-15 15:06:41 +00:00
euphyy
0448652500 * Fixed a misplaced quest log entry in Priest job quest, bugreport:6702 (jobs\2-1\priest.txt)
* Fixed an incorrect check in Taekwon job quest, bugreport:6711 (jobs\1-1e\taekwon.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16786 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-09-18 19:37:42 +00:00
euphyy
31d2fe26b3 * Follow-up r16742, revised quest sample (doc\sample\npc_test_quest.txt) and whisper system documentation (doc\whisper_sys.txt)
* Follow-up r16745, fixed a few typos in atcommand documentation (doc\atcommands.txt)
* Minor cleaning - spacing, tabulation, comments, dividers

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16746 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-09-05 02:42:20 +00:00
euphyy
9800b743e6 * Raw revert of all job files back to r16578, prior to the rewrite in r16579. The updates will be re-applied after more testing is done.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16621 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-10 18:45:05 +00:00
euphyy
fb0a39fe3e * Optimized Eden Quest lv. 11-25 (re\quests\eden\)
* Fixed bugreport:6427 with new Alchemist quest (jobs\2-2\alchemist.txt)
* Other misc changes/fixes...

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16615 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-10 04:55:08 +00:00
masao87
44327805ca - This should fix all job quests which didn't work after the update.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16584 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-05 15:26:07 +00:00
masao87
93d361847e - Some little adjustments to the job change quests, also reverted some variables to the old job change files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-05 11:19:56 +00:00
masao87
9a71512a79 - Follow up r16579 .
* Added some missing Baby checks... This Update really started great didn't it ;)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-04 22:15:29 +00:00
masao87
b2dd8c722e - Here comes the big Job folder Update.
* Updated all 1-1, 2-1, 2-2 and the expanded files to the latest available official files and also added support for baby job change.
* There might be some optimizations still needed at some places and there maybe occur some errors as well or the job change isn't fully working anymore since I didn't test all the jobs through the end (Me = Lazy), if so then please fill out a bug report in our bug tracker: http://rathena.org/board/tracker/project-4-scripts/
* Ninja, Gunslinger and the other files will follow within the next days.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16579 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-04 21:45:50 +00:00
daegaladh
52a4de498e Fixed some bugs on jobs and merchants scripts.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16559 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-02 12:17:06 +00:00
daegaladh
f49b3d6f55 Full npc folder reorganization. (I hope I didn't break anything D:)
-Now common scripts goes to the main npc folder, and pre-re-only/re-only ones goes to their respective folders.
-NPCs with practically the same script but little differences have been left in the main folder and uses the command checkre() for the differences.
-For those NPCs with different coordinates but same script, the script has been left in the main folder but the NPCs splitted as duplicates.
-All pre-renewal files has been reverted back to their pre-renewal behavior.

TODO:
-Correct pre-re quest rewards.
-Check for pre-re/re differences in mapflags.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-08-01 04:29:56 +00:00
shennetsind
086af74531 Okie ladies and gentleman if this commit breaks anything it's jman's and maki's fault, yes, blame them.
Fixing pre-re / re npc support, moving /config/ folder to src root so other servers may also make use of the #define renewal dir and other stuff.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16382 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-08 19:30:07 +00:00
euphyy
7bd7f81dae * Corrected and optimized 12 guide NPCs (/guides/)
* Fixed a small typo in Warlock quest, bugreport:6164 (jobs\3-1\warlock.txt)
* Fixed a couple of job constant typos in "Nameless Island Quests" (quests\quests_nameless.txt)
* Removed non-RE changelogs from RE scripts

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16376 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-04 15:26:16 +00:00
euphyy
36c9f0887b * Optimization of Knight job change quest, and fixed bugreport:6163 (jobs\2-1\knight.txt)
* Follow-up r16373: added another missing entry (bugreport:6162)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16374 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-04 03:31:55 +00:00
euphyy
741c59a409 * Neuralizer is no longer consumed upon failure (bugreport:6040)
* Some cleaning of the Sorcerer job change quest (jobs\3-2\sorcerer.txt)
* Cleaning of "Bunny Band Quest" script (quests\bunnyband.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16367 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-02 18:09:25 +00:00
masao87
9d3e2c3021 - Redone the whole Arch Bishop Job change Quest in order to hopefully have fixed all the bugs from bugreport:5983 .
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16364 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-01 16:59:44 +00:00
masao87
a1c12384fa - Fixed a bug in Eden Group Quests where a variable was set which was supposed to be converted and give the player certain gears. bugreport:6143
- Fixed an Priest Quest cutin which would result in getting an missing file error of the MvP Mistress Card illustration. bugreport:6144
- Fixed EXP Values in Eden Group Quest Boards 86 - 90 and 91 - 99. Source: http://irowiki.org/wiki/Eden_Group_Leveling_Quests
* 3 Hours cooldown isn't added yet since some testing is needed. bugreport:6110
- Some minor paranthesis fix in Knight Jobchange Quest.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16362 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-01 14:13:56 +00:00
euphyy
de7ebc5300 * Standardized and added Shadow Chaser job quest! (bugreport:5834)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16350 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-06-28 04:44:17 +00:00
euphyy
3b8d196c31 * Massive compression of "Card Trader" script, from 123kb to 7kb! (other\card_trader.txt)
* Some optimization of Ash-Vacuum quests (quests\quests_13_1.txt)
* "Sphinx Mask Quest" script optimized (custom\quests\sphinx_mask.txt)
* Moved "Caral" NPC from non-existent moc_fild04 to cmd_fild08, as per bugreport:5959 (custom\quests\thq\THQS_Quests.txt)
* Fixed Job_Archbishop/Job_Archbishop_T typos in job change script, but other issues in bugreport:5938 not addressed (jobs\3-1\archbishop.txt)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16254 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-06-10 01:37:17 +00:00
masao87
7cee7996e8 - Added Instructor Ur to Eden Quest Quests. bugreport:5742
- Added Mission Boards 86-90 and 91-99 to Eden Group. bugreport:5742
- Updated quest_db.txt to match the new Quests in the new Eden Group Quests.
* Special thanks to Chilly for providing the base of the scripts! <3
- Updated Rune Knight Job change Quest for the last time to finally work as official as possible.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16213 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-06-02 01:55:34 +00:00
masao87
0c530aa2fe - Fixed parenthesis check in most 3rd job change quests. bugreport:5883
- Partially rewrote Rune Knight job change quest. bugreport:5881
- Follow up r16180 where i forgot to rename some Warper NPC from Mina to Warp Agent.
- Fixed some comodo quest typos. bugreport:5882

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16192 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-05-31 22:13:00 +00:00
masao87
cbd577d069 - Added BaseClass explanation to script_commands.txt .
- Some updates to the custom folder / the old eAAC Scripts which are now in there.
- Fixed custom/warper.txt prontera location to not collide with Ash Vacuum warper. bugreport:5857
- Fixed Platinum Skill Quests properly checking for BaseClass now. bugreport:5853
- Fixed some typos in Ranger Job change Quest & Eden Paradise. bugreport:5858
- Fixed a typo in scripts_athena.conf . bugreport:5852

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16165 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-05-29 12:08:59 +00:00
masao87
2c2594d918 - Added ability for all 2nd baby classes to change into their 3rd baby job doing the 3rd job change quest. bugreport:5789
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16163 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-05-28 16:23:03 +00:00