13553 Commits

Author SHA1 Message Date
AtlantisRO
c5cd672cd8 Fixes to Typo Errors. 2016-03-12 10:41:18 -07:00
Playtester
916e45f0e3 Merge branch 'master' of https://github.com/rathena/rathena 2016-03-12 16:51:45 +01:00
Playtester
a6f73a6227 Status changes that cause damage reworked (fixes #1033, fixes #448)
* Created a better structure for status changes with intervals and integrated the status changes Stone, Poison, Deadly Poison, Bleeding, Magic Mushroom, Burning, Pyrexia, Leech's End and Toxin into the new structure
-- The exact remaining duration of these status changes will now be stored
-- The correct duration is reloaded when logging back in, you can't avoid a single tick be re-logging
-- It will now show the correct duration on the icon of the status change after re-logging, no longer negative values
-- The durations are now accurately transferred when using Deadly Infect
-- These status changes now use unified code, which makes it much easier to integrate more status changes into this structure with low risk of breaking something
* Removed all the status change specific logging of damage and integrated it into the normal logging behavior
-- The following skills deal "No source" damage: Stone, Poison, Deadly Poison, Bleeding, Coma, Magic Mushroom
-- The following skills deal "Self" damage: Burning, Pyrexia, Leech's End, Toxin
-- "No source" will neither be logged nor contribute to the total damage, your exp share doesn't increase from the damage, but it also won't cause the monster to give less EXP, it won't break freeze or similar status changes, it won't make you stand up, it won't make you stop moving, it won't prevent you from logging out
-- "Self" damage will now be logged and contribute to the total damage, it makes monster give the exp tap bonus, but also makes monsters give less exp the more "self damage" they've taken, it will break freeze and similar status changes, it will make you stand up properly now, it will make you flinch and stop moving, it will prevent you from logging out, but angry type monsters will not lose their aggressive bit from it and it will not cause monsters to use their rude-attack skill
-- Monsters will now use their rude-attack skill on the first rude-attack as long as the damage does not come from self
-- When a monster takes damage from a status change, its HP meter will now be updated
* Burning now has an interval of 3s and a minimum duration of 10s
* Pyrexia now causes blind for Pyrexia's duration instead of just 30s
* Ground Drift's poison base duration is now 60s in pre-re (follow-up to e7150ee)
* Fixed a bug where the minimum duration failed to apply when the received duration was below 1ms
* map_foreachindir and map_foreachinshootarea will now properly print their function names in case of an error
* Updated documentation (transferring source ID is no longer required, remaining tick should now always be in val4)

If this breaks anything, please report asap.
2016-03-12 16:50:50 +01:00
Lemongrass3110
081b03c646 Added placeholders for mob db entries from kRO patch 2016-03-09 2016-03-12 16:40:24 +01:00
rAthenaAPI
180dbc88fb SQL synchronization
[ci skip]
2016-03-12 16:34:16 +01:00
Atemo
6f34c14c0e Fix a mistake in npctalk 2016-03-12 16:03:16 +01:00
aleos89
0f5b6db813 Implemented new adoption methods
* Implemented atcommand adopt.
* Implemented script command adopt.
* Circumvents adoption issues with 2013-08+ clients (Related to #768).
* Suggested from https://rathena.org/board/topic/104014-suggestion-add-adopt-or-etc/
2016-03-11 13:45:17 -05:00
Cydh Ramdh
ac1db5de02 Merge pull request #1043 from AtlantisRO/master
Fix to NPC [Larissa#mos_01] in script [npc/quests/quests_moscovia.txt]
2016-03-11 09:35:50 +01:00
TeMPlatonic
f1c90899f0 Fix to NPC [Larissa#mos_01] in script [npc/quests/quests_moscovia.txt] from [Help Mikhail] Quest.
delitem script uses ".@di" array instead of ".@n" array.
2016-03-11 00:04:07 -07:00
aleos89
ed7157c80b Refactored Party Booking defines (fixes #1018)
* Adjusted the name of the defines to better suit their purpose.
Thanks to @Artuvazro!
2016-03-10 13:47:01 -05:00
aleos89
0fb78d45b7 Corrected Tiger Cannon splash damage (fixes #1020)
* The splash damage now factors in resistances from the splash targets.
2016-03-09 13:32:49 -05:00
aleos89
b98ba7a274 Expanded script command addrid
* Added another option to attach players based on a specified map.
* As suggested in https://rathena.org/board/topic/88331-addrid-addition/ and  https://rathena.org/board/topic/103478-addrid-map-support/
2016-03-08 12:43:09 -05:00
Cydh Ramdh
9ebf59c37b * Official EXP-Giving Script
* Fixed #980.
  * Job Quest EXP always be shown in yellow color.
  * Miracle Tonic (12259) and Leap of Fantasy (12261) give fixed EXP through `pc_setparam` that ignore EXP item bonuses and exp rates. Not as Quest EXP from `getexp` script.
  * If given EXP is 0 by `getexp`, it won't be notified in client EXP log.
  * If given EXP for base/job that reach max level, client will be notified as 0 EXP gained.
* Follow up 20588abcd83fab53f9e52deafc08bfcddfe1658a
  * Some clean up on `pc_gainexp`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-08 18:03:59 +07:00
Cydh Ramdh
71cdcb3a0a Follow up b70b25945e697b3b5e6e637ac096430490ee17c5
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2016-03-08 17:47:24 +07:00
nanakiwurtz
d4488d6889 Merge pull request #1023 from secretdataz/fix/item_db1
Item database update. Fixes #1012 and fixes #1022
Thanks to @secretdataz
2016-03-08 01:10:05 +07:00
aleos89
709424a75f Resolved a compile error
* Small follow up to 0d5e491.
2016-03-07 10:32:25 -05:00
aleos89
0d5e491b4e Fixed a potential crash with script command setunitdata (fixes #1024)
* Corrected the mercenary client refresh function using monster data rather than mercenary data.
Thanks to @Racaae and @julia40124009!
2016-03-07 09:33:00 -05:00
Jittapan Pluemsumran
59c92b76fb Add job condition for Ozs_New_Wing_Ring (2988) and Bloody_Floral_Decoration_Bracelet (2989). Fixes #1012 2016-03-07 11:49:37 +07:00
Jittapan Pluemsumran
96bf0814a7 Add RWC_Gold_Brooch + RWC_Brooch combo script. Fixes #1022 2016-03-07 11:48:51 +07:00
rAthenaAPI
7235152d7e SQL synchronization
[ci skip]
2016-03-06 23:25:18 +01:00
Lemongrass3110
8636cb2489 Added a sample NPC for the new navigateto script command
Additionally fixed up the documentation some more.
2016-03-06 23:24:33 +01:00
aleos89
809f220b9f Added to script command navigateto documentation
* Small follow up to 179f734.
* Also corrected an invalid constant.
2016-03-06 16:15:54 -05:00
aleos89
179f734249 Added documentation for script command navigateto
* Follow up to 4f13007.
* Corrected a few constants from PLANE -> AIRSHIP.
2016-03-06 16:10:15 -05:00
Lemongrass3110
4f13007fec Implemented serverside navigation system start
This feature was hidden in the client since 2011 and just came to our attention recently.
2016-03-06 21:48:47 +01:00
Playtester
80e026433f Official status change base durations for Stun (fixes #1019)
* NPC_LICK now has a base chance of 20%*level and a base duration of 5s
* Excruciating Palm now has a base duration 5s
* Shield Press now has a base duration of 5s+0.5s*level
* Earth Shaker now has a base duration of 2s (level 2-3) and 3s (level 4-5)
* Blind follow-up: Sightless Mind now has a base duration of 30s in pre-re and 20s in renewal
2016-03-06 19:46:45 +01:00
Lemongrass3110
614a010f59 Fixed two missing color markers
Fixes #1017
2016-03-06 16:08:43 +01:00
Playtester
e7150ee936 Gunslinger Mine / Ground Drift (fixes #998)
* Fixed knock back being 6 tiles instead of 3
* Stun duration is now 5 seconds
* Blind / Silence durations are now 30 seconds (pre-re) or 20 seconds (re)
* The damage is now delayed by aMotion; as the status effect kicks in immediately, damage will break Freeze
* The base chance for a status change is now 50% instead of 5%
* It is now a weapon skill, damage% increase/reductions are now considered, in renewal the skill can completely miss
* Damage in pre-renewal is 100% + fixed damage of 50*level
* Damage in renewal is 200%+20%*level
* Fixed sphere attack not being considered in the damage formula
* The ground effect disappears immediately after activation now
2016-03-06 12:09:46 +01:00
Lemongrass3110
b70b25945e Fixed experience overflow on high rates
Fixes #1014
2016-03-06 05:16:58 +01:00
Lemongrass3110
551bf2ef5d Fixed experience not counting for the next level
This was broken on 20588ab because the function pc_thisbaseexp was misinterpreted.

Now you get the required exp for the level you just mastered -1 again. Fixes #1013

Thanks to @Sweet520 for reporting.
2016-03-06 05:04:36 +01:00
Playtester
7906f0a3ff Line of Sight System updated (fixes #937, fixes #994)
* You can now target walls with ground skills
* Updated path check to not check the last cell
* Unit skills will now place units depending on line of sight to the caster rather than the cast center
* Implemented a new algorithm that retrieves all units in an area that are in line of sight with the area center
* Arrow Shower, Dragon Breath, Cold Slower, Wind Cutter and Arms Cannon now use the new algorithm (Arrow Shower is no longer a unit skill)
* Nodamage skills will no longer fail when the target walked around a corner
* The following damage skills will no longer damage through walls: Raging Thrust, Tornado Kick, Splash Attack, Venom Splasher, Fireball, Meteor Assault, Desperado, Spread Attack, Pulse Strike, Hell's Judgment, Vampire Gift, Magnum Break, Sightrasher, Frost Nova, Explosion, Self Destruction, Firing Trap, Icebound Trap, Cluster Bomb, Claymore, Fire Pillar
2016-03-05 18:02:22 +01:00
Lemongrass3110
fb4cf3e5e3 Merge pull request #1001 from secretdataz/fix/message
Fixed chat message that already have zero termination being misinterpreted as corrupted packets.
This issue was reported on #1000 by @secretdataz and was on clients from 2015-10-01 onwards and was mainly caused by Frost Joke.

Thanks to @secretdataz for additionally providing a fix for it in this pull request too.
2016-03-05 16:28:36 +01:00
Lemongrass3110
fef0d3d175 Fixed SG_DEVIL not giving blind anymore
Additionally fixed setting BaseExp and JobExp variables by script to not go over the new maximum.
2016-03-05 16:10:06 +01:00
aleos89
0677347527 Updated Madogear effect
* Partial revert of 744aed5.
* Blocked Canto Candidus giving Increase Agility to Madogear-ed players.
* Was fixed in a kRO patch on Feb. 24, 2016.
2016-03-05 09:54:09 -05:00
Lemongrass3110
ae8ba78449 Fixed multi level up exploit, which allowed going over the defined maximum levels
Fixed #1010
2016-03-05 13:35:51 +01:00
Playtester
2b7eb9f523 Follow-up to ecb01c4 (Angry mode)
* When monsters switch modes from or to angry mode, the aggressive bit will now be set properly
2016-03-04 21:40:38 +01:00
Playtester
ecb01c44f4 Monster angry mode and provoke (fixes #1011)
* When provoked, monsters will now only switch targets when they would also change targets on damage
* Added a new option to the mob_ai setting to restore the old behavior (monsters always go after the one casting provoke)
* When casting provoke on an angry mode monster before it was attacked, it will now go for the one casting provoke and not switch back to the closest target
* Angry mode will now always be reset when the monster switches to idle
2016-03-04 21:22:16 +01:00
Lemongrass3110
b1b3aae1e9 Fixed a bug where experience might go above the defined maximum
Might be related to #1010
2016-03-04 18:22:57 +01:00
aleos89
4eb3a9eeda Updated callshop script command for Item and Point Shop (fixes #1008)
* Follow up to a16fb7c.
* Resolves the callshop script command not using the new Cash Shop interface for Item and Point Shop.
2016-03-04 09:19:56 -05:00
Lemongrass3110
543d2c361e Added some missing mob placeholders
[ci skip]
2016-03-04 00:29:46 +01:00
Lemongrass3110
98fedbdf09 Fixed null termination on party chat for 2015-10 onwards
Fixed #1003
Fixed #992
2016-03-03 23:12:09 +01:00
Playtester
61a48b9b0b Jack Frost, Status Traps, Stone Fling, Leap, Cannon Spear
* Fixed status base chances of Jack Frost and Status Traps (fixes #997)
-- Jack Frost: 200% freeze chance instead of 100%
-- Land Mine: 10% stun chance instead of 35%-55%
-- Flasher: 100% blind chance instead of 40%-80%
-- Freezing Trap: 100% freeze chance of instead 38%-50%
* Sandman Sleep and Throw Stone Blind base duration is now 30s in pre-re and 20s in renewal
* Leap now has a shorter distance when used diagonally (fixes #1007)
* Cannon Spear now shows the skill animation even if it doesn't hit anything (fixes #1004)
2016-03-03 22:11:41 +01:00
aleos89
3a5f3a3f98 Fixed a possible crash with NPC currencies (fixes #1002 and fixes #1005)
* Resolved the nullpo return message.
* If the Cash Shop opened through the client button is used it will now properly return the cash value.
2016-03-03 14:47:25 -05:00
aleos89
101b07130c Corrected a typo in Body Style command (fixes #999)
* Adjusted parenthesis.
2016-03-03 13:20:30 -05:00
Jittapan Pluemsumran
e9c9fd65d4 Don't add null if the message is already null-terminated. Fixes #1000 2016-03-03 11:33:39 +07:00
Atemo
033cdba82b Added mapflags in que_ba quest map
Thanks @Playtester
2016-03-03 00:10:18 +01:00
aleos89
2fd0517351 Updated some Cash Shop related comments
* Small follow up to a16fb7c.
* Updated/corrected miscellaneous comments for NPC shops.
* Added enum values for Cash Shop failure client messages.
* Re-ordered some functions be with other related functions.
2016-03-02 09:34:19 -05:00
aleos89
1616e06b9e Corrected Chain Lightning skill delay (fixes #995)
* Should have a global cast delay of 3 seconds.
2016-03-01 12:55:46 -05:00
aleos89
a16fb7c176 Updated Item and Point Shop (fixes #843)
* Item and Point Shop now works like the NPC Cash Shop.
* No longer has issues with player Zeny checks.
2016-02-29 20:54:23 -05:00
Playtester
f5b6e9f7c4 Merge branch 'master' of https://github.com/rathena/rathena 2016-02-29 22:18:38 +01:00
Playtester
1bf8537140 Berserk HP recovery (fixes #993)
* Fixed a problem that HP/SP didn't recover properly when casting Berserk, MERC_HPUP or MERC_SPUP while attacking
2016-02-29 22:17:49 +01:00