Added fix for shadow equipment slots in itemdb_parse_dbrow: if an item isn't shadow gear but have shadow equipment slot map-server will mark it as IT_ETC.
** Some attempts to support this job with its skills (as usable as good as I can, some of them are custom from limited info, maybe I miss some behaviors)
** Maybe some formulas, entries on skill_db, skill_require_db, skill_unit_db, and skill_cast_db are still custom
** Thank posters are on: (1) http://rathena.org/board/topic/85195-rebellion-class-released-on-kro-sakray/ (2) http://forums.irowiki.org/showthread.php?t=100131
** Some notes:
--> RL_RICHS_COIN, Rich's Coin
--> RL_MASS_SPIRAL, Mass Spiral: Bleeding chance and additional damage still custom formula
--> RL_BANISHING_BUSTER,Banishing Buster: Custom chance formula to remove buff/debuff
--> RL_B_TRAP,Bind Trap: Even I updated my client and use original lua, I stil can't see the trap
--> RL_FLICKER,Flicker
--> RL_S_STORM,Shatter Storm: Custom formula for success rate
--> RL_E_CHAIN,Eternal Chain
--> RL_QD_SHOT,Quick Draw Shot
--> RL_C_MARKER,Crimson Marker: Still doesn't show the icon of marked target on minimap (I don't know the packet for it)
--> RL_FIREDANCE,Fire Dance: Not sure it's only 1 hit damage or works like Desperado (I saw someone's screenshot, it seem only deals 1 hit)
--> RL_H_MINE,Howling Mine
--> RL_P_ALTER,Platinum Alter
--> RL_FALLEN_ANGEL,Fallen Angel
--> RL_R_TRIP,Round Trip
--> RL_FIRE_RAIN,Fire Rain: (1) This should able to remove ground target aroung its area, (2) And the splash area like a 'cone' (I imagined like someone uses gun then fire brutally to his/her front way)
--> RL_HEAT_BARREL,Heat Barrel: Still custom formula, but I saw the damage is increased highly.
--> RL_AM_BLAST,Anti-Material Blast: Custom formula for success chance
--> RL_SLUGSHOT,Slug Shot: Custom formula for damage (I saw someone's screenshot, bullet with 120 weight can deals 100k damage)
--> RL_HAMMER_OF_GOD,Hammer of God: If there is no enemy with SC_C_MARKER around the area, the skill Hammer of God animation won't displayed (maybe I missed something? I guess so)
(I guess some lines and algorithm should be cleaner, cooler, and sexier. :P)
IMPORTANT for client side:
- You should have up-to-date grf files
- I used original lua files, I didn't use translated lua files that exist nowadays because I think they need to update their supports for Rebellion
- Some items for Rebellion Skill's requirement(s) aren't added yet
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
-- Updated item_db.txt, makes Rebellion can use Gunslinger weapons and ammos
-- Updated item_db.sql and item_db_re.sql
-- 3CeAM 2.0 merger: r13
-- idAthena merger: r1057, r1077
* Follow up 3f6d4b6
-- Update the const.txt for SC_MOONSTAR and SC_SUPER_STAR. SC_EXTREMITYFIST2 should be always on the end of SC number
* Hercules merger: 1375af7d00
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
-- Added a new option info for skill's 'inf2', INF2_NO_NEARNPC, that used for checking if the skill is castable if caster/ground/target is near with NPC (by specified range option)
-- Corrected Shadow Chaser skills, SC_CHAOSPANIC and SC_MAELSTROM, that cannot be placed near warp portal (according to iRO Skill Balance Patch)
-- Added 'db/skill_nonearnpc_db.txt' for more option of INF2_NO_NEARNPC (additional range beside splash area, unit range, or layout range calculaiton and type of NPC)
* Follow up 5e6626e
-- Fixed bugreport:6994, Preseve only prevent to copy skill via Plagiarism, player still able to copy skill by Reproduce
-- Re-structure db/skill_reproduce_db.txt becomes db/skill_copyable_db.txt that allow you customize the avaiable skill to be copied
-- Removed 'copyskill_restrict' config from conf/battle/skill.conf, this setting can be set on db/skill_reproduce_db.txt
-- Enjoy structure of skill_copyable_db.txt! SkillName,Option{,JobAllowed{,RequirementRemoved}}
-Add skill lists for :
--spell blocked by statis
--spell blocked by kagehumi
--spell range affected by
AC_VULTURE|GS_SNAKEEYE|NJ_SHADOWJUMP|WL_RADIUSRA_RESEARCHTRAP
--spell that can't be copied
--spell that can be using while riding warg|mado
-Add a boolean return value for delequip (script cmd)
-Fix monster (script cmd) hardcoded cap for ai. (was preventing to put
ai_faw)
--Add of skill_inf3, goal is to move out the hardcoded skill list in emulator to db. (and therefor allow user to easily modify them if they wish)
-Fix of possible segfault in battle.c since r17457 (sd might be null on the camouflage bonus)
--Also fixing the fact that camouflage bonus was staying permanently.
Map crash fix when casting Kaihou - Fixes bugreport:7962
Update Songs/Dances for Land Protector - Fixes bugreport:7913
Show baseATK increases in status window - Fixes bugreport:7960
Revert damage to int64 - Fixes bugreport:7939
- Also removed limit on Acid Demonstration
Changed Camouflage to increase Equip Attack - Partially fixes bugreport:7941
- Added missing item scripts for hundreds of items.
- Added many new item entries.
- Updated some existing scripts with new changes. (fixes bugreport:7201)
- Uncommented all disabled items.
Signed-off-by: Euphy <euphy@rathena.org>
Mechanic Neutral Barrier updated - Fixes bugreport:7874
- Blocks ranged and splash attacks
- Gives % bonus to DEF and MDEF
- Cannot be removed by Land Protector
- Updated to 5x5 AOE
- Can be cancelled by casting a second time
Stealth Field updated- Fixes bugreport:7816
- No longer blocks AOE damage
- Cannot be removed by Land Protector
- Updated to 5x5 AOE
- Can be cancelled by casting a second time
FAW Silver Sniper and Magic Decoy updated - Fixes bugreport:7871
- FAWs get HP and ATK or MATK bonuses correctly now
- New AI added for these
Maximize Power no longer stops SP regeneration in pre-re (credits: Evil) - Fixes bugreport:7881
Gate of Hell now updates ATK correctly to HP and SP levels (credits: Aleos) - Fixes bugreport:7886
Comet now works as intended when with other Warlocks (credits: malufett) - Fixes bugreport:7854
Fixed minor issue where setting a monster to an AI with a script command could cause an error.
Songs/Dances are now removed by Land Protector/Ganbantein (helvetica).
Updated homunculus ATK to support renewal attack.
Fixed an issue where Summon Legion mobs weren't getting the correct stats placed on them.
Cloaking fixed to official behaviour (Thanks helvetica for the hour of testing) - Concerning bugreport:171
Fixed instancing long map names causing crashes
- Cannot save or memo on instance maps (Lemongrass)
- Map channels are no longer activated on instance maps (Lemongrass)
- Fixed a character save issue with instance maps (Lemongrass)
- Map local channels are disabled by default, this is custom (Lemongrass)
- Just thank Lemongrass overall, I gave him a hard time with this issue
~ Hercules Merge ~
Update Bloody Lust and Maelstrom to official behaviour (Credits: malufett)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17408 54d463be-8e91-2dee-dedb-b68131a5f0ec
Please visit http://rathena.org/board/topic/84568-r17402-major-battleskill-system-overhaul-and-renewal-support/ for a complete and updated log of changes
General
* Forced neutral behavior documented and implemented. Weapon element does affect the following skills, but final damage is treated neutral for resistances. End result is endows do boost skill damage as expected given elemental weaknesses or resistances, but forced neutral skills will always miss on Ghost 3/4 mobs as the damage is "forced" back to neutral type after bonuses are applied but before resistances.
* The following skills are considered "forced neutral"
Merchant "Cart Revolution"
Creator "Acid Demonstration"
Genetic "Cart Cannon" (damage is forced to element of cannon ball, either neutral or holy or ghost)
* Weapon calculation engine has been rewritten to better emulate official behaviors and "quirks", the following changes have been documented and implemented:
Double attack takes priority over criticals when determining which effect activates
VITDEF (status or sDEF) is applied on every hit on multi-hit skills, rather than a flat reduction on the final damage total
Skills such as Spiral Pierce that differ when used by monsters modified to match official calculation methods
* Weapon element behavior adjusted to match official behavior, endows override any innate weapon element, including elemental arrows
* Renewal - weapon element only applies bonus damage to "weapon" ATK, ATK from status and equipment is considered neutral and ATK from mastery skills are considered non-elemental
Archer:
* Renewal - Owl's Eye still gives +1 HIT per skill level but the HIT bonus does not show up in the status window anymore
Hunter:
* Renewal - Claymore, freeze trap and landmine adjusted to apply full damage to "plant" type mobs (monsters that only take 1 damage on every hit)
Thief:
* Double attack gives a hidden +1 HIT per skill level on attacks that activate the double attack effect
* Envenom gives a flat +15 ATK per skill level when used, it is considered a mastery type damage and has no element
Rogue:
* Renewal - Owl's Eye still gives +1 HIT per skill level but the HIT bonus does not show up in the status window anymore
Assassin Cross
* Renewal - Soul Breaker formula for renewal implemented
((ATK + MATK) * (3 + (.5 * skill level)) - (eDEF + sDEF + eMDEF + sMDEF)
* Renewal - Soul Breaker no longer misses, it will always do full damage regardless of target's FLEE
* Renewal - Soul Breaker no longer gains DEF piercing or ignore DEF effect from weapons such as Combat Knife and Ice Pick
* Renewal - Enchant Deadly Poison for renewal implemented
Weapon ATK multiplied by (1 + (EDP level * .8))
Equipment ATK multiplied by (1 + (EDP level * .6))
* Renewal - EDP adds half modifiers (base damage/2) but otherwise functions as above with the following skills:
Sonic Blow
Soul Breaker
Counter Slash
Cross Impact
Creator
* Renewal - Acid Demonstration formula for renewal implemented
7 * ((ATK + MATK) / skill level) * VIT / 100 )
* Acid Demonstration adjusted to match "forced neutral" behavior on official
For example, Acid Demonstration used on a water-type mob with a wind endowed weapon will do bonus damage, but will miss on a Ghost 3/4 monster regardless of endow.
Swordsman
* Magnum break bonus damage gives +20% ATK fire damage on physical attack (so 100% ATK normal + 20% ATK fire)
Lord Knight
* Renewal - Spiral Pierce formula for renewal implemented
(ATK + (weapon weight / 2)) * (100 + (50 * skill level))%
* Renewal - Mastery skills such as spear mastery no longer add any bonus damage to Spiral Pierce
* Renewal - Spiral Pierce no longer ignores DEF
Ninja
* Renewal - Final Strike formula for renewal implemented
base damage = current hp + ((ATK * current hp * skill lvl) / max hp)
final damage = base damage + ((mirror image count + 1) / 5 * base damage) - (eDEF + sDEF)
* Final Strike will MISS on plant-type mobs (mobs that only take 1 damage per hit from all sources)
* Mirror Image cast over itself will override and reset current Mirror Image count
Genetic
* Cart Cannon "forced element" behavior implemented, damage is "forced" to the element of the cannon ball.
Ex. Cart Cannon fitted with a standard cannon ball and a fire elemental weapon will do bonus damage against earth targets, and a Cart Cannon fitted with a holy cannon ball will do bonus damage against shadow, but total damage is forced back to element of cannon ball and resistances applied against it. Neutral cannon balls will miss on Ghost 3/4 but holy/ghost/shadow will not.
Gunslinger
* Gunslinger Mine skill formula and behavior matched to official
Fixed 500 damage, ignores DEF and is affected by +% ATK weapon cards only
Warlock
* Tetra Vortex behavior modified to match official
First 4 spirit spheres are used for calculating element of each hit, but if 5 are present all 5 are consumed
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17402 54d463be-8e91-2dee-dedb-b68131a5f0ec
-> Updated documentation on changes
Updated Overbrand to a closer official area behaviour - Fixes bugreport:7651
Follow up to r17320 - Fix incorrect condition check (lighta)
Fixed status effects not being removed correctly (lighta, Akinari) - Fixes bugreport:7634
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17321 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed Bowling Bash, Brandish Spear, Grand Darkness and Meteor Assault reducing def during cast; the only skill that does this officially is Grand Cross (bugreport:7582)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17318 54d463be-8e91-2dee-dedb-b68131a5f0ec
* As many servers probably want to remove the gutter line problem, it is configurable; just adjust the bowling_bash_area setting in skill.conf
- Sonic Blow now has a fixed range of 1, even for monsters; a monster can't use this skill if you tank it from farther away (bugreport:3453)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17295 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Thorn Trap cannot be created near another trap, under a target, and has a maximum of 3 active. (bugreport:7488)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17283 54d463be-8e91-2dee-dedb-b68131a5f0ec
-> Note: Formulas were derived from iRO and then modified to roughly match with data growth tables presented by players
-> Note2: ATK formula is currently being multiplied until renewal attack is implemented because they were too weak with normal formula
> Follow up to r17262 - Reverted Death Bound change - bugreport:7549
Pyroclastic doesn't give insane ATK bonuses anymore - bugreport:7526
Weapon Refine and Forging now get straight bonuses when used by Mechanic - bugreport:7509
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17270 54d463be-8e91-2dee-dedb-b68131a5f0ec
Extremity Fist SP Cap raised to work better with renewal stats - bugreport:7455
Expanded Super Novice receives +10 stat bonuses for a 0 death counter - bugreport:7394
Renewal Assassin Cross of Sunset now includes AGI into the formula - bugreport:6604
Berserk job level check works as intended - bugreport:6960
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17262 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Changed a few for loops to ARR_FIND.
> Follow up to r17169:
* Clearance now properly works on mobs and no longer works on guild members.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17261 54d463be-8e91-2dee-dedb-b68131a5f0ec
-merge clif_guild_skillup and clif_skillup (old TODO)
-add implementation for packet : 0x8c7, 0x99f and 0x1c9, variant of ZC_SKILL_ENTRY (0x11f)
-replace some hardcoded skill_flag by enum values
-little cleanup in skill_attack and regroup some skill with same effect (blewcount, animation).
-rewritte combo handling to regroup info and not duplicate info.
-change eleanor skill to use SC_COMBO as memo instead SC_STYLE_CHANGE
-separate SC_TINDER_BREAKER from SC_CLOSE_CONFINE since they don't act same way
-change MH_SONIC_CRAW to one attack with multiple hit instead x attack.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17229 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed Raid to deal damage in a 7x7 area in renewal (bugreport:7381)
- Fixed success chance of Storm Gust's freeze status change in pre-renewal, iROwiki says 150% and feedback from official server players confirmed that it is indeed 150%
- Second phase of the big status resistance update:
* Created a structure to consider status change source (we are still missing the information and use a copy of target instead right now, lighta is working on a solution)
* Entered the fully official formulas of all status changes based on an Aegis leak (since source is not in right now the level difference will always give "0")
* As tick_def2 is never equal to sc_def2, it will not use it by default anymore
* Applied Deep Sleep's kRO balance update, duration can now be reduced by 50ms for each int and each base level, minimum duration is 5000ms
* The final chance for the status change will now consider Aegis accuracy (everything between 0.01% and 0.09% should actually be 0.1%, etc.)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17206 54d463be-8e91-2dee-dedb-b68131a5f0ec
*Updated a bunch of enum tables and other things.
-New NPC's, skill tags, status tags, equip masks, etc. are added with this update.
-Equip masks for costume robe and floor, will remain disabled until support for them is added.
-Shadow equips will require a newer client before they can be coded in.
-Hanbok costume job is added but is currently unusable since not all the coding to handle
-them is in.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17188 54d463be-8e91-2dee-dedb-b68131a5f0ec
* NPC_PIERCINGATT deals 75% damage, ignoring DEF
* NPC_COMBOATTACK deals 100%+25%*level damage spread on level+1 hits (note: it's not 100% fixed because of rA handling soft DEF wrong)
* NPC_RANDOMATTACK deals 100%*level damage with a random element
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17184 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Coluceo Heal has no fixed cast time at level 3.
- Increased the range for Expiatio to 11.
- Updated SP requirement for Clementia, Canto Candidus, Coluceo Heal, and Praefatio.
- Updated Epiclesis to be 5x5.
- Updated damage formula for Renovatio and Judex.
- Updated success chance and checks for Adoramus effects: Agi Down and Blind.
- Updated Highness Heal recovery modifier.
- Added a safety check for Clementia and Canto Candidus stat bonus to prevent possible server crashes.
- Coluceo Heal no longer works on players in Berserk.
- Lauda Ramus now clears Deep Sleep.
- Clearance is now only usable on selected allies in party/guild and monsters.
- Added missing attack and resistance check for Eucharistica.
- Added missing barrier bonus for Kyrie Eleison from Praefatio.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17150 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Crush Strike now lasts for 30 seconds.
- Phantom Thrust is now targeted to allies.
- Updated SP requirement for Death Bound.
- Giant Growth now has a .1% chance to break caster's weapon.
- Stone Hard Skin now has a 30% chance to break caster's weapon.
- Stone Hard Skin now has a 30% chance to reduce 25% damage from monsters for 10 seconds.
- Corrected Stone Hard Skin's DEF/MDEF increase formula.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17145 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Adjusted Wind Cutter and Storm Blast cast times.
- Removed range from Enchant Blade and updated damage formula.
- Increased Hundred Spear range to 5.
- Changed Dragon Howl attack type from weapon to none.
- Added missing damage increase for spears while riding a Dragon.
- Updated Sonic Wave, Wind Cutter, Ignition Break, Hundred Spear, Storm Blast, and Fighting Spirit damage formulas.
- Death Bound now deflects 70% of the damage taken back at the attacker.
- Vitality Activation now stops SP regeneration, increases (1.5x) HP recovery items, and decreases (1.5x) SP recovery items.
- Stone Hard Skin now consumes 20% HP.
- Corrected the formula for Millennium Shield production chance.
- Phantom Thrust is now usable on party members in normal maps but doesn't inflict damage.
- Updated the list of statuses that Refresh removes.
- Giant Growth now has a 15% chance to increase damage.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17140 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixed bugreport:6961 WL_COMET AOE range is now 15x15.
Fixed bugreport:5811 where SC_BLEEDING is not attach to caster to give exp.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17097 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixed bugreport:7101 where MO_EXTREMITYFIST don't consume sp when used against plant type monster.
Fixed bugreport:7116 missing duration for HW_MAGICPOWER.
Fixed bugreport:7117 where WL_WHITEIMPRISON doesn't work properly.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17078 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixed bugreport:6688 MO_EXTRIMITYFIST skill effect.
Updated all non 3rd job skills to there official RE cast time delays.
Updated WL_WHITEIMPRISON where cooldown should trigger whether success or not.
Added missing status icon for SC_MATKPOTION and SC_ATKPOTION.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17069 54d463be-8e91-2dee-dedb-b68131a5f0ec
Update Elemental summon to its official behavior
- Fixed missing skill features of Ventus(bugreport:6792,bugreport:6723,bugreport:6511)
- Note: upgrade_svn17014.sql
- And other elemental skills are to follow :)
Fixed bugreport:6889 updated const.txt where it cause error to some items.
Fixed bugreport:6999 where matk damage deals miss atk to plant type targets.
Fixed status calculation where it doesn't give accurate result or how official calculation does.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17014 54d463be-8e91-2dee-dedb-b68131a5f0ec
--Upd Skill conf to set land-limit for homonculus by default (ground skill limit)
--Mv MH_HEILIGE_STANGE and MH_ANGRIFFS_MODUS skill from Eleanor to Bayeri
-Enforce all zeny transaction to use pc_payzeny and pc_getzeny handlers, (auto log and clif)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16914 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixed bugreport:6710 where SR_EARTHSHAKER ATK bonus is not applied properly.
Implemented KO_MAKIBISHI and updated some Kagerou/Oboro skills.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16857 54d463be-8e91-2dee-dedb-b68131a5f0ec
*Updated a hand full of enum tables and added some place holders in the skill databases.
-Tables updated are the Emotions, Map Types, Use Skill Fail Causes, Skills, Units, and Status.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16812 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixed bugreport:6457 where SR_CURSEDCIRCLE is not remove when target dies.
Fixed bugreport:6535 updated GN_CRAZY_WEED to its official behavior.
Fixed bugreport:6592 added a missing break in Spiral Pierce skillratio at battle.c.
Fixed a faulty skillratio formula of GN_CART_TORNADO. Thanks to Lighta
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16738 54d463be-8e91-2dee-dedb-b68131a5f0ec
Partial fixed bugreport:6396 where Chemical Protection skills doesn't check targets current equipments.
Finally added almost all Kagerou/Oboro skills only one more left..phew...:D
(KG_KAGEHUMI,KG_KYOMU,KG_KAGEMUSYA,OB_ZANGETSU,OB_OBOROGENSOU,OB_OBOROGENSOU_TRANSITION_ATK,OB_AKAITSUKI)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16560 54d463be-8e91-2dee-dedb-b68131a5f0ec
