1008 Commits

Author SHA1 Message Date
Atemo
78edf851a0
Suggestion of implementation of is_party_leader and is_guild_leader script commands. (#3617)
* Implemented is_party_leader and is_guild_leader script commands.

Thanks to @cydh !
2018-11-06 16:28:09 +01:00
Lemongrass3110
7066cac9a4
Fixed some conditions in LV4 weapon quest (#3630)
Fixes #3627

Thanks to @SnotraRM
2018-10-28 16:30:40 +01:00
Atemo
9780b461f5
Clean-up HTF instance and fixed a quest warning in High Laphine#grenouille npc (#3457) 2018-09-01 22:19:24 +02:00
zackdreaver
91667a9a11 Update Renewal and Pre-renewal Morocc NPCs (#2977)
Fixes #3392 

Thanks to @zackdreaver, @AzarthMZintos and @Lemongrass3110
2018-08-17 10:27:26 +02:00
BrOgBr
fa4021d217 Fixed a mistake in 2008 headgear quest (#3344)
Fixes  #3343

Thank you @Kutikuti
2018-07-25 21:04:16 +02:00
Atemo
7a8ac46421
Banquet for Heroes ep 16.1 (#3234)
Banquet for Heroes ep16.1 - walkthrough conversion
* Added main quests of ep16.1 and the quests entries
*** Walther's daily quest will be enabled after quest_db refactor
* Added instances Ritual of Blessing and Room of Consciousness
* Added monsters spawn and entries on prt_prison, prt_cas and prt_q maps
* Prontera castle map changed in this ep
- Moved some NPCs from prt_castle to prt_cas
- Added warps on prt_cas
- Succession of the Prince quest is removed in ep16.1

Thanks to @admkakaroto, https://www.divine-pride.net/ 
@yoonjunho72, @teededung, @ecdarreola, @spinzaku and to all the contributors !
2018-07-13 15:49:33 +02:00
Atemo
12f62e6302
Quest warning in quests_amatsu.txt (#3296) 2018-07-07 15:53:25 +02:00
Atemo
532e043490
Fixed issue #3286 and corrected npc name (#3287)
Thanks to @AzarthMZintos !
Fixed #3286
2018-07-05 02:13:12 +02:00
Atemo
6e8599cd5b
Extra npc checks (#3274)
* Extra checks
- Added some extra check in npcs script to prevent wrong behaviour
2018-07-03 23:24:04 +02:00
Atemo
3a8814ac4e
Fixed Regenschirm Guard Laboratory Permit issue (#3056)
Thanks to @juanfus !
2018-04-16 17:01:01 +02:00
syracuase
8530a7b1fe Job Level check for Blacksmith and Alchemist (#2819)
* Job Level check for Blacksmith and Alchemist
2018-01-21 14:51:38 +01:00
Lemongrass3110
16780638be
Fixed a few name typos with Niflheim (#2782)
Thanks to @Daegaladh for his input
2018-01-09 23:36:20 +01:00
Lemongrass3110
a65e7dbf46 Fixed F_SexMes call
Fixed #2785

Thanks to @insanchen
2018-01-07 21:07:34 +01:00
Cydh Ramdh
bb4a88a362
Update Megingard Seal Quest
* Wrong Item ID for for Baphomet Doll (750). 744 is Bouquet
2017-12-06 08:24:55 +07:00
Atemo
ea88ea5054
Emoticons constant name (#2527)
This PR change the emoticons constant name to match emoticonlist from client side.
Note: the previous emoticons names are now deprecated.

Additionnally emotion and unitemote scripts commands are being merged together to the new format
-> emotion <emotion number>{,<target>};
Where target use the target Game ID (GID) of the unit (npc, pet, character etc..).

* unitemote is now deprecated.
* Additionnally fixed incorrect variable in quests_brasilis.txt

Thanks to @aleos89 and @Lemongrass3110 !
2017-11-10 18:35:21 +01:00
Lemongrass3110
f42c2ff211 Moved some remaining constants into src (#2501)
* Moved all npc view constants into src

Source side the constants will use Gravity's naming standard(JT_*)
NPC side still supports the old names without JT_

* Moved all effect constants into src

Added check for effect validation to atcommand effect and all script commands using them
Removed the unused and broken function unit_changeviewsize from unit.c
Replaced a lot of hardcoded effect ids with their respective constants
Cleaned up the effect documentations

* Moved all hat effect constants into src

Added check for effect validation to script command hateffect
2017-10-14 18:13:51 +02:00
keitenai
f4de91b407 Fixed incorrect use of 'close' command 2017-08-14 23:25:29 +08:00
Jeybla
9e6b02ae59 Fixes a getcharid error message. (#2106)
* In quests/quests_morroc.txt Continental Guard.
2017-04-29 19:20:25 +02:00
Atemo
73b798bf12 Removed extra semi-colon 2017-04-06 14:40:36 +02:00
Atemo
f6488a2a9e Corrected a warp destination typo in The Sign quest (credit c215c9c21a) 2017-03-06 23:26:10 +01:00
Atemo
c6e09fdf35 Added parenthesis in tu_ma_th01.txt 2017-03-06 23:21:05 +01:00
Lemongrass3110
800f22b77b Removed an unused character variable
Fixes #1976
2017-03-02 23:20:45 +01:00
Atemo
c6470ff4ff Clean-up permanent monster spawn: (#1831)
* Clean-up permanent monster spawn:
- <delay1>,<delay2>,<event> are actually optionnal field
- <event> value 0 and 1 are meaningless (actually event name with length < 4 are skipped)

* Exported monster AI constants

* Updated docs for monster size constants (already exported)
Notes:
- the default size for monster script cmd was small not medium
- monster script cmd now display a warning for size above SZ_BIG (previously SZ_ALL)

* - Fixed an issue to make <xs> and <ys> optionnals
- Updated npcs scripts

* Leftover in the docs for permanent monster spawn

* Corrected english docs. Credit to @aleos89
Added additionnal warning for xs / ys negative input. Credit @Lemongrass3110 

Thanks to @cydh for the idea
2017-01-22 19:03:08 +01:00
Lemongrass3110
2043c95e66 Refactored hardcoded npc event names (#1767)
While refactoring those events the following other changes were made:

Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.

The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.

All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).

All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).

Renamed a few events in the script configuration to match the other names

Added constants for months and weekdays

Additionally added constants for gettime types to make it easier to read.

Replaced all existing usages I found with their proper new syntax or better fitting functions.
2017-01-10 22:58:04 +01:00
Lemongrass3110
988bf12887 Fixed announces from Koschei the Immortal
Original Commit HerculesWS/Hercules@dbc54ea
Thanks to @landergate
2017-01-06 17:15:19 +01:00
Atemo
a9faab82cb Fixed incorrect OnTouch label in Crow of Destiny Quest (issue #1840) and in Guild dungeon 2 event. Thanks @Tokeiburu 2016-12-29 23:00:37 +01:00
Cydh Ramdh
2896d894d1 Official Random Coordinates for Savepoint (#1756)
* Added parameters for `savepoint are range for `x` and `y` for random savepoint coordinates.
* Added documentation for new savepoint params. Credits to @aleos89
* Updated savepoint on script to follow official behaviour (random save in 3x3). All credits to @Atemo
2016-12-20 17:16:42 +07:00
Atemo
45bc42c305 Fix wrong command usage at sign quest
Credit Hercules@47834e8f6db03689595946af0cd95748005126c7
2016-12-09 19:58:01 +01:00
Lemongrass3110
9040613fa6 Added missing empty newlines to a lot of files 2016-11-23 13:54:45 +01:00
Lemongrass3110
9b1b7b1a2b Replaced hardcoded genders with constants (#1730)
* Replaced hardcoded gender codes in source

Introduced a new constant for the account based gender and replaced all hardcoded gender references to code 99 with it.

* Replaced hardcoded gender codes in npcs

Exported the gender constants into the script engine and replaced all usages with references to the constants instead of expecting a value behind them.

* Corrected a typo

Thanks to Machiezmo from Discord.

* Fixed an inverted gender logic

Thanks to @secretdataz
2016-11-22 21:20:03 +01:00
Atemo
afd6f2027d Fixed potential script (*)quest warning 2016-11-13 17:58:20 +01:00
Lemongrass3110
56c9765fe0 Fixed a wrong close in the eye of hellion quest
Merges HerculesWS/Hercules@d8441a3
Thanks to @Ridley8819
2016-10-18 22:49:18 +02:00
Jittapan Pluemsumran
4ef35f4d1f
Added missing close; in Ayothaya shaman 2016-09-09 16:58:15 +07:00
Atemo
d62f422e3d Corrected OnTouch/OnTouch_ in NPC script (#1548)
Some leftover from aegis convertion..

Skipped pre-re folder, I don't have old data.
2016-09-07 21:35:14 +02:00
Lemongrass3110
818727f7ef Fixed wrong usages of specialeffect (#1529)
* Fixed wrong usages of specialeffect

* Missing fix
2016-08-31 20:36:17 +02:00
Atemo
c488268d8c Juperos Ruins History Quest:
- Added default arguments in function Func_JupHist to avoid being stuck (fixes #1444)
- Implemented quest log

Investment Rewards:
- Added missing Elemental Converter menu selection
2016-08-11 21:59:25 +02:00
Lemongrass3110
a855bccfd2 Fixed wrong operator usage in 2 scripts
If those fixes are wrong blame it on me!
2016-08-05 00:29:03 +02:00
Lemongrass3110
d017e24cd2 Adjusted some scripts to the new syntax
Follow up to fd48238
Thanks to @Everade and @Jeybla for reporting this problem in #1468
2016-08-05 00:28:23 +02:00
Jittapan Pluemsumran
2f9d44c3b1
Changed Job_SuperNovice to Job_Super_Novice in scripts to match source-side constant. 2016-07-08 14:32:10 +07:00
Atemo
109b30dd51 Fixed EndlessTower.txt : officially a player can't enter in endless tower if he has changed party and he already entered in the instance with his previous party. Thanks to RagEmu/Renewal@73ec00faa5
Fixed potential quest warning in SealedShrine.txt and quests/quests_13_1.txt
2016-07-03 02:06:52 +02:00
Jittapan Pluemsumran
933d6879d3 Fixed #1405.
Changed a misplaced close to end
2016-06-29 20:59:26 +07:00
Atemo
94b866e938 Fixed issue #1382 (quest error)
Thanks @anacondaqq
2016-06-23 02:25:31 +02:00
Atemo
85f44a587d Removed useless lines 2016-06-22 15:50:40 +02:00
Jittapan Pluemsumran
055ee42b3d
Fixed #910. Added weight check in Ring of the Wise King Quest.
Thanks to @Jeybla for the changes and @Akaineko-astasi for the report.
2016-06-12 20:28:50 +07:00
Atemo
7d6be7e21e Add F_getpositionname to return the EQI_* name 2016-04-18 15:50:28 +02:00
Atemo
05a1b61bed Correct script part 2016-04-16 16:45:33 +02:00
Jittapan Pluemsumran
bd6539a9ba Follow up to c23688c
Unify all checks into one function.
Suggested by @Cydh.
2016-03-26 10:52:30 +07:00
Jittapan Pluemsumran
c23688cea4 Clean up basic skill checks 2016-03-23 21:11:57 +07:00
Atemo
7574a726b0 Fixed issue #1072 to learn bioethic again 2016-03-22 15:23:46 +01:00
Aleos
d378ef2a0b Merge pull request #1054 from AtlantisRO/master
Fixes to some quests and typo errors
* Corrected miscellaneous Korean to English translations.
* Corrected the position and facing direction of NPC [Promotional Staff#iz] from [Onward to the New World] Quest (pre-renewal).
* Fixed NPC [Iromo's Mother#ep3_2] from [Alberta Boy] Quest where players could have their quest progress reset.
* Fixed NPC [The Blacksmith#rus06] from [Koschei the Immortal] Quest giving Iron_Boots01 instead of Iron_Boots02 to Ninja and Gunslinger classes.
Thanks to @AtlantisRO!
2016-03-15 09:56:16 -04:00