700 Commits

Author SHA1 Message Date
Daegaladh
43f6577abe Fixed GVG and BATTLEFIELD race2 IDs 2020-06-19 02:15:50 +02:00
Aleos
3804d7f603
Adds support for instance destruction button (#5073)
* Adds support for instance destruction button
* Adds an extra parameter in the instance database to toggle if an instance is destroy-able or not.
* Adds support for being notified about character and Clan instances on login.
* Fixes an issue with the instance window displaying wrong instance information on an instance map when multiples instances were running for the character.
Co-authored-by: atemo <capucrath@gmail.com>
2020-06-17 14:52:22 -04:00
Lemongrass3110
d87ac21986
Added support for skill scale display (#5041)
Fixes #4530

Thanks to @Balferian
2020-06-04 19:53:19 +02:00
Aleos
70d6876494
Corrects NPC_DARKBREATH behavior (#4982)
* Fixes #4864.
* Adjusts damage formula to official.
* Adjusts damage type from Misc to Magic.
* Skill now has a 50% success chance to damage the target.
* Removes Flee and Defense Card ignore flags.
Thanks to @Masao87 and @mrjnumber1!
2020-05-20 18:50:04 -04:00
Aleos
fde031fb19
Job Improvement Project - Minstrel/Wanderer (#4701)
* Fixes #4211.
* kRO Changelog: http://ro.gnjoy.com/news/update/View.asp?seq=235&curpage=1
* kRO Changelog 2: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Angelic234, @Litro, @LordWhiplash, @Feelmeone, @ecdarreola, and @teededung!
2020-05-18 09:44:12 -04:00
Aleos
061e586a1f
Few Genetic skill fixes (#4813)
* Fixes Acid Demonstration to use the target's VIT and not casters.
* Fixes Fire Expansion - Acid to behave like Acid Demonstration.
* Fixes Crazy Weed not doing 2 damage attacks.
* Crazy Weed is now a long ranged physical attack.
* Adjusts Hell's Plant behavior to no longer be removed on map change.
* Adds missing status icon for Hell's Plant.
* Fixes Hell's Plant attack formula when learning Summon Flora.
* Hell's Plant now uses the caster's weapon as the element.
* Hell's Plant no longer ignores the target's DEF and Element.
* Fixes Hell's Plant removing Thorns Trap.
* Removes fixed cast time from Xeno Slasher.
* Adds new Genetic Pharmacy potions (items are disabled until int32 item ID support).
* Fixes Spore Explosion's splash attack doing the same damage as the initial.
Thanks to @teededung, @Badarosk0, @cahya1992, and @OptimusM!
2020-05-13 21:02:57 -04:00
Aleos
c5a0279b5c
Adds skill placeholder for Super Novice Expanded (#4919)
* Adds skill placeholder for Super Novice Expanded in the pre-renewal skill database.
* Prevents undefined skill errors for pc_checkskill.
Thanks to @gidzdlcrz!
2020-05-11 14:08:33 -04:00
Aleos
8f19cfc3a1
Fixes Weapon Crush and Weapon Blocking combo (#4809)
* Fixes #4808.
* Weapon Crush now uses SC_WEAPONBLOCK_ON to track the target instead of SC_COMBO.
* Also fixes Quick Draw Shot target selection.
* Quick Draw Shot and Weapon Blocking should be considered a combo and not end physical attacks when casting them.
* SC_QD_SHOT_READY will no longer become active if the player has 193+ ASPD.
* SC_QD_SHOT_READY will now end once Quick Draw Shot has been casted.
* Cleans up skill_check_condition_sc_required and removes duplicate code.
Thanks to @wdivet, @LordWhiplash, and @ecdarreola!
2020-04-30 12:17:50 -04:00
Aleos
2ca94ad411
Adds back removed skills from kRO (#4803)
* Fixes #4802.
* Adds back AB_EUCHARISTICA, GN_SLINGITEM, and GN_MAKEBOMB.
* Adds back CR_CULTIVATION for renewal.
* Skills are disabled in the skill tree database but gives easy ability to re-enable.
* Fixes an issue with pre-renewal produce database spitting errors when using any production-type skills.
Thanks to @trinitynetworks!
2020-04-30 09:33:38 -04:00
Cydh Ramdh
d9ab23ae0f
Fixed Max HP & SP rate bonus (#4828)
* Fixed #4264
* Added new SCs for proper HP & SP Pill usages
* Thanks to @Daegaladh
2020-04-24 11:53:08 +07:00
~Neutral~
af8c4ff6d7
Fixed flags of 2 skills in prere (#4520)
Fixes #4498
2020-04-09 18:00:11 +02:00
Aleos
06c159c405
Refactored Instances to utilize C++ features (#3163)
* Fixes #3087 and fixes #3095.
* Converts database file to YAML.
* Converts static array to unordered_map which frees up pre-allocated memory that may never be fully used.
* Got rid of all DBMap/ERS features.
* Removes MAX_INSTANCE_DATA in favor of INT_MAX.
* Includes TXT converter.
Thanks to @Lemongrass3110, @secretdataz, @Atemo, @lighta, @InusualZ, @Angelic234, @Normynator, @cydh, and @ecdarreola!
2020-04-08 12:52:45 -04:00
Aleos
af8dd8b28d
Fixes issue with power skills (#4751)
* Fixes #4743.
* Resolves an issue with power skills and default data defined in the skill's array.
* Adds back linear determination and documentation for it.
* Adds a check in the converter to not print out values of 0 for levels 6 and higher for skill unit layout and skill unit range.
* Removes these values from the skill database.
Thanks to @Surefirer and @teededung!
2020-04-06 10:44:17 -04:00
Aleos
6edcf4a3a1
Fixes Wall of Thorn knockback (#4685)
* Fixes #4645.
* The knockback should be based on self and not the caster of the skill.
Thanks to @devLOOLP!
2020-03-31 08:20:04 -04:00
Aleos
2f326bf04a
Converted Quest Database to YAML (#4064)
* Changes TimeLimit format to be human readable.
* Converts title to string.
* Converts objectives and drop items to vectors.
* General clean ups and optimizations.
* Got rid of dummy_quest.
* Added TXT to YAML converter.
Thanks to @Atemo and @Normynator!
Co-authored-by: atemo <capucrath@gmail.com>
2020-03-30 13:17:19 -04:00
Aleos
652d77eb02
Job Improvement Project - Genetic (#3284)
* Fixes #2571.
* Updates Homunculus skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=218&curpage=1
* Updates Genetic skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=246&curpage=1
Thanks to @Tokeiburu, @Badarosk0, @Balferian, and @Haydrich!
2020-03-25 13:26:26 -04:00
aleos
0021b6d577 Revert "SQL synchronization"
This reverts commit 53761b952af832455526401acfc8b388a60a5d84.
2020-03-24 17:49:00 -04:00
rAthenaAPI
53761b952a SQL synchronization 2020-03-24 18:38:07 +01:00
Aleos
412d90048d
Implemented Star Emperor and Soul Reaper classes (#4386)
* Initial implementation of these two classes skills.
* Includes kRO balancing patch: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3921697
Thanks to @Rytech2, @Mateuus, @nubspixel, @exneval, @idamonli, @hotspicy945, @admkakaroto, @cahya1992 and @RagnaWay!
2020-03-24 13:37:58 -04:00
Aleos
ea8da71cdd
Rebalancing of 1st/2nd/Transcendent class skills (#4072)
* Fixes #3715.
* kRO changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7040
* Refactored size_fix database to YAML.
Thanks to @flamefury for his translations!
Thanks to @Angelic234, @mrjnumber1, @Badarosk0, @OptimusM, @attackjom, @Playtester, Melvo, @cydh, @cahya1992, Sigma, @whupdo, @teededung, @ecdarreola, @hotspicy945, @RagnaWay, @sader1992 for bug testing!
2020-03-06 10:57:19 -05:00
Aleos
97372ff423
Adds reload attendance database atcommand (#4657)
* Fixes #4656.
* Adds an atcommand option for reloading the attendance database.
* Adds missing headers for attendance database.
* Adds missing reload options in the atcommand configuration.
Thanks to @lelouch22's suggestion!
2020-02-23 17:10:17 -05:00
Aleos
1c653616a0
Corrects Feint Bomb knockback (#4632)
* Fixes #4631.
* Feint Bomb should make the user backslide cells equal to the level used.
Thanks to @reunite-ro!
2020-02-11 17:05:20 -05:00
Aleos
86d72dfd78
Resolves Tetra Vortex AoE (#4624)
* Fixes #4623.
* Resolves Tetra Vortex levels 6-10 not doing an AoE.
* Adds placeholder for missing cast time for levels 6-10.
Thanks to @Miraakol!
2020-02-10 17:39:28 -05:00
Aleos
a74978b258 Fixes SpiritSphereCost negative values
* SphiritSphereCost has potential -1 value to remove all available spirit spheres.
Thanks to @teededung!
2020-02-10 10:57:16 -05:00
aleos
e4046f9d18 Fixes Duration1 and Duration2 negative values
* Duration1 and Duration2 have potential -1 value to send infinite tick for statuses.
Thanks to @teededung!
2020-02-09 11:54:19 -05:00
Aleos
c6fe237ed8
Corrects Soul Staff and Wizardry Staff view ID (#4610)
* Fixes #4599.
* Corrects the view ID for Soul Staff and Wizardry Staff to be 2H
Staves.
Thanks to @NeutralDev!
2020-02-07 12:37:49 -05:00
Aleos
e6a6c0533c
Updated 3rd class from RO 16th Anniversary Patch (#3659)
* Fixes #3602 and fixes #3653.
* Updated the 3rd class skills according to the RO 16th Anniversary Patch.
* Complete changelog here: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3890090&curpage=1
Thanks to @Badarosk0, @OptimusM, @Victor214, @Rytech2 and @laziem!
2020-02-07 10:39:35 -05:00
Lemongrass3110
83da86c301 Fixed ITEM_ENCHANTARMS and LG_SHIELDSPELL
Fixes #4604
Also fixes csv2yaml for highly customized skill databases.

Thanks to @mazvi
2020-02-05 23:40:59 +01:00
Aleos
fb30275e89
Added SA_TAMINGMONSTER to pre-renewal (#4595)
* Added Taming Monster to pre-renewal Abra database.
Thanks to @mrjnumber1!
2020-02-03 21:54:02 -05:00
aleos
abc027b47f Skill YAML fixes
* Fixes an issue with knockback converting the wrong column.
* Fixes an issue with skills containing multiple elements converting the wrong column.
Thanks to @mazvi and @Lemongrass3110!
2020-02-02 13:42:53 -05:00
Lemongrass3110
5cf7aceb2a Fixed some bugs with the new skill db
Fixes #4590

Thanks to @mazvi
2020-02-02 16:04:11 +01:00
aleos
7bdfe81867 Skill Ammo requirement fixes
* Fixes #4589.
* Resolves an issue with the skill converter outputting the incorrect ammo type requirement.
* Also fixes an issue with physically attacking targets while having a status option active.
Thanks to @mazvi!
2020-02-01 16:06:13 -05:00
Aleos
dca3797d44
Converted the skill database to YAML (#4531)
* Combines skill_cast_db, skill_castnodex_db, skill_copyable_db, skill_nonearnpc_db, skill_require_db, and skill_unit_db into skill_db.
* Introduces a cached YAML class for quicker lookups.
* General cleanups and optimizations.
* Includes CSV2YAML conversion tool.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2020-01-31 14:14:08 -05:00
Aleos
271489960a
Corrected Feint Bomb infinite status (#4550)
* Fixes #4508.
* Resolves an issue where Feint Bomb was giving users infinite duration from AoE statuses.
Thanks to @laziem!
2020-01-23 16:09:52 -05:00
Daegaladh
2533408bad
Added missing sub-races to pre-renewal (#4510) 2020-01-04 13:02:01 +01:00
aleos89
84bdf59e36 Removed pre-renewal Magic Mushroom database 2019-12-18 12:27:57 -05:00
Aleos
d56553775a
Converted Magic Mushroom Database to YAML (#4482)
* Split database into pre-renewal and renewal.
* Left pre-renewal database empty.
2019-12-17 16:07:17 -05:00
Daegaladh
354c632732
Fixed place names and other typos (#4475)
* Fixed common misspelled names from iRO and other typos.
2019-12-15 20:55:19 +01:00
Aleos
24c4c49610
Job Improvement Project - Sura (#4256)
* Fixes #4210.
* kRO Changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7099
Thanks to @flamefury, Sigma, and @attackjom!
2019-10-18 13:10:17 -04:00
Aleos
783009d642
Updated Achievement EXP to official values (#4326)
* Added the official values for the AG_GOAL_ACHIEVE.
* Refactored the leveling logic for Achievements to account for the new values.
* Moved achievement EXP to a database file.
* Added AchievementLevel player variable to allow for easy tracking in the achievement condition checks.
* Cleaned up player GUI EXP progression.
* Added a check to not save achievements that made no changes.
* Added first login achievement.
Thanks to @Lemongrass3110!
2019-10-11 09:42:01 -04:00
Aleos
bbca9efd57
Added new achievements (#4368)
* Added new achievements
* Reordered some older achievements by ID.
* Fixed memory management on duplicate achievements.
Thanks to @Lemongrass3110!
2019-09-30 11:27:49 -04:00
Jittapan Pluemsumran
08d160aaac
Added multi-hit critical damage display support (#2982)
* Fixed #1788.
* Double Attack and Fear Breeze can now critically strike.
2019-09-17 14:48:29 +07:00
Aleos
fc2c6e021d
Corrected Magnum Break delay (#4248)
* Fixes #4191.
* Magnum Break should have an aftercast delay of 2 seconds which can be reduced by Bragi (like all other skills) and no cooldown.
Thanks to @Playtester!
2019-07-16 11:07:14 -04:00
Aleos
53f5013149
Added an item group for Token of Siegfried (#4047)
* Fixes #4041.
* Created an item group used to remove hard coding of Token of Siegfried.
* Added the other Token of Siegfried's to work with this feature.
Thanks to @daisyanne1380!
2019-04-19 10:33:35 -04:00
Atemo
04c6303eb9
Implemented (the old) Nightmarish Jitterbug instance (#4061)
* Implemented NPC_REVERBERATION (some parts are from https://github.com/idathena/trunk credit to @exneval)

Credit to @RagnarokNova for some texts correction and for the monster spawn ([source](https://rathena.org/board/topic/104496-nightmareish-jitterbug-episode-143/))
Credit to https://www.divine-pride.net/ for the monsters datas.
2019-04-13 15:12:30 +02:00
Aleos
1504507e71
Fixed pre-renewal pet fullness values (#4074)
* Fixes #4073.
* Corrected the fullness values for pets.
Thanks to @sader1992!
2019-04-04 07:42:06 -04:00
Jittapan Pluemsumran
ac558d7c1e
Initial implementation of pet evolution system + Pet DB conversion to YAML (#3544)
* Implemented official pet evolution system
* Added evolved pets to pet database
* Corrected various pet system mechanics
* Migrated pet database to YAML format and the converter from CSV format

Thanks to @Lemongrass3110 @aleos89 and @Atemo for their suggestions and additional fixes
2019-03-26 22:51:57 +07:00
Aleos
9f4a569ecc
Implemented Magma Eruption Dot Damage (#3929)
* Fixes #3898.
* Implemented Magma Eruption Dot Damage which is the second attack for Magma Eruption.
Thanks to @exneval and @Balferian!
2019-03-25 10:29:21 -04:00
Aleos
972a14e4ed
Corrected Rebellion cast times (#3928)
* Fixes #3858.
* Corrected cast times and duration for several Rebellion skills.
Thanks to @siriousb!
2019-03-23 17:38:13 -04:00
Aleos
d1b35db768
Corrected Summoner's base ASPD (#4008)
* Fixes #3716.
* Corrected Summoner's base ASPD rates.
* Removed rates for Dagger, Book, and 2H Staff.
Thanks to @Balferian!
2019-03-19 18:25:40 -04:00