2817 Commits

Author SHA1 Message Date
Cydh Ramdh
c6ba813994 Bug Fixes:
* Wrong calls, should be callfunc. Thank @raynra
* Follow up 8256194, updated const.txt following new MAPID values for Super Novices
  * EAJL_SUPER_NOVICE	0x8000, for Super Novice masking
  * EAJ_SUPER_NOVICE	0x8100
  * EAJ_SUPER_BABY	0xA100
  * EAJ_SUPER_NOVICE_E	0xC100
  * EAJ_SUPER_BABY_E	0xE100

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-09-30 09:52:29 +07:00
lighta
7bedf4353b Add gdb check for configure suggestion on bugreport:4645.
Add the missing update in infinite_warp.txt
2014-09-07 09:01:19 -04:00
Euphy
3c24f458ce Hunting Missions script update.
- Added check for deleted characters. (credits: @AnnieRuru)
- Modernized script syntax and improved readability.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-09-01 13:33:39 -04:00
Euphy
403c22bc4b Documentation cleaning.
- Formatting and grammar edits on recently added docs.
- Added missing NPC header and script conf include from ea8ccfc.
- Moved ER model files to a separate folder ('doc/model/').

Fixed a typo in Wolfchev instance. (bugreport:9263)
http://rathena.org/board/tracker/issue-9263-wolfchevlaboratory-script-error/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-31 12:09:38 -04:00
lighta
ea8ccfc82e Add rewarp_count counter to prevent infinite warp loop.
bugreport:9130 (cpu-usage-goes-to-100)
2014-08-29 16:05:41 -04:00
Euphy
30b4d578a7 Some script cleaning.
- Replaced lots of numerics with constants.
- Added spacing to make some scripts more readable.

Fixed a mistake in 14fddd3.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-23 15:17:59 -04:00
Euphy
3b2762ca3c Enable NPC logging through 'logmes' by default.
- Commented some unnecessary log messages.

Bug fixes:
- M_DOPPELGANGER had too much HP. (Hercules 9cd3ec0)
- Huuma_Swirling_Petal should not have an element. (bugreport:9073)
http://rathena.org/board/tracker/issue-9073-huuma-swirling-petal/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 16:06:32 -04:00
Euphy
14fddd3790 Added script checks against swapping items using third-party hacks.
- Follow-up to 416f6d7, as further protection against item exploits.

Contains a few other fixes.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-22 15:36:23 -04:00
Euphy
880903bdab Updated Renewal Izlude Magazine & Bullet dealer locations.
- Coordinates taken from a recent iRO update.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-17 15:13:24 -04:00
Euphy
17bace0ae6 Script bug fixes.
- Added Renewal location for "Knight De Thomas" NPC (previously inaccessible), and upgraded the script to the latest version.
- Fixed Pre-Renewal Merchant Quest questlog commands. (bugreport:9218)
http://rathena.org/board/tracker/issue-9218-merchant-quest-add-error-quest-add-1010/
- Corrected a handful of 'rand(1)' statements.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-08-16 19:10:19 -04:00
Capuche
5f8a451913 Little clean-up
Signed-off-by: Capuche <capucrath@gmail.com>
2014-08-09 22:16:24 +02:00
Capuche
77549f76ab Updated to match official version & clean-up in quests_airship.txt
Signed-off-by: Capuche <capucrath@gmail.com>
2014-08-03 02:54:02 +02:00
Capuche
caa80ecfc7 Clean-up in quests/first_class folder
Signed-off-by: Capuche <capucrath@gmail.com>
2014-08-01 16:20:24 +02:00
Capuche
5dc6b749e1 Bug fixes in quests/quests_moscovia.txt
-- Added questlog support on The Moving Island, Help Mikhail, Banish Winter quests
-- fixed bugreport 8532

Signed-off-by: Capuche <capucrath@gmail.com>
2014-07-22 03:30:21 +02:00
Capuche
0cdc85cd4d Quick fix in cluckers.txt
The players could talk to clucker without dying.

Signed-off-by: Capuche <capucrath@gmail.com>
2014-07-17 21:52:00 +02:00
Capuche
ec485afe4c Bug fixes and clean-up :
-- Miscs follow up af266777402e07428388e80db35544fbb9bcbe8e
-- Another clean-up in comodo_gambling.txt (thx @SkittleNugget)
-- Replaced occurrence of PcName and clean-up in tu_magician01.txt

Signed-off-by: Capuche <capucrath@gmail.com>
2014-07-13 21:48:09 +02:00
lighta
79f4600dcd -Fix some CppCheck
-Fix bugreport:9088 (constant not always recognize if stating by number) thx to Hercule is_number
-Add infos on read_constant for check/debug
2014-07-04 11:22:40 -04:00
Capuche
af26677740 Bugfix and clean-up
- Added NPC const
- Added checkdragon() in F_CashReset
- Clean-up books.txt, fortune.txt, card_trader.txt, 3rd_trader.txt, stone_change.txt, quests_brasilis.txt
- Minor fix about Weight in comodo_gambling.txt
- Change to F_GM_NPC function in Mercenary Guild Switch follow up bdab851129ceee57a38ccc9d819b42011ef19fb7
- added Mercenary Switch in gm_npcs.txt list
- change to common green maiden in 2010 Headgear Quests

Signed-off-by: Capuche <capucrath@gmail.com>
2014-07-04 02:14:30 +02:00
Capuche
bdab851129 - Added mercenary guild switch npc from aegis
- Fixed a bug to rent a mercenary in izlude duplicate (it gave a wrong mercenary)
- added a missing delitem in cupet.txt (forgot to delete the 2nd item)
- change the rand part in Mysterious Documents npc in magic_books.txt to match aegis
- little clean up in quests/ninja_quests.txt
- replace the npc id to the constant in theses files

Signed-off-by: Capuche <capucrath@gmail.com>
2014-06-30 17:07:05 +02:00
Euphy
5e261ba415 Minor cleanup of riding script commands.
- The 'checkriding()' function no longer checks for wargs and dragons, ONLY Pecos, Grand Pecos, and Gryphons (as documented). (bugreport:9024)
http://rathena.org/board/tracker/issue-9024-about-renters-from-rathenanpcremerchants/
- Replaced 'checkoption()' warg checks with 'checkwug()'.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-06-10 22:58:09 -04:00
Capuche
be1fd7b1fa - Fixed an issue in dual race (bugreport 8636).
- Optimizated.
2014-05-30 20:48:19 +02:00
Capuche
45a7abcf4e - Updated docs about strmobinfo.
- Fixed an exploit in jobmaster.txt
2014-05-30 20:46:23 +02:00
Euphy
2688d78e6a Added a few missing 'changequest' commands to Alchemist job quest. (Hercules 4b4e573)
Minor cleanup in Wolfchev's Laboratory script.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-05-18 08:36:12 -04:00
Euphy
dd9719de62 Implemented Wolfchev's Laboratory instance. (credits: Hercules 1a477c4)
Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-05-13 15:34:56 -04:00
Euphy
484d3cc710 Job database updates. (Hercules 5a5a327)
- Updated Job Stat Bonus tables.
- Updated Renewal Star Gladiator EXP table.
- Small changes to Renewal Stat Point table.

A few item database updates/fixes. (incl. Hercules 0604877)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-04-25 18:16:59 -04:00
Euphy
684c336d49 Item-related bug fixes and other miscellaneous fixes.
Item fixes:
- Fixed Tikbalang Card and Lichtern * Card itemscripts. (bugreport:8834)
http://rathena.org/board/tracker/issue-8834-lichtern-cards-tikbalang-card/
- Added Rudo Card itemscript. (bugreport:8833)
http://rathena.org/board/tracker/issue-8833-rudo-card/
- Fixed itemscript for Wild Rider Card. (bugreport(8898)
http://rathena.org/board/tracker/issue-8898-wild-rider-card/
- Added some constants in item database. (part of bugreport:8831)
http://rathena.org/board/tracker/issue-8831-gioia-card/
- Updated a few other Renewal items.

Other fixes:
- Updated Malaya and Biolab 4 spawns. (Hercules 03949b9)
- Added additional .gitignore entries. (Hercules)
- Added a missing 'noteleport' mapflag for spl_in02. (bugreport:8925)
http://rathena.org/board/tracker/issue-8925-spl-in02-can-use-teleport/
- Fixed a leftover in atcommand documentation. (bugreport:8770)
http://rathena.org/board/tracker/issue-8770-dropall-atcommands-docs/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-04-25 12:31:32 -04:00
Akkarinage
810f79e781 Updated Hugel Field Renewal warps
Removed warps that shouldn't exist (bugreport:8868)
2014-04-04 13:13:37 +01:00
Euphy
e1903cb97a Fixed some equip location itemscripts. (bugreport:8821)
http://rathena.org/board/tracker/issue-8821-general-daehyon-card/

Added official names as comments in many newer scripts.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-26 01:47:37 -04:00
Jeric
156c5c848d Minor fix on BG script.
Based on this report.
http://rathena.org/board/tracker/issue-8813-minor-warning-on-battleground-script/
2014-03-24 10:15:08 +08:00
Euphy
e2fe7383e7 Minor bug fixes.
- Fixed incorrect item IDs in Port Malaya quests. (bugreport:8810)
http://rathena.org/board/tracker/issue-8810-quest-malaya/
- Updated Ship Captain Hat bonuses. (bugreport:8725)
http://rathena.org/board/tracker/issue-8725-item-bugs/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-21 00:21:38 -04:00
Euphy
c8d792488f Questlog fixes.
- Lost Child (bugreport:8791)
http://rathena.org/board/tracker/issue-8791-lost-child-quest/
- Muff's Loan (bugreport:8787)
http://rathena.org/board/tracker/issue-8787-muffs-loan/
- Peace For Arunafeltz (bugreport:8790, needs confirmation)
http://rathena.org/board/tracker/issue-8790-peace-for-arunafeltz/

Added base entries for new pets; bonuses are currently not properly implemented. (bugreport:8777)
http://rathena.org/board/tracker/issue-8777-pet-missing-tikbalang-database-entry/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-17 18:24:19 -04:00
Euphy
4889699376 Bug fixes.
- Fixed guild names for payg_cas02 and payg_cas04. (bugreport:8763)
http://rathena.org/board/tracker/issue-8763-castle-db-wrong-castle-names/
- Fixed OnTouch issues in Old Glast Heim instance. (bugreport:8738)
http://rathena.org/board/tracker/issue-8738-oldglastheim/
- Fixed a minor documentation issue with 'pcblockmove'. (bugreport:8706)
http://rathena.org/board/tracker/issue-8706-pcblockmove-description-incorrect/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-13 15:47:02 -04:00
Akkarinage
c480783921 Pull Request Test; Fixed engrish: test checkweight 2014-03-06 13:30:52 +00:00
Euphy
cad0a57865 Replaced 'getserverdef' command with 'script_hardcoded_constants' function in source. These constants can now be directly accessed in scripts. (Hercules 950e3eb)
- Relocated 'Option_*' constants from 'db/const.txt' to source; added OPTION_COSTUME compound. (Hercules a5728fd)
- Added MAX_CHAT_USERS define. (Hercules 950e3eb)
- Follow-up ca9642a: applied 'Loc' changes to Pre-Renewal database.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-03-01 15:42:49 -05:00
Euphy
944e7d041f Minor bug fixes.
- Changed 'bIgnoreDefRate' to 'bIgnoreDefRaceRate' in Pre-Renewal item database. (bugreport:8674)
http://rathena.org/board/tracker/issue-8674-item-bonus-error-or-not/
- Added missing 'bFixedCastrate' bonus for item 1832. (bugreport:8422)
http://rathena.org/board/tracker/issue-8422-vellum-claw-not-giving-insta-cast-on-10/
- Clarified 'getgmlevel()' and 'getgroupid()' functions in script documentation. (bugreport:8586, pull #46)
http://rathena.org/board/tracker/issue-8586-script-commandstxt-doc-getgroupid/
- Added Buying Store tables to source documentation.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-18 19:09:37 -05:00
Euphy
c7e020ad18 Added pRO/twRO "Card Exchange" NPC.
Information: http://richkidherbert.blogspot.com/2013/08/card-exchanger.html

Fixed incorrect position and view for item 18771. (bugreport:8657)
http://rathena.org/board/tracker/issue-8657-item-18771-enchanced-opera-phantom-mask-is-incorrect/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-16 01:40:29 -05:00
Euphy
a2d095f5c4 Item database update.
- Added/edited itemscripts for some new items.
- Corrected the persistence of many Hit- and Flee-increasing consumables, as they should dispel upon death. (incl. bugreport:8626)
http://rathena.org/board/tracker/issue-8626-accuracy-30-scroll-effect-when-death/

Hercules merges:
- Added optional 'count' parameter to script command 'successrefitem'. (9d1f80e)
- Atcommand bindings are now case-insensitive, like normal atcommands. (92be98c)
- Consumables without expire time no longer stack with rental items. (afcb4bc, bugreport:8458)
http://rathena.org/board/tracker/issue-8458-rent-item-bug/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-10 16:13:53 -05:00
Euphy
de46393592 Improved 'client_hash_check' config. (Hercules e4a1ca2)
- Added option to disable hash check by GM group_id (specify 'disabled' as hash for a certain group_id to let them log in with any client, even if 'client_hash_check' is enabled.
- Updated and reworded related documentation for the feature.

Improvements on script command 'axtoi'; added 'strtol'. (Hercules 1cf7c1e)
- Added script command 'strtol' (conforming to the ISO C90 function).
- Modified script command 'axtoi' to internally use 'strtol' instead of an unnecessary separate implementation.

Cleaned up many sections of script documentation, and modernized syntax in examples.
Added documentation for 'rentitem2' and 'makeitem2'. (follow-up 339c0a8)

Added 'true' (1) and 'false' (2) as script constants.

'freeloop' argument is now optional, and will only return the value of freeloop if no argument is given. (tid:92470)
http://rathena.org/board/topic/92470-freeloop-optional-argument/

Added a missing mapflag to custom 'devil_square' script. (bugreport:8611)
http://rathena.org/board/tracker/issue-8611-devil-square-bug/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-08 15:32:28 -05:00
Cydh Ramdh
3441d4a30b * Updated/added item_db, thank https://github.com/ROClientSide/Translation for some item view ids
* Follow up 0724d1e
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-05 19:07:05 +07:00
Euphy
0724d1ebab Minor updates.
* Added Cryptura Academy monster spawns, commented until the scripts are implemented. Does not include monsters from job quests.
* Fixed two label errors in Wizard job quest. (bugreport:8590)
http://rathena.org/board/tracker/issue-8590-wizard-job-quest-label-error/
* Updated AUTHORS file. (credits to AnnieRuru and Keyworld for providing some missing names)
* Uncommented a mapflag in custom 'mvp_ladder' script. (credits: AnnieRuru)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-04 21:35:36 -05:00
Cydh Ramdh
b4bdaebeeb * Replaced INF2_NO_AUTOSHADOWSPELL with INF2_AUTOSHADOWSPELL following AEGIS standard, reverted c9cf222.
* Fixed bugreport:8596 http://rathena.org/board/tracker/issue-8596-compile-warnings-with-fresh-svn/
* Removed temporary array while parsing shop NPC, makes remove the limit 100 items each NPC
* Added idRO cash trader according to Chinese New Year event

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-02-04 12:32:38 +07:00
Euphy
163a98cbc4 Major custom folder update!
These scripts have been chosen for being unique and useful, yet structurally simple. In this way, they can serve as usable reference material for future user scripts.

Contents:
* Battleground: bg_emp (Emperium breaker), bg_pvp (PVP match)
* Event: mvp_ladder (kill every MVP to win), devil_square (3-round monster summoning event)
* Utility: card_seller (sells all monster cards), mvp_room (private MVP summoning room), autopot (automatically use potions when hit)
Credits to AnnieRuru for offering up her scripts and modifying them for use.

Other changes:
* Moved previous custom battleground scripts into 'battleground/unofficial/'.
* Moved custom holiday event scripts into 'event/holiday/'.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-02 17:35:28 -05:00
Euphy
007b88f2bb Added "Merry Badger" NPC to iRO Eden, and other tweaks. (credits: @SkittleNugget, pull #44)
Follow-up 957f495: 'preg_match' will still be compiled for users with PCRE disabled. (tid:92024)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-31 03:11:18 -05:00
Euphy
957f49563a Added 'preg_match' script command to match regular expressions.
The command is only available if the PCRE library is installed.

Updated indefinite articles in Global_Functions with regex. (credits: Kaivosukeltaja/php-indefinite-article/863f1d5)

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-29 16:33:27 -05:00
Euphy
ad13f26fc2 'consumeitem' no longer requires npc_id to run. (bugreport:8563, credits: AnnieRuru)
Second part of the bug report is not yet fixed.
http://rathena.org/board/tracker/issue-8563-consumeitem-doesnt-work-if-the-npc-id-is-0-example-bonus-script/

Replaced a few 'consumeitem' commands in scripts that were broken.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-28 03:00:48 -05:00
Euphy
21122d7a87 Some bug fixes.
* Ninja Cutter (13074) is not refineable, causing KG/OB quest to halt. (bugreport:8542)
http://rathena.org/board/tracker/issue-8542-ninja-cutter-cannot-be-refined/
* Treasure Chest (2335) in Bakonawa's Lake instance drops incorrect spirit piece. (bugreport:8294)
http://rathena.org/board/tracker/issue-8294-treasure/
* Slightly edited coordinates of two RE Izlude traders.
* Follow-up 3813aaa: fixed a typo on item 22669.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-24 21:44:36 -05:00
Euphy
3813aaaadb Added 2013 iRO/kRO Christmas Event.
Updated item database with many new costumes.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-24 15:19:27 -05:00
Euphy
5a1f3f95c4 Minor edits and follow-ups.
Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-01-23 13:25:15 -05:00
lighta
8115dc048a Checkweight
-Fix bugreport:8503 (chkweight uint16 limitation on weight thx to
AnnieRuru)
-Add this testcase on npc_test_checkweight.txt and move it to npec/tests
folder.
2014-01-23 12:36:52 -05:00
aleos89
27cbc7ff24 Merge pull request #40 from Lemongrass3110/master
Added autotrade persistence support.
- Players who are autotrading during a crash/shut down will be restored on start up.
- Live vendor data is stored in SQL.
- Credits to Ind and Lemongrass.
2014-01-23 07:49:18 -08:00