Faster and with no module bias
Removed rnd_init, rnd_uint32 and rnd_uniform
From now on we will only use rnd_value(min, max) for values in range [min, max] and rnd_chance(chance, base) for chances
Fixes#7881Fixes#7883Fixes#7884Fixes#7885
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
* Fixes#7771.
* Adds a missing check to avoid warping players who are actively jailed out early after relogging.
Thanks to @fab10Carvalho and @Lemongrass3110!
Deals normal long ranged physical damage to the target.
Can only be used when riding dragon.
Deals additional damage depends on user's MaxHP and MaxSP.
Affected by Hit/Flee calculation.
Ignores physical defense.
Damage property depends on weapon property.
Affected by attack modifiers (such as race modifier).
Recovers 2 AP.
When using while under Dragonic Aura buff, increases influence of MaxHP and MaxSP in skill damage.
Fixed casting time : 0.5 seconds (based on level 10).
Variable Casting time : 2 seconds (based on level 10).
Cooldown: 0.5 seconds (based on level 10).
Global cool time : 0.15 seconds (based on level 10).
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Credit to @datawulf
* Implemented BO_EXPLOSIVE_POWDER
- Deals melee physical damage to all targets around the user.
- Doesn't need any catalyst.
- When using while under Research Report buff, increases damage and number of hit.
- Recovers 2 AP.
- Fixed casting time : - (based on level 5).
- Variable Casting time : - (based on level 5).
- Cooldown: 0.7 seconds (based on level 5).
- Global cool time : 0.25 seconds (based on level 5).
* Implemented BO_MAYHEMIC_THORNS
- Deals long ranged physical damage to the target and surrounding enemies around the target with the range up to 9x9 cells.
- Doesn't need any catalyst.
- Has a chance to trigger critical, the critical chance is the user's cri.
- When using while under Research Report buff, increases damage and number of hit.
- Recovers 2 AP.
- Fixed casting time : 0.5 seconds (based on level 10).
- Variable Casting time : 1 second (based on level 10).
- Cooldown: 0.7 seconds (based on level 10).
- Global cool time : 0.15 seconds (based on level 10).
* Skills updated to 2nd rebalance
Credit to @datawulf
* Implemented MT_MIGHTY_SMASH
- Deals melee physical damage to all targets around the user.
- When using while under Axe Stomp buff, increases damage and number of hit.
- Fixed casting time : - (based on level 10).
- Variable Casting time : - (based on level 10).
- Cooldown: 0.3 seconds (based on level 10).
- Global cool time : - (based on level 10).
* Updated Mighty Smash to last rebalance
- Increases cooldown from 0.3 seconds to 0.5 seconds.
- Adds global cool time by 0.25 seconds.
- Increases SP consumption from 78 to 95 based on level 10.
- Reduces base damage from 3100%/3150%Atk to 1825%/1850%Atk per hit based on level 10.
- Increases number of hit from 3/5 hits to 5/7 hits.
- While under Axe Stomp buff, increases factor weight of POW in skill formula from 7 to 10.
* Implemented MT_TRIPLE_LASER
- Deals long ranged physical damage to the target.
- Can only be used when using Madogear.
- Has a chance to trigger critical, the critical chance is the user's cri.
- Damage property depends on weapon property.
- Doesn't consume magic gear fuel or cannonball.
- Fixed casting time : 0.5 seconds (based on level 5).
- Variable Casting time : 1 seconds (based on level 5).
- Cooldown: 0.25 seconds (based on level 5).
- Global cool time : - (based on level 5).
* Updated Triple Laser to last rebalance
- Increases cooldown from 0.25 seconds to 0.35 seconds.
- Adds global cool time by 0.25 seconds.
- Increases base damage from 3300%Atk to 5050%Atk per hit based on level 5.
- Increases factor weight of POW in skill formula from 10 to 12.
* Implemented MT_SPARK_BLASTER
- Deals long ranged physical damage to the target and surrounding enemies around the target with the range up to 9x9 cells.
- Can only be used when using Madogear.
- Affected by Hit/Flee calculation.
- Ignores physical defense.
- Doesn't consume magic gear fuel or cannonball.
- Damage property depends on weapon property.
- Recovers 2 AP.
- Fixed casting time : 0.5 seconds (based on level 10).
- Variable Casting time : 1.5 seconds (based on level 10).
- Cooldown: 0.7 seconds (based on level 10).
- Global cool time : 0.25 seconds (based on level 10).
* Updated Spark Blaster to last rebalance
- Reduces cooldown from 0.7 seconds to 0.5 seconds.
- Increases base damage from 7750%Atk to 9250%Atk based on level 10.
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Credits to @datawulf
* Follow up to 65200eb.
* Removes a lot of else cases when parsing monster data.
* Fixes an issue where the damagetaken value of monsters would be reset after issuing a mob_spawn().
Thanks to @Lemongrass3110, @mplaten, and @vstumpf!
* Fixes#7904 and fixes#7916.
* Resolves NPC_RUN and NPC_RANDOMMOVE monsters not always reaching their intended escape distance.
* Resolves Marine Sphere calling the run skill too early resulting in the distance escaped not always being the same.
* Resolves Wink of Charm not forcing the target to fail skill use on the caster.
* Renames the monster alchemist state to can_escape to fit multiple uses.
Thanks to @Leemonn and @Lemongrass3110!
* Fixes#7191.
* Adds a buy and sell safety check from the Market Shop type.
* Also includes an item validation check when loading items from SQL for Market Shops.
Thanks to @mazvi!
* Do not exit the process while receiving crash signal so that the system will make core dump correctly.
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
* Sound Blend
- Reduces SP consumption from 128 to 80 based on level 5.
* Metallic Fury
- Reduces cooldown from 0.5 seconds to 0.3 seconds.
- Reduces SP consumption from 168 to 94 based on level 5.
- Reduces AP recovery rate from 3 to 2 based on level 5.
- Increases damage from 4500%/4950~6750%(area damage according to number of branded target)Matk to 11000%/12500~18500%(area damage according to number of branded target)Matk based on level 5.
* Rhythm Shooting
- Adds 0.15 seconds cooldown.
- Removes 0.15 seconds delay after skill.
- Reduces SP consumption from 90 to 52 based on level 5.
- Increases damage from 600%/780%(branded target)Atk to 800%/1400%(branded target)Atk based on level 5.
- Increases factor weight of CON in skill formula from 2 to 3.
* Rose Blossom
- Reduces variable casting time from 2 seconds to 1 second.
- Increases cooldown from 0.5 seconds to 0.7 seconds.
- Reduces SP consumption from 125 to 94 based on level 5.
- Increases damage from 3750%/1750%(area damage)Atk to 11200%/15250%(area damage)Atk based on level 5.
- Increases factor weight of CON in skill formula from 3/2(area damage) to 3/3(area damage).
Checked against https://github.com/rathena/rathena/pull/7024
Credit to @datawulf for Metallic Fury update
* Overslash
- Reduces cooldown from 1 second to 0.7 seconds.
- Reduces SP consumption from 68 to 65 based on level 5.
- Increases AP recovery rate from 2 to 3.
- Increases damage from 1800%Atk to 2200%Atk per hit based on level 10 (Spear & Sword Mastery level 10).
Already implemented
- Increases factor weight of POW in skill formula from 2 to 5.
* Shield Shooting
- Reduces cooldown from 1 second to 0.7 seconds.
- Increases AP recovery rate from 2 to 3.
- Increases damage from 6440%Atk to 14440%Atk based on level 5 (Shield Mastery level 10, shield refine rate is 10 and shield weight is 150).
Already implemented
- Increases factor weight of POW in skill formula from 3 to 5.
Notes
- Factor weight of shield refine rate is taken from next rebalance: "Increases factor weight of shield refine rate in skill formula from 4 to 25."
- Factor weight of the shield weight is deduced from the skill base damage: 11900%Atk on level 5.
* Cross Rain
- Reduces cooldown from 5 seconds to 4.5 seconds.
- Reduces delay after skill from 0.5 seconds to 0.15 seconds.
- Increases SP consumption from 68 to 78 based on level 10.
- Increases AP recovery rate from 5 to 7.
- Increases damage from 2000%/3500%(Holy Shield)Matk to 3700%/5500%(Holy Shield)Matk per hit based on level 10 (Spear & Sword Mastery level 10).
* Grand Judgement
- Reduces cooldown from 60 seconds to 5 seconds.
- Removes 0.5 seconds delay after skill.
- Increases SP consumption from 68 to 78 based on level 10.
- Reduces AP consumption from 150 to 15.
- Reduces duration of Grand Judgement buff from 300 seconds to 150 seconds.
- Increases damage from 7500%/11000%(plant and insect race)Atk to 15250%/16850%(plant and insect race)Atk based on level 10.
* Judgement Cross
- Reduces cooldown from 60 seconds to 5 seconds.
- Removes 0.5 seconds delay after skill.
- Reduces SP consumption from 150 to 105 based on level 10.
- Reduces AP consumption from 150 to 10.
- Increases damage from 7500%/11000%(plant and insect race)Matk to 19500%/21000%(plant and insect race)Matk based on level 10.
* Vigor
- Changes bonus flat damage from +200% regardless of skill level to scaling with skill level up to +250% based on level 10.
- Increases bonus damage against demihuman and angel race monsters from 50% to 100%.
- Reduces AP consumption from 150 to 125.
- Increases HP consumption on each attack from 2 to 10 based on level 10.
* Dragonic Aura
- Reduces delay after skill from 1 second to 0.5 seconds.
- Increases damage from 9500%/14000%(demihuman and angel race)Atk to 36500%/38000%(demihuman and angel race)Atk based on level 10.
* Madness Crusher
- Removes 0.4 seconds variable casting time.
- Increases fixed casting time from 0.4 seconds to 0.5 seconds.
- Increases damage from 1350%Atk to 5150%Atk based on level 5 (using level 5 weapon and weapon weight is 150). (additional note: 4400% Atk on level 5 without weapon weight)
- Increases SP consumption from 50 to 68 based on level 5.
- Increases AP recovery rate from 2 to 3.
- Increases factor weight of POW in skill formula from 5 to 7.
* Storm Slash
- Reduces cooldown from 0.35 seconds to 0.3 seconds.
- Increases AP recovery rate from 1 to 2.
- Increases damage from 600%Atk to 950%Atk per hit based on level 5.
- Increases the chance to double skill damage while under Giant Growth buff from 15% to 30%.
* Servant Weapon - Demolition
- Reduces cooldown from 3 seconds to 0.5 seconds.
- Reduces AP recovery rate from 3 to 2.
- Increases damage from 750%Atk to 2500%Atk per hit based on level 5.
* Servant Weapon - Phantom
- Removes 0.8 seconds variable casting time.
- Reduces cooldown from 2 seconds to 0.5 seconds.
- Removes 0.8 seconds delay after skill.
- Increases damage from 600%Atk to 1700%Atk per hit based on level 5.
* Servant Weapon
- Increases number of hit from 1 hit to 2 hits.
- Increases damage from 450%Atk to 2500%Atk per hit based on level 5.
* Hack and Slasher
- Changes damage logic from 2 split hits to 2 cumulative hits.
- Increases damage from 3000%Atk to 7300%Atk per hit based on level 10.
- Increases cooldown from 0.3 seconds to 0.7 seconds.
- Reduces delay after skill from 0.5 seconds to 0.25 seconds.
- Increases SP consumption from 70 to 72 based on level 10.
- Increases factor weight of POW in skill formula from 5 to 7.
Thanks to @aleos89 !
* Floral Flare Road
- Reduces delay after skill from 0.5 seconds to 0.25 seconds.
- Increases SP consumption from 70 to 94 based on level 5.
- Increases damage from 1000%Matk to 3750%Matk per hit based on level 5.
* Rain of Crystal
- Reduces delay after skill from 0.5 seconds to 0.25 seconds.
- Increases SP consumption from 80 to 100 based on level 5.
- Increases damage from 750%Matk to 3980%Matk per hit based on level 5.
* Tornado Storm
- Reduces delay after skill from 0.5 seconds to 0.25 seconds.
- Increases SP consumption from 75 to 94 based on level 5.
- Increases damage from 450%Matk to 3900%Matk per hit based on level 5.
* Stratum Tremor
- Reduces delay after skill from 0.5 seconds to 0.25 seconds.
- Increases SP consumption from 75 to 94 based on level 5.
- Increases damage from 1250%Matk to 3750%Matk per hit based on level 5.
* Crimson Arrow
- Reduces SP consumption from 105 to 94 based on level 5.
- Increases AP recovery rate from 1 to 2.
* Frozen Slash
- Increases cooldown from 0.3 seconds to 0.45 seconds.
- Increases SP consumption from 85 to 96 based on level 5.
- Increases AP recovery rate from 1 to 2.
- Increases damage from 3000%/4250%(Climax)Matk to 4750%/6650%(Climax)Matk based on level 5.
* Storm Cannon
- Reduces SP consumption from 100 to 94 based on level 5.
- Increases AP recovery rate from 1 to 2.
- Increases damage from 3000%/4250%(Climax)Matk to 4750%/6250%(Climax)Matk based on level 5.
* Rock Down
- Increases SP consumption from 85 to 92 based on level 5.
- Increases AP recovery rate from 1 to 2.
- Increases damage from 3000%/4250%(Climax)Matk to 4750%/6250%(Climax)Matk based on level 5.
* All Bloom
- Reduces delay after skill from 1 second to 0.5 seconds.
- Increases SP consumption from 100 to 126 based on level 5.
- Increases damage from 500%Matk to 6200%Matk per hit based on level 5.
- No longer reduce skill damage on Climax level 2.
- Increases bonus damage on Climax level 3 from 100% to 300%.
- Increases damage of additional explosion on Climax level 5.
* Crystal Impact
- Reduces cooldown from 6 seconds to 2 seconds.
- Reduces delay after skill from 1 second to 0.5 seconds.
- Increases SP consumption from 120 to 132 based on level 5.
- Increases damage from 4000%/4000%(secondary)Matk to 6750%/6750%(secondary)Matk based on level 5.
* Destructive Hurricane
- Reduces cooldown from 6 seconds to 2 seconds.
- Reduces delay after skill from 1 second to 0.5 seconds.
- Increases SP consumption from 120 to 132 based on level 5.
- Increases damage from 8000%Matk to 14250%Matk based on level 5.
- Increases bonus damage on Climax level 3 from 100% to 200%.
- Reduces bonus damage on Climax level 5 from 70% to 50%.
Skipped (unknown value)
- Increases damage of additional hit on Climax level 1.
* Violent Quake
- Reduces delay after skill from 1 second to 0.5 seconds.
- Increases SP consumption from 100 to 126 based on level 5.
- Increases damage from 600%Matk to 6200%Matk per hit based on level 5.
- Increases bonus damage on Climax level 3 from 100% to 200%.
* Deadly Projection
- Reduces SP consumption from 120 to 90 based on level 5.
- Increases damage from 3600%Matk to 14000%Matk based on level 5.
* Mystery Illusion
- Reduces delay after skill from 1 second to 0.5 seconds.
- Reduces SP consumption from 120 to 110 based on level 5.
- Increases AP recovery rate from 4 to 5.
- Increases damage from 2500%Matk to 4750%Matk per hit based on level 5.
* Astral Strike
- Reduces cooldown from 60 second to 6 seconds.
- Reduces SP consumption from 150 to 130.
- Reduces AP consumption from 150 to 25.
- Increases initial damage from 5000%/11000%(undead and dragon race)Matk to 18000%/21400%(undead and dragon race)Matk based on level 10.
- Increases over time damage from 2000%Matk to 6500%Matk per hit based on level 10.
- Reduces skill duration from 15 seconds to 6 seconds.
* Soul Vulcan Strike
- Increases damage from 900%Matk to 1250%Matk per hit based on level 5.
- Reduces SP consumption from 120 to 110 based on level 5.
* Conflagration
- Increases SP consumption from 110 to 113 based on level 5.
- Increases damage from 2000%/4000%(spirit)Matk to 3750%/5750%(spirit)Matk per hit based on level 5.
* Diamond Storm
- Reduces cooldown from 2 seconds to 1 second.
- Reduces SP consumption from 100 to 96 based on level 5.
- Increases damage from 6250%/12250%(spirit)Matk to 8150%/14400%(spirit)Matk based on level 5.
- Increases factor weight of SPL in skill formula from 5/7(spirit) to 5/10(spirit).
* Lightning Land
- Increases SP consumption from 95 to 110 based on level 5.
- Increases damage from 2000%/4000%(spirit)Matk to 3750%/5750%(spirit)Matk per hit based on level 5.
* Terra Drive
- Reduces cooldown from 2 seconds to 1 second.
- Reduces SP consumption from 100 to 96 based on level 5.
- Increases damage from 6250%/12250%(spirit)Matk to 8150%/14400%(spirit)Matk based on level 5.
- Increases factor weight of SPL in skill formula from 5/7(spirit) to 5/10(spirit).
* Corrected the SPL weight of EM_DIAMOND_STORM and EM_TERRA_DRIVE
* Venom Swamp
- Increases SP consumption from 100 to 112 based on level 5.
- Increases damage from 2000%/4000%(spirit)Matk to 3750%/5750%(spirit)Matk per hit based on level 5.
* Elemental Buster
- Reduces fixed casting time from 2 seconds to 1.5 seconds.
- Reduces cooldown from 60 seconds to 5 seconds.
- Reduces delay after skill from 1.5 seconds to 0.5 seconds.
- Reduces SP consumption from 150 to 140.
- Reduces AP consumption from 150 to 30.
- Increases damage from 4800%/11000%(formless and dragon race)Matk to 22500%/24000%(formless and dragon race)Matk based on level 10.
* Abyss Dagger
- Increases SP consumption from 60 to 64 based on level 5.
- Increases damage from 1750%Atk to 2600%Atk per hit based on level 5.
* Deft Stab
- Increases SP consumption from 55 to 62 based on level 10.
- Increases AP recovery rate from 2 to 3.
- Increases damage from 3600%Atk to 5850%Atk based on level 10.
- Increases area of effect from 5 x 5 cells to 7 x 7 cells based on level 10.
* From the Abyss
- Increases number of hit from 1 hit to 2 hits.
- Increases damage from 500%Matk to 2600%Matk per hit based on level 5.
* Abyss Square
- Increases AP recovery rate from 4 to 5.
- Increases damage from 2000%Matk to 3850%Matk per hit based on level 5 (Magic Sword Mastery level 10).
* Chain Reaction Shot
- Reduces cooldown from 1.5 seconds to 1 second.
- Removes 0.5 seconds delay after skill.
- Reduces SP consumption from 80 to 75 based on level 5.
- Increases area of effect of secondary damage from 3 x 3 cells to 7 x 7 cells.
- Increases area of effect of primary damage from 7 x 7 cells to 9 x 9 cells based on level 5.
- Increases damage from 3000%(primary)/4750%(secondary)Atk to 4250%(primary)/12350%(secondary)Atk based on level 5.
- Increases factor weight of CON in skill formula from 5 to 15.
* Frenzy Shot
- Reduces SP consumption from 125 to 55 based on level 10.
- Increases damage from 3500%Atk to 4000%Atk per hit based on level 10.
* Omega Abyss Strike
- Reduces cooldown from 60 seconds to 3 seconds.
- Reduces SP consumption from 150 to 125.
- Reduces AP consumption from 150 to 15.
- Increases damage from 6000%/11500%(angel and demon race)Matk to 22000%/23500%(angel and demon race)Matk based on level 10.
